mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Andersson <andersson@kernel.org>
To: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,  gaurav.kohli@oss.qualcomm.com
Subject: Re: [PATCH] arm64: dts: qcom: pm8005: Add pmic cooling maps
Date: Mon, 31 Aug 2026 11:20:07 -0500	[thread overview]
Message-ID: <apWpLRl38UMlbaty@baldur> (raw)
In-Reply-To: <20260810-shikra-pmic-die-v1-1-b4ba21f254a0@oss.qualcomm.com>

On Mon, Aug 10, 2026 at 10:43:08AM +0530, Dipa Ramesh Mantre wrote:
> Add CPU mitigation cooling maps for pm8005 PMIC die temperature.
> Throttle LITTLE (cpu0) and big (cpu3) clusters at 105°C and 125°C
> trip points.
> 

https://docs.kernel.org/process/submitting-patches.html#describe-your-changes:

Describe your problem. Whether your patch is a one-line bug fix or 5000
lines of a new feature, there must be an underlying problem that
motivated you to do this work. Convince the reviewer that there is a
problem worth fixing and that it makes sense for them to read past the
first paragraph.

> Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/pm8005.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pm8005.dtsi b/arch/arm64/boot/dts/qcom/pm8005.dtsi
> index ce31a8545020..820d213b1cb2 100644
> --- a/arch/arm64/boot/dts/qcom/pm8005.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8005.dtsi
> @@ -3,10 +3,12 @@
>  
>  #include <dt-bindings/spmi/spmi.h>
>  #include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/thermal/thermal.h>
>  
>  / {
>  	thermal-zones {
>  		pm8005-thermal {
> +			polling-delay-passive = <200>;
>  			thermal-sensors = <&pm8005_tz>;
>  
>  			trips {
> @@ -28,6 +30,20 @@ pm8005_trip2: trip2 {
>  					type = "critical";
>  				};
>  			};
> +
> +			cooling-maps {
> +				map0 {
> +					trip = <&pm8005_trip0>;
> +					cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +							 <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> +				};
> +
> +				map1 {
> +					trip = <&pm8005_trip1>;
> +					cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +							 <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> +				};
> +			};
>  		};
>  	};
>  };
> 
> ---
> base-commit: cc2b5f627e8ccbae1188ef2d8be3e451d7f933a5
> change-id: 20260809-shikra-pmic-die-a6a43e17c1bc
> prerequisite-message-id: <20260715-shikra_adc_support-v4-0-5e07b6d21429@oss.qualcomm.com>
> prerequisite-patch-id: 7c371f4d9b9af04a9765b0b5b084c498e8979fb6
> prerequisite-patch-id: dde0d9ae1d46c16407cfcfa818dd427904748af8
> prerequisite-patch-id: aebf50762e984054665421a5a962e919947b16f7
> prerequisite-patch-id: 6f74cc35e7368d525d7f7ebe6342f5d3c82f9d0f

I'm guessing since you depend on some feature branch called "adc
support" this patch can't be applied. Work with your peers to land your
dependencies and then build and TEST on the clean upstream branch.

Thanks,
Bjorn

> 
> Best regards,
> -- 
> Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
> 

      parent reply	other threads:[~2026-08-31 16:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10  5:13 Dipa Ramesh Mantre
2026-08-18  9:19 ` Konrad Dybcio
2026-08-24  7:36   ` Dipa Ramesh Mantre (Temp)
2026-08-31 16:20 ` Bjorn Andersson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apWpLRl38UMlbaty@baldur \
    --to=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dipa.mantre@oss.qualcomm.com \
    --cc=gaurav.kohli@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®