mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: Weijie Yuan <wy@wyuan.org>
Cc: "zhen.ni" <zhen.ni@easystack.cn>,
	 "Vlastimil Babka (SUSE)" <vbabka@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	 David Hildenbrand <david@kernel.org>,
	"Liam R . Howlett" <liam@infradead.org>,
	 Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	 Michal Hocko <mhocko@suse.com>, Jonathan Corbet <corbet@lwn.net>,
	 Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	 Brendan Jackman <brendan.jackman@linux.dev>,
	Johannes Weiner <hannes@cmpxchg.org>, Zi Yan <ziy@nvidia.com>,
	 linux-mm@kvack.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	 Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v2 0/8] mm/page_owner: Add PID/TGID/COMM and cgroup filtering
Date: Tue, 8 Sep 2026 10:13:22 +0100	[thread overview]
Message-ID: <ap_P_Pvlpn2rEjBV@gremlin> (raw)
In-Reply-To: <ap-zYt-1qCBGKZed@wyuan.org>

On Tue, Sep 08, 2026 at 03:04:02PM +0800, Weijie Yuan wrote:
> On Tue, Sep 08, 2026 at 02:40:10PM +0800, zhen.ni wrote:
> >
> >
> > 在 2026/9/8 14:24, Weijie Yuan 写道:
> > >  From an outsider..
> > >
> > > On Tue, Sep 08, 2026 at 10:41:23AM +0800, zhen.ni wrote:
> > > > >
> > > > > Sorry but your whole reply reads like a LLM slop. It took a lot of
> > > > > mental effor to actually try and engage with it.
> > > > >
> > > >
> > > > This reply was written by me, and its viewpoints are not simply copied
> > > > directly from an LLM. The LLM only assists with the wording.
> > >
> > > So that's probably the reason. Your previous replies was indeed very
> > > much like the output of an LLM. Even if the idea is your own, after
> > > being "polished" by LLM, it's hard to read. I know English is not our
> > > first language, and it's not that easy to speak like a native speaker.
> > > But may I ask you did you read it before sending them out? I really
> > > found this bunch of overly formal content a little painful to read.
> > >
> > > So I suspect the LLM may have taken too much liberty in polishing your
> > > text, to the point that your replies no longer read like something a
> > > person would naturally write.
> > >
> > > The "Summary and Plan" in your reply in v1, both in its formatting and
> > > wording, looks quite similar to LLM-generated text to me. So I can
> > > understand why Lorenzo asked whether you had used an LLM. Come on, we
> > > all know what LLM writing looks like.
> > >
> > > That said, I do not know exactly how you used the LLM on your original
> > > text, so please forgive me if I have this wrong.
> > >
> > > Thanks.
> > >
> > I really can't distinguish the LLM flavor that clearly in English.
>
> Yes, sometimes I can not as well. But I guess the native ones can.
> So.. ;-)
>
> > I'm sorry for causing some trouble.
>
> That's fine. No need to say sorry.
>
> I know and understand that we non-native speakers would rather not make
> mistakes over these little language detail issues. But over-polishing
> can end up having the opposite effect. Keeping some of your natural
> writing style may actually be what the community prefers, especially
> these AI days.
>
> > My normal reply process is to first describe my ideas, then have the
> > LLM check for logic and grammar issues, and do a round of polishing. I
> > check the final draft once more to see if it has deviated from my
> > ideas, and make corresponding revisions.
>
> Sigh, so it is hard to know where to draw the line. Write more and learn
> more about "human-like" writing, perhaps. :)
>
> Thanks!

Thanks Weijie appreciate your input :) and it's good to get a perspective from a
non-native speaker on this!

Generally I empathise with LLM usage for helping non-native speakers with
English, that's a great use of it, so I don't object to it _in general_ BUT as
Weijie points out there's better ways of using and worse ways of using it.

You have to ensure that your meaning is transmitted properly without it
ultimately becoming essentially a conversation between a reviewer and an LLM.

So the technial discussion you are engaging in MUST be your own.

As for the 'summary' emails - please don't send them at all.

I feel like often they're used to generate a new prompt for the LLM and it
really ends up being 'workslopping', that is, making reviewers do more work
while the LLM takes care of things for you.

And that crosses the line really from 'aid to English' into it being a problem.

Instead, ENGAGE IN CONVERSATION with the reviewer, in line.

So if a review says:

"Please make this function do X, Y, Z".

Don't put something in a summary email or anything like that. REPLY to them,
quoting the request and respond. Like:

	> Please make this function do X, Y, Z.

	OK makes sense about X, Y is a bit tricker because of ... and Z is
	impossible because ....

For instance.

That way it is human-to-human interaction at all times, with maybe the LLM
helping with translation along the way.

As for the review - Vlastimil has raised legitimate technical points so I would
engage with those directly.

It's very reasonable for him to conclude an LLM was used for more than
translation, certainly the rather ludicrious 'document the world in the commit
message' approach looks inhuman.

So engage on the technical points without summary emails, and please put
documentation in a documentation file :)

Also I think it's reasonable now for you to use an:

	Assisted-by: LLM

Tag on this series.

--
Cheers, Lorenzo

  reply	other threads:[~2026-09-08  9:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03  4:18 Zhen Ni
2026-09-03  4:18 ` [PATCH v2 1/8] mm/page_owner: Add PID filtering support Zhen Ni
2026-09-03  4:18 ` [PATCH v2 2/8] mm/page_owner: Add TGID " Zhen Ni
2026-09-03  4:18 ` [PATCH v2 3/8] mm/page_owner: Add COMM filtering with wildcard support Zhen Ni
2026-09-03  4:18 ` [PATCH v2 4/8] mm/page_owner: Refactor memcg handling for cgroup filter support Zhen Ni
2026-09-03  4:18 ` [PATCH v2 5/8] mm/page_owner: Add memcg " Zhen Ni
2026-09-03  4:18 ` [PATCH v2 6/8] tools/mm: Add PID/TGID/COMM filtering support to page_owner_filter Zhen Ni
2026-09-03  4:18 ` [PATCH v2 7/8] tools/mm: Add memory cgroup " Zhen Ni
2026-09-03  4:18 ` [PATCH v2 8/8] Documentation: page_owner: Document PID/TGID/COMM and cgroup filters Zhen Ni
     [not found] ` <20260902221225.228fb4b18e115ba55b29fe29@linux-foundation.org>
2026-09-03 12:00   ` [PATCH v2 0/8] mm/page_owner: Add PID/TGID/COMM and cgroup filtering zhen.ni
2026-09-04  8:25 ` Vlastimil Babka (SUSE)
2026-09-07  4:08   ` zhen.ni
2026-09-07 15:21     ` Vlastimil Babka (SUSE)
2026-09-08  2:41       ` zhen.ni
2026-09-08  6:24         ` Weijie Yuan
2026-09-08  6:40           ` zhen.ni
2026-09-08  7:04             ` Weijie Yuan
2026-09-08  9:13               ` Lorenzo Stoakes (ARM) [this message]
2026-09-08 11:18                 ` zhen.ni
2026-09-08 17:37                 ` Weijie Yuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ap_P_Pvlpn2rEjBV@gremlin \
    --to=ljs@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=brendan.jackman@linux.dev \
    --cc=corbet@lwn.net \
    --cc=david@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=liam@infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=rdunlap@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=rppt@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    --cc=wy@wyuan.org \
    --cc=zhen.ni@easystack.cn \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®