From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Flaviu Nistor <flaviu.nistor@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Nuno Sa <nuno.sa@analog.com>, Andy Shevchenko <andy@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Daniel Baluta <daniel.baluta@nxp.com>,
Antoniu Miclaus <antoniu.miclaus@analog.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v3 2/2] iio: adc: ti-ads1015: Add support for label
Date: Tue, 8 Sep 2026 13:31:31 +0300 [thread overview]
Message-ID: <ap_kA8laT70faM9B@ashevche-desk.local> (raw)
In-Reply-To: <20260907152304.4992-2-flaviu.nistor@gmail.com>
On Mon, Sep 07, 2026 at 06:23:04PM +0300, Flaviu Nistor wrote:
> Add support for label sysfs attribute similar to other adc devices. This is
> particularly useful because the label can match the schematic signal name,
> identifying channel voltages easier if label is defined via device tree.
...
> +static int ads1015_read_label(struct iio_dev *indio_dev,
> + struct iio_chan_spec const *chan, char *label)
> +{
> + struct ads1015_data *data = iio_priv(indio_dev);
> + const char *name = data->channel_data[chan->address].label;
> +
> + /*
> + * Avoid printing "(null)" in the console in case label property
> + * is missing for the channel, or channel is not defined.
> + */
> + if (!name)
> + name = chan->datasheet_name;
Is the datasheet_name static? Can this rather be made only once
at the probe time?
> + return sysfs_emit(label, "%s\n", name);
> +}
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-09-08 10:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 15:23 [PATCH v3 1/2] dt-bindings: iio: adc: ti,ads1015: Add label property Flaviu Nistor
2026-09-07 15:23 ` [PATCH v3 2/2] iio: adc: ti-ads1015: Add support for label Flaviu Nistor
2026-09-08 10:31 ` Andy Shevchenko [this message]
2026-09-08 16:29 ` Flaviu Nistor
2026-09-08 4:41 ` [PATCH v3 1/2] dt-bindings: iio: adc: ti,ads1015: Add label property Andy Shevchenko
2026-09-08 16:28 ` Flaviu Nistor
2026-09-08 4:42 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ap_kA8laT70faM9B@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=flaviu.nistor@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®