From: Bjorn Andersson <andersson@kernel.org>
To: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
Gokul Krishna Krishnakumar <gokul.krishnakumar@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] remoteproc: qcom_q6v5_pas: Add per-PD proxy performance states for Hawi CDSP
Date: Tue, 1 Sep 2026 11:28:45 -0500 [thread overview]
Message-ID: <apb86I2HGXcUAoG9@baldur> (raw)
In-Reply-To: <20260831191621.ogqnsmvzv3o5mlbq@hu-mojha-hyd.qualcomm.com>
On Tue, Sep 01, 2026 at 12:46:21AM +0530, Mukesh Ojha wrote:
> On Mon, Aug 31, 2026 at 10:56:55AM -0500, Bjorn Andersson wrote:
> > On Fri, Aug 28, 2026 at 11:43:11PM +0530, Mukesh Ojha wrote:
> > > The proxy power domain enable path currently requests INT_MAX performance
> > > state for every proxy PD. While this serves as a "take highest available"
> > > hint, some SoCs require specific per-domain RPMH levels for correct
> > > operation during firmware load rather than a blanket maximum.
> > >
> > > Introduce a proxy_pd_performance_states array in qcom_pas_data to allow
> > > each proxy PD to declare its required RPMH performance level explicitly.
> > > Platforms that do not populate this field retain the existing INT_MAX
> > > behaviour.
> > >
> >
> > Is it possible to encode this using an optional opp-table instead of
> > filling the driver with such details? (This is a question, not a direct
> > suggestion)
>
> Technically yes, via required-opps, each proxy PD would need its own
> opp-table and the remoteproc node would reference specific OPP entries via
> phandles. That is heavyweight machinery for three scalar values used only
> during the transient firmware-load window. But let me know if you see the
> benefit.
>
I don't like sprinkling these details throughout drivers, but if that's
the alternative I guess your proposed solution is the lesser of two
evils.
Thank you,
Bjorn
prev parent reply other threads:[~2026-09-01 16:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 18:13 [PATCH 1/3] remoteproc: qcom_q6v5_pas: Fix unbalanced enable for handover IRQ after attach Mukesh Ojha
2026-08-28 18:13 ` [PATCH 2/3] remoteproc: qcom_q6v5: Skip handover callback if already issued Mukesh Ojha
2026-08-31 5:52 ` Stephan Gerhold
2026-08-31 15:57 ` Bjorn Andersson
2026-08-31 17:24 ` Mukesh Ojha
2026-08-28 18:13 ` [PATCH 3/3] remoteproc: qcom_q6v5_pas: Add per-PD proxy performance states for Hawi CDSP Mukesh Ojha
2026-08-31 7:08 ` Konrad Dybcio
2026-08-31 17:28 ` Mukesh Ojha
2026-08-31 15:56 ` Bjorn Andersson
2026-08-31 19:16 ` Mukesh Ojha
2026-09-01 16:28 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apb86I2HGXcUAoG9@baldur \
--to=andersson@kernel.org \
--cc=gokul.krishnakumar@oss.qualcomm.com \
--cc=jingyi.wang@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mukesh.ojha@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®