Re: [PATCH] kthread: remove worker->task self-assignment

[Frederic Weisbecker <frederic@kernel.org>]

Hi,

Le Sat, Aug 29, 2026 at 04:18:48PM +0000, Bradley Morgan a écrit :
> From: Bradley Morgan <brads@mainlining.org>
> 
> All kthread worker users now create their workers with
> kthread_create_worker*(), which sets worker->task before the worker
> starts. The self-assignment in kthread_worker_fn() is dead code now.

How could it be created before?

> 
> Remove it.
> 
> Signed-off-by: Bradley Morgan <brads@mainlining.org>
> ---
>  kernel/kthread.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/kernel/kthread.c b/kernel/kthread.c
> index 63beb59b7a3d..18bc702e8d2d 100644
> --- a/kernel/kthread.c
> +++ b/kernel/kthread.c
> @@ -987,13 +987,6 @@ int kthread_worker_fn(void *worker_ptr)
>  	struct kthread_worker *worker = worker_ptr;
>  	struct kthread_work *work;
>  
> -	/*
> -	 * FIXME: Update the check and remove the assignment when all kthread
> -	 * worker users are created using kthread_create_worker*() functions.
> -	 */
> -	WARN_ON(worker->task && worker->task != current);

Should we keep a WARN_ON(worker->task != current) here?

Thanks.

> -	worker->task = current;
> -
>  	if (worker->flags & KTW_FREEZABLE)
>  		set_freezable();
>  
> -- 
> 2.47.3

-- 
Frederic Weisbecker
SUSE Labs