From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Paul Durrant <paul@xen.org>, David Woodhouse <dwmw@amazon.co.uk>,
Dongli Zhang <dongli.zhang@oracle.com>
Subject: Re: [PATCH v10 21/21] KVM: x86: Use kernel timekeeping snapshot to get walltime+TSC
Date: Tue, 1 Sep 2026 12:17:12 -0700 [thread overview]
Message-ID: <apckuCeNCfLoYe9R@google.com> (raw)
In-Reply-To: <20260826213303.914988-22-seanjc@google.com>
On Wed, Aug 26, 2026, Sean Christopherson wrote:
> Replace the KVM-private vgettsc()+/do_do_realtime() timekeeping
> reimplementation with calls to the recently crafted, generic
> ktime_get_snapshot_id() interface. As noted previously, the snapshot
> provides both the system time and the raw_cycles (TSC), atomically paired
> using a sequence counter.
>
> With great pleasure, delete the now unused read_tsc() and vgettsc()
>
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
> [sean: separate from other conversions, express joy at vgettsc()'s demise]
> Signed-off-by: Sean Christopherson <seanjc@google.com>
Note to self, this needs to be fixed up so that David is the Author. I'll check
the other patches too, I suspect I forgot to specify --author when splitting the
original patch into 3.
next prev parent reply other threads:[~2026-09-01 19:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 21:32 [PATCH v10 00/21] KVM: x86: Cleaning up the KVM clock mess, part 1 Sean Christopherson
2026-08-26 21:32 ` [PATCH v10 01/21] KVM: x86: Update "last guest TSC" snapshot prior to enabling IRQs/preemption Sean Christopherson
2026-08-26 21:32 ` [PATCH v10 02/21] KVM: x86: Improve accuracy of KVM clock when TSC scaling is in force Sean Christopherson
2026-08-26 21:32 ` [PATCH v10 03/21] KVM: x86: Explicitly disable TSC scaling without CONSTANT_TSC Sean Christopherson
2026-08-26 21:32 ` [PATCH v10 04/21] KVM: x86: Activate master clock immediately on vCPU creation Sean Christopherson
2026-08-26 21:32 ` [PATCH v10 05/21] KVM: x86: Compute kvmclock base without pvclock_gtod_data Sean Christopherson
2026-08-26 21:32 ` [PATCH v10 06/21] KVM: x86: Avoid NTP frequency skew for KVM clock on 32-bit host Sean Christopherson
2026-08-26 21:32 ` [PATCH v10 07/21] KVM: x86: Drop unnecessary CPU pinning when computing/getting kvmclock Sean Christopherson
2026-08-26 21:32 ` [PATCH v10 08/21] KVM: x86: Move "no master clock" fallback from __get_kvmclock() to get_kvmclock() Sean Christopherson
2026-08-26 21:32 ` [PATCH v10 09/21] KVM: x86: Wrap all of __get_kvmclock_master_clock() with CONFIG_X86_64=y Sean Christopherson
2026-08-26 21:32 ` [PATCH v10 10/21] KVM: x86: Fall back to non-master-clock if clockread fails in get_kvmclock() Sean Christopherson
2026-08-26 21:32 ` [PATCH v10 11/21] KVM: x86: Fix KVM clock precision in get_kvmclock() with TSC scaling Sean Christopherson
2026-08-26 21:32 ` [PATCH v10 12/21] KVM: x86: Use get_kvmclock() in kvm_get_wall_clock_epoch() Sean Christopherson
2026-08-26 21:32 ` [PATCH v10 13/21] KVM: x86: Fix compute_guest_tsc() to handle negative time deltas Sean Christopherson
2026-08-26 21:32 ` [PATCH v10 14/21] KVM: x86: Disable preemption, not IRQs, when getting TSC+freq pair Sean Christopherson
2026-08-26 21:32 ` [PATCH v10 15/21] KVM: x86: Make master clock logic in guest PV clock updates 64-bit only Sean Christopherson
2026-08-26 21:32 ` [PATCH v10 16/21] KVM: x86: Upscale TSC to "now", not master clock when updating PV clocks Sean Christopherson
2026-08-26 21:32 ` [PATCH v10 17/21] KVM: x86: Simplify and comment kvm_get_time_scale() Sean Christopherson
2026-08-26 21:32 ` [PATCH v10 18/21] KVM: x86: Remove implicit rdtsc() from kvm_compute_l1_tsc_offset() Sean Christopherson
2026-08-26 21:32 ` [PATCH v10 19/21] KVM: x86: Use kernel timekeeping snapshots for getting kvmclock time since boot Sean Christopherson
2026-08-26 21:33 ` [PATCH v10 20/21] KVM: x86: Use kernel timekeeping snapshot for monotonic clock Sean Christopherson
2026-08-26 21:33 ` [PATCH v10 21/21] KVM: x86: Use kernel timekeeping snapshot to get walltime+TSC Sean Christopherson
2026-09-01 19:17 ` Sean Christopherson [this message]
[not found] <20260826214952.129BB1F000E9@smtp.kernel.org>
2026-08-28 22:46 ` David Woodhouse
2026-09-01 19:33 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apckuCeNCfLoYe9R@google.com \
--to=seanjc@google.com \
--cc=dongli.zhang@oracle.com \
--cc=dwmw@amazon.co.uk \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®