mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Andrea Righi <arighi@nvidia.com>
Cc: Wanwu Li <liwanwu@kylinos.cn>, David Vernet <void@manifault.com>,
	Changwoo Min <changwoo@igalia.com>,
	sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched_ext: Reject NMI calls to lock-taking kfuncs
Date: Tue, 1 Sep 2026 10:13:27 -1000	[thread overview]
Message-ID: <apcx5yUysXEuEYAf@slm.duckdns.org> (raw)
In-Reply-To: <apcsyS2j-N8j5-BN@gpd4>

Hello,

On Tue, Sep 01, 2026 at 09:51:37PM +0200, Andrea Righi wrote:
> AFAICS, the lock-taking and state-changing kfuncs do not have a meaningful use
> from BPF_PROG_TYPE_TRACING. We could move them out of scx_kfunc_ids_any into a
> separate set registered only for BPF_PROG_TYPE_STRUCT_OPS. The read-only kfuncs
> could remain available to tracing programs.
> 
> This should include:
>  - scx_bpf_kick_cpu() / scx_bpf_kick_cid()
>  - scx_bpf_destroy_dsq()
>  - scx_bpf_dsq_reenq() / scx_bpf_reenqueue_local___v2()
>  - bpf_iter_scx_dsq_{new,next,destroy}()
>  - scx_bpf_cpuperf_set() / scx_bpf_cidperf_set()
>  - scx_bpf_sub_grant() / scx_bpf_sub_revoke()
>  (... maybe others that I'm missing ...)

Hmm... but it *is* useful to be able to e.g. kick a CPU or trigger reenq
from a trace event, no?

Thanks.

-- 
tejun

  reply	other threads:[~2026-09-01 20:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01  9:56 Wanwu Li
2026-09-01 19:51 ` Andrea Righi
2026-09-01 20:13   ` Tejun Heo [this message]
2026-09-01 20:28     ` Andrea Righi
2026-09-01 21:16 ` Tejun Heo
2026-09-02  2:31   ` [PATCH v2] " Wanwu Li
2026-09-02  6:44     ` Tejun Heo
2026-09-02  9:36       ` [PATCH v3] " Wanwu Li
2026-09-02 23:05         ` Tejun Heo
2026-09-03  1:46           ` liwanwu
2026-09-02 13:48       ` [PATCH v2] " liwanwu
2026-09-02 21:51         ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apcx5yUysXEuEYAf@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=arighi@nvidia.com \
    --cc=changwoo@igalia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liwanwu@kylinos.cn \
    --cc=sched-ext@lists.linux.dev \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®