From: Phillip Potter <phil@philpotter.co.uk>
To: Manuel Ebner <manuelebnerli@mailbox.org>
Cc: Phillip Potter <phil@philpotter.co.uk>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Manuel Ebner <manuelebner@mailbox.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cdrom: fix brackets
Date: Wed, 2 Sep 2026 19:30:36 +0100 [thread overview]
Message-ID: <aphrTLxLO5F2adsR@equinox> (raw)
In-Reply-To: <d254a0d6-83e3-4f67-8fbd-87b5ad3b2849@infradead.org>
On Wed, Sep 02, 2026 at 09:46:58AM -0700, Randy Dunlap wrote:
>
>
> On 9/2/26 5:54 AM, Manuel Ebner wrote:
> > From: Manuel Ebner <manuelebner@mailbox.org>
> >
> > Fix missing ')' and add '()' to function.
> >
> > Fixes: e327cfcb2542 ("docs: cdrom-standard.tex: convert from LaTeX to ReST")
> > Signed-off-by: Manuel Ebner <manuelebner@mailbox.org>
>
> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
> Tested-by: Randy Dunlap <rdunlap@infradead.org>
> Thanks.
>
> > ---
> > Documentation/cdrom/cdrom-standard.rst | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/cdrom/cdrom-standard.rst b/Documentation/cdrom/cdrom-standard.rst
> > index b97a4e9b9bd3..b6dde1d1eaaa 100644
> > --- a/Documentation/cdrom/cdrom-standard.rst
> > +++ b/Documentation/cdrom/cdrom-standard.rst
> > @@ -1014,7 +1014,7 @@ How to update your driver
> > just calls to the routines you adapted in the previous step.
> > - You may remove all remaining memory checking code in the
> > *audio_ioctl()* function that deals with audio commands (these are
> > - listed in the second part of cdrom_ioctl_. There is no
> > + listed in the second part of cdrom_ioctl()). There is no
> > need for memory allocation either, so most *case*s in the *switch*
> > statement look similar to::
> >
>
> --
> ~Randy
Hi Manuel,
I concur with Randy, looks good to me. Will send along for inclusion.
Thanks for the patch.
Regards,
Phil
prev parent reply other threads:[~2026-09-02 18:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 12:54 Manuel Ebner
2026-09-02 16:46 ` Randy Dunlap
2026-09-02 18:30 ` Phillip Potter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aphrTLxLO5F2adsR@equinox \
--to=phil@philpotter.co.uk \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manuelebner@mailbox.org \
--cc=manuelebnerli@mailbox.org \
--cc=mchehab+samsung@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®