From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45F333F58E9 for ; Thu, 3 Sep 2026 06:36:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788417386; cv=none; b=RaavG+HuH5QbjJD0TmwiuYeeUeOwJPTse9iG88QE/vLkZegnGUwhpFKWLWo1Znp+b9BagLcY6gVzZeImQx9pwF8/9DKbZ0YgOonTL7awotdddywhtYxCvHMtoHe0fuD5HfMFc9XdPonz3cKAufOLZcVJr9/biQMxbEmWKWo6MXQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788417386; c=relaxed/simple; bh=FfwkxEfilE86BNfAlLpk7Wh2Jy69VGToG2IRN4Qqqqw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eojp6r7YvEuNY2Oh/ChGsq4AiUzZ/HBsnGu9AJuY1sM237dl1hdpvU42r10zr35Tck9YfS+AdkzatxlQ0v3hjhvAp/lLjqZ4684eo26JczsIVZggyjwkeZMrpcWm6EwcbhAVhJwttdWon+HUnmcT8ITMnym10HFNokGVQ1hQtOI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=enNaZKAL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hMUtYN7w; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="enNaZKAL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hMUtYN7w" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6835lOh73113986 for ; Thu, 3 Sep 2026 06:36:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=6vG8IUyMgWi+NM+7asSaQVtS tMEa/DOfKPbDlIqaadE=; b=enNaZKALYY7Lcg2+BRZ+Wvyk+B4pcvlzWMrbcyib lExhVZCU4VRs1ZIRTaTp10fJ3BdsGzciWvB5lE1i2e9UjLiFd4f07sH6fFmRSfcU epkdfARqe26b/VCtW+ZhAOcjEFOGnzPODymRUIxhJf7v7LKIfUJWVvbqwHYjKC81 r/cms3K+WFZdch8xMsyf1HmqmDN+a2MQ3bwhqvWZAJkq6bByZnQM26xclsH1poAj zyzIwYHPaPw4nmEHZ7SMvKveQx9Wrc95JL1tjxZB0VyJGeJnM5H7naTVaLKctBYf mTvhhuRYKpJ3Pbjdu2e+MseRFnxd57U7ztjlQooI1CJDzA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gf0gjrpu8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 03 Sep 2026 06:36:21 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2d02df2bf09so18932045ad.0 for ; Wed, 02 Sep 2026 23:36:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788417381; x=1789022181; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=6vG8IUyMgWi+NM+7asSaQVtStMEa/DOfKPbDlIqaadE=; b=hMUtYN7wagtSQcUnCIQ8Dqo2KR8OJ2ahs2dl3qQRbI1BoQRp2bFy/8xBxCltZbgo5D JuOGUAqw7ehCZGNtpc22sZI7WQ8xLgod21AWxzrkL99DmdRqsblhM4XVUEwm9wxQR1Vd ueR8WhysPzRWdoLotRXHlUhRs+rZlQZ99248dg9iQ2exquNxd5dmPYMYE31A/ERbMOdQ Ff2H6A6iG+E0TGqsYX7eOr2a0YONYezZIfyGBJF5sRKqjCdQIqI9jiaquEGdPCHM/It1 qDDcMic0XDX/pJMSauOyXl7dI1M4PRkNE+8jY6GQXiAOyi98SVcTwzNfsVOaac+cFmOd a01w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788417381; x=1789022181; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6vG8IUyMgWi+NM+7asSaQVtStMEa/DOfKPbDlIqaadE=; b=L7hl0pkeOXpxlRHij6W5kTUElP37cJ3h78jZnyZMIc0J5723XdYQpC8xgxhLAmU0bf 2BHIRWkuzcVjZ9ncsf0y+1dZccqcE2t29QV4uBO2mP7Zs5FPMa4UedkhTCSxCYJyoxeu gITsFooRxJ475TyulbsodSAnf29WZr8bAZjwPxp+turb4mFTZBdWuTgaLTdl+/aE1OIe llQalYD7oIdAuPJz17hjI4l+Ww8+5jmAirC9koBhQniWjxpMenScDxd3jbam+sjX2jAy fGeiRg6SAcIU+f6Amz4cFXOx+fawzfqY194+c3cjHESrLpZ1LpwsX5kamnnfAEj9u0HR 8jwA== X-Forwarded-Encrypted: i=1; AKwUvBw9gpuhSmJ0CqRK8GJipl49GL0aLOlwe9oHzHdYmVlQgomMAnMxCGXYZHJSPa1aIweRZig7iFzhl/0TSLw=@vger.kernel.org X-Gm-Message-State: AFuF++lpQ6W63kmO6s5Cawzo1wqCtdPwbu2mzZQpAU7ktVKT/U03Ltwp eDNKMyPMsTrf6JxuoVGBY90QC/29C59SLaUsmGbi5RpR/w4x0UdbiIomthTDoS2VRsomL3x4oHu LdZq/2Zotmzlg6YVszIhr0QyaohE+4RRO9nJEQopWsBx0fmJvcxCuqZigwy3+XRE2D0c= X-Gm-Gg: AYBFou0wSvwlcrbEG/PFHEfQ9AvALoJqPuonu+5XvYsK7kB+Uw+xjRzcsm99iDEjleD 7Jfq+lWrq8/rc01SAvlG1jqiqtdWlW2j7juM8wfIYV1i6ZXs0ipUdICJw6Nx7NqmIl0k/DU8ATR S/gHWjAPNo7K2Xdfi0NUf4ZG70cxNKOPKpJ7xbOrFCNRC15ZNP840YAl+MNovtvOpKFHSL/8p6b 2rd8fFD//SbgycWaUmcF1T7+4PQncMmkISdOhGigFaubKjmfG+hbYO/gxxKdUU/o1FD1cncIY9B b7NYJTaLqU/yytMCpkciItf44+c8Z+UKuOzvktUzo6LZkJgjhIk2vjfee4DHDs/or6IneRt5b8z 2GMIEIdGUI2LN+n1gsl/WHACJRgq9aKhCLmn8KUmByHM= X-Received: by 2002:a17:90b:164d:b0:398:c16e:69d3 with SMTP id 98e67ed59e1d1-39aedeb9aecmr15404623a91.1.1788417380680; Wed, 02 Sep 2026 23:36:20 -0700 (PDT) X-Received: by 2002:a17:90b:164d:b0:398:c16e:69d3 with SMTP id 98e67ed59e1d1-39aedeb9aecmr15404520a91.1.1788417380155; Wed, 02 Sep 2026 23:36:20 -0700 (PDT) Received: from QCOM-aGQu4IUr3Y (i-global052.qualcomm.com. [199.106.103.52]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3325592ebb3sm3645854eec.14.2026.09.02.23.36.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 23:36:19 -0700 (PDT) Date: Thu, 3 Sep 2026 14:36:14 +0800 From: Shawn Guo To: Konrad Dybcio Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , Dhruvin Rajpura , Anandu Krishnan E , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] arm64: dts: qcom: nord: Add PMAU0102 and PMM8650AU PMIC support Message-ID: References: <20260831032103.341633-1-shengchao.guo@oss.qualcomm.com> <20260831032103.341633-5-shengchao.guo@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAzMDA1NyBTYWx0ZWRfX1H1tH6GWajLP rORta8FFAWEvmgTEpczw8PjDlo6pbuSK+RsKjifMToAndz/b5rEAEZANjwAOHPBuEq9wJ2sH0S/ 3i9HL7Of0+2HfJVQLKxarEpf8T87qrvz3kHkcu+scN3weS1AIZKhj5g3oNpQ+4GUr04niCOknc3 9USOMa7g4CcuqAAaJ7ONc0UUFWvufODTppIMOJ3dgQ7b3AvvqlA96BvyatDpS73mpsWeoxJV505 dppfSGq40JorCB4v5Z+NqKtu6phAdE+Omx7GhmyyDtIK4o2IzRyjmrt+ahyifTGslvjzyb9G6rj 271Xp7h91r1q8w7D8CWKbiuCyZUDSULGMl7WiIfJDfnOqhCh+nEezZ2L+BSf3q85ElbINgjdkWU Q7CMT744xhHJOpGGdkHZYu1QPQMvS91yvSk0T90NIZ1ky6Jte7zw30PaE7T9Z/81MoCnuhycy1u jbCwBh1XeDnh67hovDg== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAzMDA1NyBTYWx0ZWRfXyV5tvemV/hOC j7eACE+ubz3onNLRAznOSjmdANECdjeMbGfTVeCQlthBW3xQkjch2S3bt2meS5tL8nE0BkZMj4R BZ19F+H7xYj057kZDOoe+tdbbOOC9uY= X-Proofpoint-GUID: R1gp0wA5mLy69kPyn5YAHwLEwmIZwPU1 X-Proofpoint-ORIG-GUID: R1gp0wA5mLy69kPyn5YAHwLEwmIZwPU1 X-Authority-Analysis: v=2.4 cv=LZ4MLDfi c=1 sm=1 tr=0 ts=6a991565 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=b9+bayejhc3NMeqCNyeLQQ==:17 a=kj9zAlcOel0A:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=KicveIkL9BD13D6TIKoA:9 a=CjuIK1q_8ugA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-03_02,2026-09-02_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609030057 On Wed, Sep 02, 2026 at 04:17:26PM +0200, Konrad Dybcio wrote: > On 8/31/26 5:21 AM, Shawn Guo wrote: > > From: Dhruvin Rajpura > > > > The Nord platform is supplied by two families of PMICs on the SPMI bus: > > eight PMAU0102 devices on USIDs 4 to 11, and one PMM8650AU on USID 0. > > Add one dtsi per PMIC type, following the established one-file-per-PMIC > > convention, and include both of them from nord-rrd.dts. > > > > The eight PMAU0102 instances are labelled pmau0102_e through pmau0102_l > > after their board designators. Each one provides a GPIO controller, an > > ADC, and an MBG (Master Bandgap) temperature monitor that reads its die > > temperature through a DIE_TEMP ADC channel. The monitors use the > > qcom,pmau0102-mbg-tm compatible with qcom,pm8775-mbg-tm as fallback, and > > each is hooked up to a thermal zone. > > > > PMM8650AU is the same die as PMM8654AU, so pmm8650au_a reuses the > > existing qcom,pmm8654au and qcom,pmm8654au-gpio compatibles while the > > file is named after the part actually populated on the board. It provides > > PON with a power key, an RTC, and a GPIO controller. The resin > > is described but left disabled, for boards that wire it up to enable. > > > > Signed-off-by: Dhruvin Rajpura > > Signed-off-by: Shawn Guo > > --- > > [...] > > > + pmm8650au_a_pon: pon@1200 { > > + compatible = "qcom,pmk8350-pon"; > > I think this may fall into the same bucket > > https://lore.kernel.org/all/20260724-b4-add_pwrkey_and_resin-v6-1-41acc214d93a@oss.qualcomm.com/ Ah, thanks for the pointer! I missed that. Since PMM8650AU is the same die as PMM8654AU, I would reuse pmm8654au compatibles, e.g. compatible = "qcom,pmm8654au-pon", "qcom,pmk8350-pon"; Shawn