From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1222C40926C for ; Thu, 3 Sep 2026 09:51:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788429096; cv=none; b=tohk1eilq/J+LynxCON0cT4fpQ/tLsNSQR0kY3ci7PbMKpSOyOuCH190j/Q6XjzglTSITM8Gp3nXJNBqKL4w1se9pvb7Fakq8OCyMcnIClyhhx704TvuUlezlbEqmJNWYAesREaXIlMfBIfr140nzbl3l+gkHY57LU1qdKS5iNM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788429096; c=relaxed/simple; bh=h+bnaJxqhKvgXxpOW81ZgyakGc+5wcEhmw3hz5YU2JQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k6Xvzm9ew0dSoCwU/nUrno3iQ+ZpuPyfgR2V3e9KlQmiAQwlqB7c6se51wIFf6R+Qz+aZl8DdwviS83QJl6ehO/nRFiARfg3/fMzKiC0lRgaasjkEZIrD8Q/auqBlZVeGrYtZrrMlYBloAwsgxk9riE3BKu0SY9s2vcI9PHnhvk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=G5huG6F6; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G5huG6F6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E0891F000E9; Thu, 3 Sep 2026 09:51:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788429094; bh=K1d1X7CTU5oXDtnyZDKqo+yDP2x2AA29X2d+7rWBvAU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=G5huG6F6h5AzuCaARyL9jE5Ryhonmr3ez7aRWq01/M7HOSwftTFBmtEtULML3mxH0 J55V0cARnQg0RA8j5m3C9wDLoRwjAMIJoDkqzdTrZ7TjTcta5VfB8/TMeH7oRVICEA RbTVNW+eAo7aZz5hX/BtHYmhjOOQLLMdw+lVFdRNRdKcWHkcGloC41ENJzUfmj7Oef 6q3+XPh+C0bJP3TYvgsTxnvDGGZfeYMMlQIUTpii9IBp7Mq86AHGSvTENzPFViplR6 hPcCjdFIhWuUxgKy0Dofg7bAiRtS0S/k0sRoS3zARU2EdJHDCCtox0IFku8MUVK39l 9n3pskS6djpfA== Date: Thu, 3 Sep 2026 11:51:31 +0200 From: Maxime Ripard To: Luca Ceresoli Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Jessica Zhang , Linus Walleij , Inki Dae , Jagan Teki , Marek Szyprowski , Albert Esteve , Anusha Srivatsa , Dmitry Baryshkov , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC v2 01/19] drm: of: move drm_of_find_panel_or_bridge() from drm_of.c to bridge/panel.c Message-ID: References: <20260903-drm-bridge-every-panel-v2-0-2ab8ee24538e@bootlin.com> <20260903-drm-bridge-every-panel-v2-1-2ab8ee24538e@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="gkp53kusgh3zbgdw" Content-Disposition: inline In-Reply-To: <20260903-drm-bridge-every-panel-v2-1-2ab8ee24538e@bootlin.com> --gkp53kusgh3zbgdw Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH RFC v2 01/19] drm: of: move drm_of_find_panel_or_bridge() from drm_of.c to bridge/panel.c MIME-Version: 1.0 Hi, On Thu, Sep 03, 2026 at 10:11:04AM +0200, Luca Ceresoli wrote: > We want to move drm_panel.o from the main drm module to a new drm_panel > module, but there is one function in the drm module that calls into > drm_panel.c code: >=20 > drm_of_find_panel_or_bridge() (in drm_of.c, drm module) > -> calls of_drm_find_panel (in drm_panel.c, would-be the new drm_pan= el module) >=20 > Avoid this issue by moving drm_of_find_panel_or_bridge() to bridge/panel.c > (which is currently in the drm_kms_helper module). >=20 > As a result drm_kms_helper will depend on the new drm_panel module, which > is fine because there is no dependency of drm_panel on drm_kms_helper. >=20 > After this change, all drivers using drm_of_find_panel_or_bridge() will > have to select DRM_PANEL_BRIDGE (and DRM_PANEL, recursively). Add that for > affected drivers. While there, also add DRM_PANEL on drivers selecting > DRM_PANEL_BRIDGE. >=20 > No functional changes, just moving code around. >=20 > [AI used to add 'select DRM_PANEL[_BRIDGE]' for affected drivers] > Assisted-by: opencode:deepseek-v4-flash-0731 > Signed-off-by: Luca Ceresoli In the previous discussion, I suggested to move it to drm_panel.c because it's not really related to the panel_bridge stuff, like, at all. And both drm_panel.c and drm_bridge.c are in drm.ko at this point so you shouldn't have any issue there. Also, you don't have to select DRM_PANEL_BRIDGE anymore. Maxime --gkp53kusgh3zbgdw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCaplDIQAKCRAnX84Zoj2+ dk6vAXwO9vOKeJZow147hUdFsI/s8UxS5hxKETOiyZPWrbu+faDqiS5MdVQxCber PerzaxcBfjoc29Dn4cN2dHrv1BvfGdeLbaagCNC2F7PI/Iq0C+B5uLN1H2pXvtNa rhDNHq+V4w== =AlCQ -----END PGP SIGNATURE----- --gkp53kusgh3zbgdw--