From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A809D4EBAD2 for ; Thu, 3 Sep 2026 16:22:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788452564; cv=none; b=ji/7lwBtKA20y32B/znF+4sd09U/eaKYU94LSNR8azV053N59s7yoFDC+frH3TsPxdy+26+zOpA7N9Nu15XvQqK4DnJ7qIWRf7+nN63K2NRiFpo/DPOiYLcvjP8a0tzfuYeL1e7TABprsb67/RbBJ543POEjE32LEeLgpPo94js= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788452564; c=relaxed/simple; bh=3XggkU1o03ysU4nezevLZDbtm2BbkFAs7cgJg9nFcPI=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=X6vTXFE3TM+jynSSsj5pFjs2z2p7lw57FGkU8I3zzW0TlbuC648yDXcDEnu8jt9VTj1ek1tA9QrY1F7XgQKQWDgjYKZqPMljoX/JTXy65FAUJKWbp7iEFRNAlVTp2htOSuMPLiVu4F57KnURvcTG+f0GVXsQxEPHAgh+4zbbtrE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=AcfzbWys; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="AcfzbWys" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4998b5a63e2so670905e9.1 for ; Thu, 03 Sep 2026 09:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788452561; x=1789057361; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:date:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=NbQ9UdREJ/WWisdiQ1Got7ahhLovVEcdSUeHC5P/jK8=; b=AcfzbWyseWTKtzilxUnHmGGh2WdrbK25F6/b9aR6WF39v/5s7j+fkBrG91wSoiQ2vs NUcAosTNkOQKpbMt6+jd8ZUDZKAeco8eyu6wYmVktox1CPtnSMCu8HEF6TZwQL0CWiKn i9z8W5WUXDzoO9e7VU5nEkKljlN4IUK5OFwzXgMEFp74sSzGzqjOdmyVD+/HtfINzz+O gTCfS/QxZgNdnN2+rOXGVxCt1EwZ8p94Pc34VFnIyzvmyL2Jj+AItllwrKVUX/VH58Vd HqwISUxnaGTgSf4rRPZoARL/9DdaQRm/TwCRQnIthrtIqRqwuEL+bWd19agFf/xU/Q3h +7GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788452561; x=1789057361; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=NbQ9UdREJ/WWisdiQ1Got7ahhLovVEcdSUeHC5P/jK8=; b=Y0Xq0cFvzHwPq0m0CS4fNVl7IGtUXN+KCg2jR1efHs8v2Phm4IwUXsH/tFBt5zpkzB 9NqqSSSqM89y1oqJz7YaT2zuV9IlrkDOqR4IhWNxaKOWaFLS4KBIqxu0D5XiFtYLCPzG Jitau4J647w5LhURGd04ybkqwvhXWZtLX6+swpjDWmFIk9pQkJDbVvlafdHtnDduWjG9 8BIUpTqf4tWuQdkvJqhLJe6I7l/a6ZavCTUEl/Jh3b82+NJdr4/Rv7eGixU0oC78nt8g zho3uKJDTq+wnlKEZgtXNt4io7Pc72T9CLMcjg3JHeyrCSpF0LcmJG3+3UsUFqQDXHLU 8PoQ== X-Forwarded-Encrypted: i=1; AKwUvBygBjLlhK4M2agnO+j5iq6lgr88lUKFQTx9ienG8FEW9ql8llJi0HZ6NRgcQ9KqRiuBPEnQvNztuqxaM7g=@vger.kernel.org X-Gm-Message-State: AFuF++n/VPOBZtKj0sqICS5rQHrrcAKuozTx2uJu4CMR5Fu3MlLHG2G5 TI7vEad3jCSrMkdYtFDEFMTLqDDxIy5ksmL+YxitGTZNHP2vECrRxx9IhdreoDSM8nU= X-Gm-Gg: AYBFou2G+7lDXwSiUSiyH17MQlaxkXK/TcsPdAOuwSul7+OfncqRjEW/osqAosyvz75 6mrZ/PzWnEMiWWTZQjBJSlZEPAvpHNjAc/WghMLCQ4rFMzqk/DpcTIdP+2q66cCQ++eoDfCYsbV d5pfcRRA7bD544fQexyJ43OMFndbHkbGz2OltdHxO8S7CFMZ1gupgn1h31PnCDuwUkD7FQJ9gm9 QwuMbZmK7gyx42q4wRO0BUNeUoTvkBiPSR88IsVnhf8ak8Q/lQESIFg0pJPt9BLAbjf9ijVsh/e QZ+TxmcD2RvtaCY8TNQkkpxvmfTMwvLC0Aa+7QV4l4icxul1mwwgBD4RiwLa4Adb922658oeCI+ DmR2ysF40BtFfOAqJciTRh47h1rJrdklvCFZ2AxqY/evgwQMI8GhYqFzYwKgU1DcR4xw/Yoh0eg b6dr+PWh38PUKwOJV2duPt1fatHRtrYLzwe9n8ERoA9syQxxu+SYQv5u8ftPy9sYAlvnHr X-Received: by 2002:a05:600c:5309:b0:499:79b9:e220 with SMTP id 5b1f17b1804b1-49cf5bd3418mr25301905e9.10.1788452560717; Thu, 03 Sep 2026 09:22:40 -0700 (PDT) Received: from localhost ([194.183.24.73]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce5563c6csm110440525e9.4.2026.09.03.09.22.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 09:22:40 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Thu, 3 Sep 2026 18:26:19 +0200 To: Gregor Herburger Cc: Andrea della Porta , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] arm64: dts: broadcom: bcm2712-rpi-5-b: add spi0 interface Message-ID: References: <20260811-bcm2712-spi-v1-0-4c1708d354bb@linutronix.de> <20260811-bcm2712-spi-v1-2-4c1708d354bb@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260811-bcm2712-spi-v1-2-4c1708d354bb@linutronix.de> Hi Gregor, On 18:04 Tue 11 Aug , Gregor Herburger wrote: > The Raspberry Pi 5 routes the spi0 of the rp1 chip to the pin header. > Add the rp1_spi0 node and its pinctrl node to the devicetree to enable > the spi interface. > > Signed-off-by: Gregor Herburger > --- > arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > index 0fc57e72632ed..81aec81c5ce12 100644 > --- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > @@ -69,6 +69,14 @@ usb_vbus_default_state: usb-vbus-default-state { > groups = "vbus1"; > }; > > + rp1_spi0_default_state: rp1-spi0-default-state { > + function = "spi0"; > + groups = "spi0"; > + bias-disable; > + drive-strength = <12>; > + slew-rate = <1>; > + }; > + > rp1_i2c4_default_state: rp1-i2c4-default-state { > function = "i2c4"; > groups = "i2c4_2"; > @@ -94,6 +102,14 @@ &rp1_i2c6 { > pinctrl-names = "default"; > }; > > +&rp1_spi0 { > + pinctrl-0 = <&rp1_spi0_default_state>; Is there any reason to avoid defining the CS pins as pulled-up gpios in the rp1_gpio node and then referencing it in pinctrl-0? Something like thie following: rp1_spi0_cs_default_state: rp1-spi0-cs-default-state { function = "gpio"; pins = "gpio7", "gpio8"; bias-pull-up; }; &rp1_spi0 { ... pinctrl-0 = <&rp1_spi0_default_state &rp1_spi0_cs_default_state>; ... }; Many thanks, Andrea > + pinctrl-names = "default"; > + > + num-cs = <2>; > + cs-gpios = <&rp1_gpio 8 GPIO_ACTIVE_LOW &rp1_gpio 7 GPIO_ACTIVE_LOW>; > +}; > + > &rp1_usb0 { > pinctrl-0 = <&usb_vbus_default_state>; > pinctrl-names = "default"; > > -- > 2.47.3 >