From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21F9336A37F for ; Thu, 3 Sep 2026 22:33:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788474798; cv=none; b=EHpYYIFBWFj8BF7n4hy3a+zkspGlYDTYo+69WaFQx7OThLscX1Xzpu2dMLuYNiprea+irqzR6EamF24iydJgfC+Ht/Ei1KlMml7aXKr1ZEDaqRgUUGhabT8Bpkr+FVkBgTYNbk7sLMVsEH46G0APv8P4/BitUkrw+RELN6LomwM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788474798; c=relaxed/simple; bh=4c3nfHzx6sq9eUFKnQag6UKfPOIkWmaO1ykpU7H4aTg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EkeXXh9iIjPfI3HUEl+GUr9a327R3FqxtHZc2liSj212zKZeOS52m78lam3SyBiz9XQQH5wHIEoxBbxeXSSj8Xlo/PKHy16TB6nc/nKjC5/YSGom8FEC4q2FTvDss3//h8FLUwtLSLBV1FI0CiXBFxCy4X6qqrwamogrAtMm5Ak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FsHvcRhC; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FsHvcRhC" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-c9b373d5af0so377746a12.2 for ; Thu, 03 Sep 2026 15:33:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788474796; x=1789079596; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=fsb6fC2BuVNqBfvyOr4NyKSsD45FGtfpTAVkgi/kym4=; b=FsHvcRhCU6TMl+UeBx+bnI8iEyrnBLJwSmw9MOiZMDL29XawM5rsCzPt5uvYnfeCRd VxMzbh+f/Q2YjF3tjclhwcCrez5bxpwNi+ODuX9ExQ9kfWQAjhj0CKHLgW76roI2rDKl +Bnot7RxzAuGXtuPcLje3DjlYwFhqyU21vWhmqRI3S/U/IXncIUAKQ0oO0cUeBL+qiYq WEOHWLinVimGVZhqVOZb8E/SC1kbn7fXkpq3USuc+lG57dj32GGkVg24WpiAfAeBI069 PnGalnKHaQyjpmO3Y/tlrVGVWV3mWWZI36WWV2wZnjlunR2MeRT0LiWqu1ky/vfizaYL ek7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788474796; x=1789079596; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fsb6fC2BuVNqBfvyOr4NyKSsD45FGtfpTAVkgi/kym4=; b=X3/Ed384dz8hfyDNpiTbe317FGfamRJfqXiij0uetrOY9t5SuDUpRL1u96pfmueliz qI2kHsKt00CljbS4Knn1lpYybdEXMhgfglMB8CG0cDi0XgqCuDaSR/Ebi9OQ8u860IXy EHsxCmPk9IGQa8aHjot4OzMW6g53KWs5OWQUxARqGXFS7PGvuX3tyw513xeaJLgOgIbi aZKb/Cd6PPxFporePLtBKgJ0jFU8VWRyp/MesbHs9JImOI8mLOscY5CVD/JQQvUym98X z+uBzjOnT2ZVNoQfCOv7nkfzB/SweGUr1TfBcJ8J9zmVnRHpdfoxVtrvYAYdlRcw58Ij jR4g== X-Forwarded-Encrypted: i=1; AKwUvBxJg8GPQ//wQGj1xkP8d5gpPGGC9mllE/OYRoekCNUUyZJm+/tt/6Lpiwe3VZ7/09dpC5IxT7lz1XXeX34=@vger.kernel.org X-Gm-Message-State: AFuF++l9DQ/qKD+oNeJ7Tk+76sD7sS0lqDi7o5na4vnrgZpEdhDMzvHI /YVkYlF8Y7vzfQVIYWBhNz0KiIuqbOM4aazb1GpxxqFrPzsPfNoxb3Fv X-Gm-Gg: AYBFou3fefMWq0C3GGDGD/xdu5l+dPN0yp5yEuQkgiJzFT6rOAJk+zK2w9n3hPlEVcX 3YFycUJud8HEVqg5aLhEgJV7pM8avtjYIn+adELts8MzGZCCBZvEznwDNz11X86W9Cn6Ow+wBTH 2nXUI93lW0jL6nKES69SjZ/nxYkTXutQ164Wv3e6ABEh0TQAqWstGzoHcAoIOtJcSjQuMR7td2e A7WdLFlSLb9QXJNxUhTlML/GP9fcDtucO9mszRwlXAENIHV3xr12NJM//cIPtM40G8BRRYMo4Re EnrSxIe1fyRGqeIa+ZPLtGF2gwVOmUGiRtviU8tdjTe5a6VuCSpDByhj94YnLmcFp5CDdwkGi0B 1JljUgKGeQiSIanTXUYo6OgTbcnlGrd90B3uWxW3fSUo4OJuFq9QnloDO9q9O+Ff8yfR0MbLmYW k2zssPPJuKABcISL0XI4Pq41r8SmhlyIN8zV0tuCeDcrDw4QVPy8T+JcxAvGhsk0Bx96z56+xE1 LvgzBwd X-Received: by 2002:a17:90b:268f:b0:398:c3a3:dbd0 with SMTP id 98e67ed59e1d1-39b2612eb96mr2849147a91.8.1788474796180; Thu, 03 Sep 2026 15:33:16 -0700 (PDT) Received: from devvm16600.scu0.facebook.com ([2a03:2880:9ff:73::]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339a534d25sm1797152eec.5.2026.09.03.15.33.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 15:33:15 -0700 (PDT) Date: Thu, 3 Sep 2026 15:33:12 -0700 From: Ziyang Men To: Shakeel Butt Cc: kernel-team@meta.com, Jens Axboe , Tejun Heo , Josef Bacik , Johannes Weiner , Michal =?iso-8859-1?Q?Koutn=FD?= , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Shuah Khan , Ingo Molnar , Peter Zijlstra , Vincent Guittot , Ben Segall , Dietmar Eggemann , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Roman Gushchin , JP Kobryn , Mykola Lysenko , linux-block@vger.kernel.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/4] cgroup: expose cpu.stat and io.stat to BPF Message-ID: References: <20260820211758.3393984-1-ziyang.meme@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: On Wed, Sep 02, 2026 at 04:10:01PM -0700, Shakeel Butt wrote: >On Mon, Aug 31, 2026 at 03:16:10PM -0700, Ziyang Men wrote: >> Hi Reviewers, >> >> Just want to follow-up on this patch series. Please let me know the possible >> issues and I will fix them. >> > >AI bots have raised real concerns. Please address those and then resubmit. > Hi Shakeel, I have reviewed the AI bots suggestions, and it seems the main issue is to decide whether we want some kfuncs to be NMI safe, e.g., - The `bpf_cgroup_base_stat()`, which calls the `cputime_adjust()` and in turn acquires `raw_spin_lock_irqsave()`. - The `bpf_cgroup_css()` and `bpf_css_release()` to get/put the css. The simply solution is to mark them SLEEPABLE. Hi Eduard, what's your idea about this? Do we want to mark them SLEEPABLE or there are better ways stand in the mid? Thanks, Ziyang