From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-133.mta1.migadu.com [95.215.58.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88EC61DD0EF for ; Fri, 4 Sep 2026 01:40:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788486027; cv=none; b=izAc34Lo34kOcjJ/3ywlBF672Xi8lsyOCE0hnmTOG0me0EsStjVK6bLyIyfmUg7LTyzCANe5HU11VGlVnEmoVArhaHjqqURkHyBnzxIIOiWuHnhtqUY5wnDlHVopEICS0Acj4y7o1tjzhV3XQExDjwvJweW3+PvXXZR6KU09Ywk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788486027; c=relaxed/simple; bh=RWPQjgTjzR14E/Y+lCzq3FRim9vkxK8QSYISw4SHaGE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WVRHxj9CSDNFxPyYvspq6ShO2UY+dmd3LgkEVonT6FF+iGWnaA4LJd8bOOYyI3RBQ7QiRqIW+R7OAbsxBNvsMawiU7TBlL2/NNZlcTMXaP8pAWY+iHvYS/etNfDGnPWASnuZsteaKQBAqxIf4r+eif2uP0bZdhWcDNCELzled6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=tOjYzUkk; arc=none smtp.client-ip=95.215.58.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="tOjYzUkk" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=RWPQjgTjzR14E/Y+lCzq3FRim9vkxK8QSYISw4SHaGE=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1788486023; v=1; x=1789090823; b=tOjYzUkkPKDGxKgOq8SU5T5rBn09VBabaNDAya1wYI8WHWDzYIjuncgjMYDYEo/OZa5PVep6 3HLsEdfhaGz/FwJlTLD9e30/zfICI2lOqEpVFpggXFwDLJkJaQNhyzO5zP/XRPLCij/XHhjIT1g D4rwWbId0gmo4Z/b/k665AWM= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id f3fc155831e2df21; Fri, 04 Sep 2026 01:40:23 +0000 X-Mizu-Trace-ID: f3fc155831e2df21 X-Migadu-Flow: FLOW_OUT Date: Fri, 4 Sep 2026 09:40:15 +0800 From: Hangbin Liu To: Nikolay Aleksandrov Cc: Matthieu Baerts , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Hangbin Liu , Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Daniel Borkmann , Jussi Maki Subject: Re: [PATCH net v2] bonding: fix slave_cnt leak on XDP error paths Message-ID: References: <20260903-bond_slave_cnt-v2-1-02e27304ca36@kylinos.cn> <62271715-fbd6-4047-9b69-b2bda40db056@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Sep 03, 2026 at 02:53:29PM +0300, Nikolay Aleksandrov wrote: > > Thank you for the fix, but it looks like it causes multiple KASAN > > issues, see: > > > > - https://netdev.bots.linux.dev/flakes.html?ld-remote=virt-bonding-dbg > > > > - > > https://netdev.bots.linux.dev/branch_deltas/net-next-2026-09-03--09-00.html > > > > e.g. > > > > > > https://lore.kernel.org/netdev/20260903-bond_slave_cnt-v2-1-02e27304ca36@kylinos.cn/raw > > > > Cheers, > > Matt > > Waaait a second, it is moved after slave arr update, yes that would cause those. > I missed it in the review, in my suggestion I specifically said it must be before > the slave array update because it uses slave_cnt. > > It must be moved up. :) > Ah, I thought all the code between netdev_ops->ndo_bpf and bond_xdp_set_features() are xdp stuff and missed the bond_update_slave_arr() in the middle... I need more careful when go though the code and do testing even with simplest change. Thanks Hangbin