From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sg-2-4.ptr.blmpb.com (sg-2-4.ptr.blmpb.com [71.18.227.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29207332EBB for ; Fri, 4 Sep 2026 04:02:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=71.18.227.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788494575; cv=none; b=EE55iRyWIkYPqjUSwIb8slDnQ21/xQeSen23sQSs145L9OXSRZLOBiIzO5kp70XyJfwwD0QAC7i9n1F2hEw4VmgM9aLxY3RbNT9w6XMAi6KpxSrrXacKPGbZODLYkPW7LbnAYsIHtL8WXyiyUbpCX+qbYIVS+ELkbdxR9rXHnI8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788494575; c=relaxed/simple; bh=l7qxdyLthksN7viBx28FTROc2LOAvoR67yaOuXpXh6c=; h=Message-Id:Content-Type:Cc:Date:References:Subject:Mime-Version: Content-Disposition:To:From:In-Reply-To; b=MQPcGHNXgwjLirIsk+TfM84mMyuJhDzhMe2939k5ZAEi5c+i+j7rg33KnMGHu+NQykpolERlgeD7YzmI5vEw6enslN+VpFNjHW0UZnZicOwLVThvNwNcI2aAAUKPw0TmKD7sK4XD5//UEjI0iBXVIcPqaURP5e0WwsqVda0AmKc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cherr.cc; spf=pass smtp.mailfrom=cherr.cc; dkim=pass (2048-bit key) header.d=cherr.cc header.i=@cherr.cc header.b=jxV2cSsU; arc=none smtp.client-ip=71.18.227.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cherr.cc Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cherr.cc Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cherr.cc header.i=@cherr.cc header.b="jxV2cSsU" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=feishu2604220257; d=cherr.cc; t=1788494566; h=from:subject: mime-version:from:date:message-id:subject:to:cc:reply-to:content-type: mime-version:in-reply-to:message-id; bh=l7qxdyLthksN7viBx28FTROc2LOAvoR67yaOuXpXh6c=; b=jxV2cSsU2wFZ2YfYPkHpwGMs6vAoKiOQCyxS9trvVJkiUf9FKaApBFCuhYJ3AF073+I1tg cZ/jysPbiG+8omxFiqzt0oEuwxzv5DlTkl9gctvwlYi+KtfplFWoETVOO3JuOwPgfc4jHE Bsv9veyip7lpx3E0Kr75Xe7yTE3d6z5hiZqlIH8pWL46oH2HsortJ/IpIl1JKVDz2Rdm+U g+KrgiypLuF3UxyJOU26gIqlO63oZujzEASqpgAsCwOUYqvYU9b1FI7Vt/8EJ3Y55LPrRj Gem2NWHYWuUHM9TLj11hcEQ5NShxOdSIBLMTVvkNU+bxaUJxTtl18Ckg7dGEOg== Message-Id: X-Lms-Return-Path: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: "Shengzhuo Wei" , "Frank Li" , "Shenwei Wang" , "Andrew Lunn" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Richard Cochran" , "Troy Kisky" , "Fugang Duan" , "Lucas Stach" , "Fugang Duan" , "imx@lists.linux.dev" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Date: Fri, 4 Sep 2026 12:02:40 +0800 References: <20260904-fec-ptp-pps-event-uaf-v1-0-9af446be4a11@cherr.cc> <20260904-fec-ptp-pps-event-uaf-v1-1-9af446be4a11@cherr.cc> Subject: Re: [PATCH net 1/2] net: fec: don't leave a stale PTP clock pointer after unregister Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Received: from pve ([111.42.148.74]) by smtp.feishu.cn with ESMTPS; Fri, 04 Sep 2026 12:02:44 +0800 Content-Disposition: inline X-Original-From: Shengzhuo Wei To: "Wei Fang" From: "Shengzhuo Wei" In-Reply-To: On 2026-09-04 03:15, Wei Fang wrote: > Why not move fec_ptp_stop() after unregister_netdev()? Good point. I was focused on making the PHC index lookup safe independently of the teardown ordering and followed the approach used by similar fixes, so I overlooked the simpler solution here. Moving fec_ptp_stop() after unregister_netdev() is cleaner and restores the proper lifetime ordering. I will rework patch 1 accordingly and drop the ptp_clock_index_by_dev() change in v2. Thanks, Shengzhuo