mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Daniel Pereira <danielmaraboo@gmail.com>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	shuah@kernel.org
Subject: Re: [PATCH] lib: hexdump: convert test to KUnit framework
Date: Fri, 4 Sep 2026 09:04:10 +0300	[thread overview]
Message-ID: <appfWm7KaBuk5iL1@ashevche-desk.local> (raw)
In-Reply-To: <20260903213656.57203-1-danielmaraboo@gmail.com>

On Thu, Sep 03, 2026 at 06:36:56PM -0300, Daniel Pereira wrote:
> The old test_hexdump module used the traditional kernel printing
> functions to verify hex dumping capabilities.
> 
> This patch converts the existing test into the modern KUnit framework
> to allow standard automation, faster execution, and better integration
> with Kselftest CI.

...

> +++ b/lib/Kconfig.debug

>  	tristate "KUnit test for cpumask" if !KUNIT_ALL_TESTS
>  	depends on KUNIT
>  	default KUNIT_ALL_TESTS
> +	default KUNIT_ALL_TESTS
>  	help
>  	  Enable to turn on cpumask tests, running at boot or module load time.
>  
> @@ -2289,6 +2290,7 @@ config TEST_LIST_SORT
>  	tristate "Linked list sorting test" if !KUNIT_ALL_TESTS
>  	depends on KUNIT
>  	default KUNIT_ALL_TESTS
> +	default KUNIT_ALL_TESTS
>  	help
>  	  Enable this to turn on 'list_sort()' function test. This test is
>  	  executed only once during system boot (so affects only boot time),
> @@ -2300,6 +2302,7 @@ config TEST_SORT
>  	tristate "Array-based sort test" if !KUNIT_ALL_TESTS
>  	depends on KUNIT
>  	default KUNIT_ALL_TESTS
> +	default KUNIT_ALL_TESTS

>  	  This option enables the self-test function of 'sort()' at boot,
>  	  or at module load time.
> @@ -2329,6 +2332,7 @@ config TEST_MULDIV64
>  config TEST_IOV_ITER
>  	tristate "Test iov_iter operation" if !KUNIT_ALL_TESTS
>  	depends on KUNIT
> +	default KUNIT_ALL_TESTS
>  	depends on MMU
>  	default KUNIT_ALL_TESTS
>  	help
> @@ -2343,6 +2347,7 @@ config KPROBES_SANITY_TEST
>  	depends on DEBUG_KERNEL
>  	depends on KPROBES
>  	depends on KUNIT
> +	default KUNIT_ALL_TESTS
>  	select STACKTRACE if ARCH_CORRECT_STACKTRACE_ON_KRETPROBE
>  	default KUNIT_ALL_TESTS
>  	help

Have you read the patch before sending?

...

Please, take your time and check what you are sending next time.
This version is obviously no-go.

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2026-09-04  6:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03 21:36 Daniel Pereira
2026-09-04  6:04 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=appfWm7KaBuk5iL1@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=danielmaraboo@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®