From: Mark Brown <broonie@kernel.org>
To: Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com>
Cc: Alexander.Deucher@amd.com, alsa-devel@alsa-project.org,
broonie@kernel.org, "Cc:"@sirena.org.uk, "Cc:"@sirena.org.uk,
Dan Carpenter <dan.carpenter@oracle.com>,
djkurtz@google.com, Jaroslav Kysela <perex@perex.cz>,
Liam@sirena.org.uk, Mark Brown <broonie@kernel.org>,
moderated@sirena.org.uk, open list <linux-kernel@vger.kernel.org>,
Takashi@sirena.org.uk
Subject: Applied "ASoC: amd: add ACP3x TDM mode support" to the asoc tree
Date: Tue, 31 Dec 2019 00:30:33 +0000 (GMT) [thread overview]
Message-ID: <applied-1577540460-21438-4-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com> (raw)
In-Reply-To: <1577540460-21438-4-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com>
The patch
ASoC: amd: add ACP3x TDM mode support
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.6
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From a43ea44ddda94bc6c4dbe257fcbdeecde8cb06f1 Mon Sep 17 00:00:00 2001
From: Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com>
Date: Sat, 28 Dec 2019 19:10:57 +0530
Subject: [PATCH] ASoC: amd: add ACP3x TDM mode support
ACP3x I2S (CPU DAI) can act in normal I2S and TDM modes. Added support
for TDM mode. Desired mode can be selected from ASoC machine driver.
Signed-off-by: Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com>
Link: https://lore.kernel.org/r/1577540460-21438-4-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/amd/raven/acp3x-i2s.c | 28 ++++++++++++++++++++++------
sound/soc/amd/raven/acp3x.h | 1 +
2 files changed, 23 insertions(+), 6 deletions(-)
diff --git a/sound/soc/amd/raven/acp3x-i2s.c b/sound/soc/amd/raven/acp3x-i2s.c
index 368e4c855268..d9b287b8396c 100644
--- a/sound/soc/amd/raven/acp3x-i2s.c
+++ b/sound/soc/amd/raven/acp3x-i2s.c
@@ -42,7 +42,7 @@ static int acp3x_i2s_set_tdm_slot(struct snd_soc_dai *cpu_dai,
u32 tx_mask, u32 rx_mask, int slots, int slot_width)
{
struct i2s_dev_data *adata;
- u32 val, reg_val, frmt_val, frm_len;
+ u32 val, reg_val, frmt_reg, frm_len;
u16 slot_len;
adata = snd_soc_dai_get_drvdata(cpu_dai);
@@ -69,15 +69,31 @@ static int acp3x_i2s_set_tdm_slot(struct snd_soc_dai *cpu_dai,
frm_len = FRM_LEN | (slots << 15) | (slot_len << 18);
if (adata->substream_type == SNDRV_PCM_STREAM_PLAYBACK) {
- reg_val = mmACP_BTTDM_ITER;
- frmt_val = mmACP_BTTDM_TXFRMT;
+ switch (adata->i2s_instance) {
+ case I2S_BT_INSTANCE:
+ reg_val = mmACP_BTTDM_ITER;
+ frmt_reg = mmACP_BTTDM_TXFRMT;
+ break;
+ case I2S_SP_INSTANCE:
+ default:
+ reg_val = mmACP_I2STDM_ITER;
+ frmt_reg = mmACP_I2STDM_TXFRMT;
+ }
} else {
- reg_val = mmACP_BTTDM_IRER;
- frmt_val = mmACP_BTTDM_RXFRMT;
+ switch (adata->i2s_instance) {
+ case I2S_BT_INSTANCE:
+ reg_val = mmACP_BTTDM_IRER;
+ frmt_reg = mmACP_BTTDM_RXFRMT;
+ break;
+ case I2S_SP_INSTANCE:
+ default:
+ reg_val = mmACP_I2STDM_IRER;
+ frmt_reg = mmACP_I2STDM_RXFRMT;
+ }
}
val = rv_readl(adata->acp3x_base + reg_val);
rv_writel(val | 0x2, adata->acp3x_base + reg_val);
- rv_writel(frm_len, adata->acp3x_base + frmt_val);
+ rv_writel(frm_len, adata->acp3x_base + frmt_reg);
adata->tdm_fmt = frm_len;
return 0;
}
diff --git a/sound/soc/amd/raven/acp3x.h b/sound/soc/amd/raven/acp3x.h
index a1cdc4e768e2..43213aec7f59 100644
--- a/sound/soc/amd/raven/acp3x.h
+++ b/sound/soc/amd/raven/acp3x.h
@@ -78,6 +78,7 @@ struct acp3x_platform_info {
struct i2s_dev_data {
bool tdm_mode;
unsigned int i2s_irq;
+ u16 i2s_instance;
u32 tdm_fmt;
u32 substream_type;
void __iomem *acp3x_base;
--
2.20.1
next prev parent reply other threads:[~2019-12-31 0:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1577540460-21438-1-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com>
2019-12-28 13:40 ` [PATCH 1/6] ASoC: amd: Refactoring of DAI from DMA driver Ravulapati Vishnu vardhan rao
2019-12-28 13:40 ` [PATCH 2/6] ASoC: amd: Enabling I2S instance in DMA and DAI Ravulapati Vishnu vardhan rao
2019-12-31 0:30 ` Applied "ASoC: amd: Enabling I2S instance in DMA and DAI" to the asoc tree Mark Brown
2019-12-28 13:40 ` [PATCH 3/6] ASoC: amd: add ACP3x TDM mode support Ravulapati Vishnu vardhan rao
2019-12-31 0:30 ` Mark Brown [this message]
2019-12-28 13:40 ` [PATCH 4/6] ASoC: amd: Handle ACP3x I2S-SP Interrupts Ravulapati Vishnu vardhan rao
2019-12-31 0:30 ` Applied "ASoC: amd: Handle ACP3x I2S-SP Interrupts." to the asoc tree Mark Brown
2019-12-28 13:40 ` [PATCH 5/6] ASoC: amd: Added ACP3x system resume and runtime pm Ravulapati Vishnu vardhan rao
2019-12-31 0:30 ` Applied "ASoC: amd: Added ACP3x system resume and runtime pm" to the asoc tree Mark Brown
2019-12-28 13:41 ` [PATCH 6/6] ASoC: amd MMAP_INTERLEAVED Support Ravulapati Vishnu vardhan rao
2019-12-31 0:30 ` Applied "ASoC: amd MMAP_INTERLEAVED Support" to the asoc tree Mark Brown
2018-11-12 5:34 [PATCH 08/11] ASoC: amd: add acp3x tdm mode support Vijendar Mukunda
2018-11-13 19:45 ` Applied "ASoC: amd: add acp3x tdm mode support" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=applied-1577540460-21438-4-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com \
--to=broonie@kernel.org \
--cc="Cc:"@sirena.org.uk \
--cc=Alexander.Deucher@amd.com \
--cc=Liam@sirena.org.uk \
--cc=Takashi@sirena.org.uk \
--cc=Vishnuvardhanrao.Ravulapati@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=dan.carpenter@oracle.com \
--cc=djkurtz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=moderated@sirena.org.uk \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®