mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: "D. Manresa" <dmanresa@gmail.com>
Cc: "Daniel Scally" <dan.scally@ideasonboard.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: int3472: Add TPS68470 board data for Dell Latitude 7275
Date: Fri, 4 Sep 2026 10:04:52 +0300	[thread overview]
Message-ID: <apptlIQexoFg42DF@kekkonen.localdomain> (raw)
In-Reply-To: <20260904062006.39209-1-dmanresa@gmail.com>

Hi D.,

On Fri, Sep 04, 2026 at 08:20:06AM +0200, D. Manresa wrote:
> The Dell Latitude 7275 2-in-1 has the same camera design as the Latitude
> 7212 Rugged Extreme Tablet: an OmniVision OV5670 front sensor (ACPI
> INT3479) powered by a TI TPS68470 PMIC, with GPIO 3 as reset and GPIO 4 as
> powerdown and the same regulator voltages. The only difference is that the
> PMIC ACPI node enumerates as INT3472:04 instead of INT3472:05, so the
> existing board data is not matched and the driver fails with "No
> board-data found for this model".
> 
> Add a board data entry for the Latitude 7275 reusing the 7212 regulator
> and GPIO tables with the right device name.

What's below would better fit after the '---' line.

> 
> Tested on a Latitude 7275 (BIOS 1.18.0): the PMIC probes, the OV5670
> binds and libcamera streams from the IPU3.
> 
> Note: on this machine the sensor sits on the I2C4 controller (INT3446),
> whose MMIO region overlaps an ACPI OperationRegion (\_SB.PCI0.GEXP.BAR0),
> so the intel-lpss driver only binds with acpi_enforce_resources=lax.

Is this the same issue than for Latutude 5285 here
<URL:https://lore.kernel.org/linux-media/20260831160754.9857-1-tchatard@gmail.com/>?

> 
> Signed-off-by: D. Manresa <dmanresa@gmail.com>
> ---
> --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c
> +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c
> @@ -449,6 +449,15 @@
>  	},
>  };
>  
> +static const struct int3472_tps68470_board_data dell_7275_tps68470_board_data = {
> +	.dev_name = "i2c-INT3472:04",
> +	.tps68470_regulator_pdata = &dell_7212_tps68470_pdata,
> +	.n_gpiod_lookups = 1,
> +	.tps68470_gpio_lookup_tables = {
> +		&dell_7212_int3479_gpios,
> +	},
> +};
> +
>  static const struct int3472_tps68470_board_data msi_prestige_ai_evo_tps68470_board_data = {
>  	.dev_name = "i2c-INT3472:06",
>  	.tps68470_regulator_pdata = &msi_prestige_ai_evo_tps68470_pdata,
> @@ -500,6 +509,13 @@
>  	},
>  	{
>  		.matches = {
> +			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Latitude 7275"),
> +		},
> +		.driver_data = (void *)&dell_7275_tps68470_board_data,
> +	},
> +	{
> +		.matches = {
>  			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Micro-Star International Co., Ltd."),
>  			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Prestige 13 AI+ Evo A2VMG"),
>  			DMI_EXACT_MATCH(DMI_BOARD_NAME, "MS-13Q3"),

-- 
Regards,

Sakari Ailus

      reply	other threads:[~2026-09-04  7:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04  6:20 D. Manresa
2026-09-04  7:04 ` Sakari Ailus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apptlIQexoFg42DF@kekkonen.localdomain \
    --to=sakari.ailus@linux.intel.com \
    --cc=dan.scally@ideasonboard.com \
    --cc=dmanresa@gmail.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®