From: Johan Hovold <johan@kernel.org>
To: Adriano Cordova <adrianox@gmail.com>
Cc: elder@kernel.org, gregkh@linuxfoundation.org,
greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org,
syzbot+2fd6aefc361af86911d5@syzkaller.appspotmail.com,
Yang Zi <2959243019@qq.com>
Subject: Re: [PATCH v2] greybus: operation: fix out-of-bounds write in message allocation
Date: Fri, 4 Sep 2026 10:57:18 +0200 [thread overview]
Message-ID: <apqH7j3tQiXZqiOk@hovoldconsulting.com> (raw)
In-Reply-To: <apqDK5dHYGaJRwx1@hovoldconsulting.com>
On Fri, Sep 04, 2026 at 10:36:59AM +0200, Johan Hovold wrote:
> On Wed, Sep 02, 2026 at 10:59:16AM -0400, Adriano Cordova wrote:
> > The incoming message size from the device header (header.size) is
> > trusted without checking that it is at least the size of the message
> > header itself, but a value smaller than sizeof(struct gb_operation_msg_hdr)
> > underflows request_size in gb_operation_create_incoming(), wraps around
> > in gb_operation_message_alloc(), and results in a tiny buffer that is
> > then written past its end in gb_operation_message_init().
>
> Is it really? I was under the impression the only issue here was the
> potential zero-size-pointer deref.
You're right of course, there's a potential small (7 byte) OOB write
here too.
Johan
prev parent reply other threads:[~2026-09-04 8:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 14:59 Adriano Cordova
2026-09-04 8:36 ` Johan Hovold
2026-09-04 8:57 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apqH7j3tQiXZqiOk@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=2959243019@qq.com \
--cc=adrianox@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+2fd6aefc361af86911d5@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®