From: Herbert Xu <herbert@gondor.apana.org.au>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-crypto@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: amcc: trng: use devm_of_iomap()
Date: Fri, 4 Sep 2026 19:29:47 +1000 [thread overview]
Message-ID: <apqPiw_Oar-BaAtv@gondor.apana.org.au> (raw)
In-Reply-To: <20260812185747.79173-1-rosenp@gmail.com>
On Wed, Aug 12, 2026 at 11:57:47AM -0700, Rosen Penev wrote:
> Convert of_iomap() to devm_of_iomap() so that the TRNG register
> mapping is automatically unmapped on driver detach, eliminating
> the need for manual iounmap() calls in the error and remove paths.
>
> Assisted-by: opencode:big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> drivers/crypto/amcc/crypto4xx_trng.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
Please check Sashiko:
https://sashiko.dev/#/patchset/20260812185747.79173-1-rosenp%40gmail.com
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2026-09-04 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 18:57 Rosen Penev
2026-09-04 9:29 ` Herbert Xu [this message]
2026-09-04 18:36 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apqPiw_Oar-BaAtv@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®