From: Srikar Dronamraju <srikar@linux.ibm.com>
To: Shrikanth Hegde <sshegde@linux.ibm.com>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
skiboot@lists.ozlabs.org, arbab@linux.ibm.com,
mahesh@linux.ibm.com, Ritesh Harjani <ritesh.list@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Valentin Schneider <vschneid@redhat.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] powerpc/numa: Allow cpu_to_coregroup_id without PPC_SPLPAR
Date: Fri, 4 Sep 2026 16:40:37 +0530 [thread overview]
Message-ID: <apqnLSv03hsJi_Gl@linux.ibm.com> (raw)
In-Reply-To: <f5011bc9-a25d-4f17-92ad-874f9c580dd2@linux.ibm.com>
* Shrikanth Hegde <sshegde@linux.ibm.com> [2026-09-04 15:29:03]:
>
>
> On 9/2/26 6:05 PM, Srikar Dronamraju wrote:
> > Make cpu_to_coregroup_id() available outside PPC_SPLPAR so it can be
> > used by platforms that do not rely on the SPLPAR-specific VPHN path.
> >
> >
> > diff --git a/arch/powerpc/include/asm/topology.h b/arch/powerpc/include/asm/topology.h
> > index 44ec416fa489..02c3c9ab3ea9 100644
> > --- a/arch/powerpc/include/asm/topology.h
> > +++ b/arch/powerpc/include/asm/topology.h
> > @@ -71,6 +71,7 @@ extern void map_cpu_to_node(int cpu, int node);
> > extern void unmap_cpu_from_node(unsigned long cpu);
> > #endif /* CONFIG_HOTPLUG_CPU */
> > +int cpu_to_coregroup_id(int cpu);
>
> nit:
>
> I prefer extern before declaration so that i can see it is defined
> elsewhere.
Hey Shrikanth,
Thanks for taking a look.
It was done on intention based on comment from Christophe Leroy here
https://lkml.kernel.org/r/6387fb12-76f1-4503-8ac2-3ca777c0186e@kernel.org
>
> Other than that, rest looks good to me.
>
> Reviewed-by: Shrikanth Hegde <sshegde@linux.ibm.com>
>
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2026-09-04 11:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260902123458.340456-5-srikar@linux.ibm.com>
2026-09-02 12:35 ` [PATCH v3 1/3] powerpc/numa: Simplify find_primary_domain_index Srikar Dronamraju
2026-09-04 10:05 ` Shrikanth Hegde
2026-09-02 12:35 ` [PATCH v3 2/3] powerpc/numa: Allow cpu_to_coregroup_id without PPC_SPLPAR Srikar Dronamraju
2026-09-04 9:59 ` Shrikanth Hegde
2026-09-04 11:10 ` Srikar Dronamraju [this message]
2026-09-02 12:35 ` [PATCH v3 3/3] powerpc/numa: Support coregroup on PowerNV Srikar Dronamraju
2026-09-04 10:04 ` Shrikanth Hegde
2026-09-04 11:34 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apqnLSv03hsJi_Gl@linux.ibm.com \
--to=srikar@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=arbab@linux.ibm.com \
--cc=chleroy@kernel.org \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mahesh@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=ritesh.list@gmail.com \
--cc=rppt@kernel.org \
--cc=skiboot@lists.ozlabs.org \
--cc=sshegde@linux.ibm.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®