From: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
To: mdshahid03@gmail.com
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, rjui@broadcom.com, sbranden@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/5] iio: adc: bcm_iproc_adc: use device-managed resources
Date: Fri, 4 Sep 2026 19:25:45 -0300 [thread overview]
Message-ID: <aptFaaWIJ_azy9Ok@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <20260901144030.509802-1-mdshahid03@gmail.com>
Hello Shahid,
On 09/01, mdshahid03@gmail.com wrote:
> Hi all,
>
> Thanks for the reviews and suggestions.
>
> For v3, I will incorporate the following changes:
>
> Patch 2/5:
> -Add the direct includes for <linux/bits.h>, <linux/types.h>, and <linux/array_size.h>.
> Keep <linux/device-id/of.h> and <linux/iio/types.h> out, as these are already provided through the appropriate headers.
> Patch 5/5:
> -Remove the now-unnecessary platform_set_drvdata().
> -Return devm_iio_device_register() directly.
> -Remove the unnecessary backticks around function names in the commit message.
>
> For patch 3/5, I understand that splitting the ADC cleanup into a follow-up patch would be preferable from a patch-scope
> perspective.I will split this into a separate patch for v3.
>
> Please let me know if I have misunderstood any of the review comments.
I believe the above list is correct.
With best regards,
Marcelo
prev parent reply other threads:[~2026-09-04 22:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-30 17:09 mdshahid03
2026-08-30 17:09 ` [PATCH v2 1/5] iio: adc: bcm_iproc_adc: sort headers alphabetically mdshahid03
2026-08-30 17:09 ` [PATCH v2 2/5] iio: adc: bcm_iproc_adc: fix include dependencies mdshahid03
2026-09-01 2:27 ` Marcelo Schmitt
2026-09-01 3:16 ` Jonathan Cameron
2026-09-01 6:57 ` Andy Shevchenko
2026-08-30 17:09 ` [PATCH v2 3/5] iio: adc: bcm_iproc_adc: use devm-managed cleanup mdshahid03
2026-08-30 20:18 ` Jonathan Cameron
2026-08-30 17:09 ` [PATCH v2 4/5] iio: adc: bcm_iproc_adc: use devm-managed mutex initialization mdshahid03
2026-08-30 17:09 ` [PATCH v2 5/5] iio: adc: bcm_iproc_adc: use devm_iio_device_register() mdshahid03
2026-08-30 20:18 ` Jonathan Cameron
2026-09-01 2:13 ` Marcelo Schmitt
2026-09-01 14:40 ` [PATCH v2 0/5] iio: adc: bcm_iproc_adc: use device-managed resources mdshahid03
2026-09-04 22:25 ` Marcelo Schmitt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aptFaaWIJ_azy9Ok@debian-BULLSEYE-live-builder-AMD64 \
--to=marcelo.schmitt1@gmail.com \
--cc=andy@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdshahid03@gmail.com \
--cc=nuno.sa@analog.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®