mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Linux ACPI <linux-acpi@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] ACPI: glue: Reduce debug noise from acpi_device_notify()
Date: Sat, 5 Sep 2026 09:56:52 +0300	[thread overview]
Message-ID: <apu9NIro83DpSu3z@ashevche-desk.local> (raw)
In-Reply-To: <2868233.mvXUDI8C0e@rafael.j.wysocki>

On Fri, Sep 04, 2026 at 02:55:03PM +0200, Rafael J. Wysocki wrote:
> From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> 
> When debug is enabled in the ACPI glue code that handles binding
> devices to ACPI companions, acpi_device_notify() produces a lot of
> message noise related to devices that have no ACPI companions.
> 
> Reduce that noise by checking the most obvious cases, ACPI device
> objects and devices without a bus type, directly and returning from
> acpi_device_notify() in these cases without printing any debug
> messages.
> 
> Also make the debug messages that get printed more informative and
> change the format prefix to "ACPI/glue", so it is easier to filter
> these messages.

I would argue that the consistent formatting will be "ACPI: glue: "

$ git grep -n 'pr_fmt.*ACPI: [^"]'  -- drivers/acpi/ | wc -l
24

The / is used only in two cases: acpi/hmat and acpi/mrrm.

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2026-09-05  6:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04 12:55 Rafael J. Wysocki
2026-09-05  6:56 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apu9NIro83DpSu3z@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®