From: Shashank Maurya <shashank.maurya@oss.qualcomm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, venkata.valluru@oss.qualcomm.com,
Jessica Zhang <jesszhan0024@gmail.com>
Subject: Re: [PATCH] regulator: rpi-panel-v2: Add optional vcc-supply support
Date: Sat, 5 Sep 2026 10:08:30 +0530 [thread overview]
Message-ID: <apucxtSP9XUHlPC6@hu-ssmaurya-hyd.qualcomm.com> (raw)
In-Reply-To: <aphFUThYNg8JYtEx@sirena.org.uk>
On Wed, Sep 02, 2026 at 04:48:33PM +0100, Mark Brown wrote:
> On Mon, Aug 31, 2026 at 11:44:08AM +0530, Shashank Maurya wrote:
> > On Fri, Aug 28, 2026 at 01:13:42PM +0100, Mark Brown wrote:
> > > On Fri, Aug 28, 2026 at 09:59:43AM +0530, Shashank Maurya wrote:
>
> > > > The Raspberry Pi Panel V2 regulator driver may rely on an external
> > > > power rail being provided through the device tree. Add support for an
> > > > optional "vcc" regulator and enable it during probe before accessing
> > > > the panel controller.
>
> > > Does the device work without power? A name like "Vcc" makes it sound
> > > like this is the main supply for the device...
>
> > No without VCC, regulator will not be up. So device will not work if
> > power rail is software controlled and not always high.
>
> That doesn't sound very optional then.
Apologies I missed below discussion over the list.
>> Yes Mark, this isn't optional on qualcomm boards. But it might be optional
>> for boards where power up logic is hardware controlled or always high.
>That's not how regulators work - with regulators the driver is
>independent of the specific system it runs on, the machine constraints
>deal with any system specifics.
>Please don't take things off-list unless there is a really strong reason
>to do so. Sending things to the list ensures that everyone gets a
>chance to read and comment on things.
Going forward, I'll make vcc sipply compulsory then.
prev parent reply other threads:[~2026-09-05 4:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 4:29 Shashank Maurya
2026-08-28 12:13 ` Mark Brown
2026-08-31 6:14 ` Shashank Maurya
2026-09-02 15:48 ` Mark Brown
2026-09-05 4:38 ` Shashank Maurya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apucxtSP9XUHlPC6@hu-ssmaurya-hyd.qualcomm.com \
--to=shashank.maurya@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=jesszhan0024@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=venkata.valluru@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®