mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Golle <daniel@makrotopia.org>
To: "hpp.iscas" <hppiscas@163.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
	Brian Masney <bmasney+clk@redhat.com>,
	Jerome Brunet <jbrunet+clk@baylibre.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	Sam Shih <sam.shih@mediatek.com>
Subject: Re: [PATCH] clk: mediatek: mt7988-apmixed: Publish the OF module alias
Date: Sat, 5 Sep 2026 21:44:26 +0100	[thread overview]
Message-ID: <apx_Ks4KqoJZgVHd@makrotopia.org> (raw)
In-Reply-To: <20260905133417.64373-1-hppiscas@163.com>

On Sat, Sep 05, 2026 at 09:34:17PM +0800, hpp.iscas wrote:
> COMMON_CLK_MT7988 is tristate and builds apmixed as a separate object.
> The apmixed platform driver has an OF match table but exports no OF
> alias, so that table cannot be used to select the module on a device
> event.
> 
> Publish the table. Keep the existing initialization entry point.
> 
> Fixes: 4b4719437d85 ("clk: mediatek: add drivers for MT7988 SoC")
> Signed-off-by: hpp.iscas <hppiscas@163.com>

Not sure if this Signed-off-by:-line is ok like that, do I understand
correctly that 163.com is a freemail provider?

Other than that

Reviewed-by: Daniel Golle <daniel@makrotopia.org>

> ---
>  drivers/clk/mediatek/clk-mt7988-apmixed.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/mediatek/clk-mt7988-apmixed.c b/drivers/clk/mediatek/clk-mt7988-apmixed.c
> index 416a4b8..24f4e7b 100644
> --- a/drivers/clk/mediatek/clk-mt7988-apmixed.c
> +++ b/drivers/clk/mediatek/clk-mt7988-apmixed.c
> @@ -75,6 +75,7 @@ static const struct of_device_id of_match_clk_mt7988_apmixed[] = {
>  	{ .compatible = "mediatek,mt7988-apmixedsys" },
>  	{ /* sentinel */ }
>  };
> +MODULE_DEVICE_TABLE(of, of_match_clk_mt7988_apmixed);
>  
>  static int clk_mt7988_apmixed_probe(struct platform_device *pdev)
>  {
> 
> 

      reply	other threads:[~2026-09-05 20:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-05 13:34 hpp.iscas
2026-09-05 20:44 ` Daniel Golle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apx_Ks4KqoJZgVHd@makrotopia.org \
    --to=daniel@makrotopia.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=bmasney+clk@redhat.com \
    --cc=hppiscas@163.com \
    --cc=jbrunet+clk@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=sam.shih@mediatek.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®