From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: Kees Cook <kees@kernel.org>
Cc: Hui Peng <benquike@gmail.com>,
Andy Lutomirski <luto@amacapital.net>,
Will Drewry <wad@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] seccomp: restore knotif->state when SECCOMP_ADDFD_FLAG_SEND is interrupted
Date: Sun, 20 Sep 2026 11:10:45 +0100 [thread overview]
Message-ID: <aq-w4L8KNnLNFYNZ@gremlin> (raw)
In-Reply-To: <202609192050.D1E0CD96@keescook>
On Sat, Sep 19, 2026 at 08:50:57PM -0700, Kees Cook wrote:
> On Sat, Sep 19, 2026 at 08:35:14PM +0000, Hui Peng wrote:
> > In seccomp_notify_addfd(), when SECCOMP_ADDFD_FLAG_SEND is set,
> > knotif->state is transitioned from SECCOMP_NOTIFY_SENT to
> > SECCOMP_NOTIFY_REPLIED before dropping filter->notify_lock and waiting
> > in wait_for_completion_interruptible(&kaddfd.completion).
> >
> > If wait_for_completion_interruptible() is interrupted by a signal before
> > the target task processes the kaddfd entry, seccomp_notify_addfd()
> > removes kaddfd.list from knotif->addfd via list_del(&kaddfd.list), but
> > leaves knotif->state set to SECCOMP_NOTIFY_REPLIED.
>
> Are you able to construct a regression test for this so we can catch
> this race if it ever gets exposed again?
I'd disregard this guy and treat this as, at best, an AI-generated bug report.
He sent 115 patches across 40 subsystems in 2 hours.
https://lore.kernel.org/all/?q=f%3Ahui+peng
Unfortunately I feel we are only at the beginning of this kind of thing :(
>
> --
> Kees Cook
>
--
Cheers, Lorenzo
next prev parent reply other threads:[~2026-09-20 10:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 20:35 Hui Peng
2026-09-19 22:22 ` Bradley Morgan
2026-09-20 3:50 ` Kees Cook
2026-09-20 4:16 ` [PATCH v2] " Hui Peng
2026-09-20 7:20 ` [PATCH v3] " Hui Peng
2026-09-20 11:56 ` Bradley Morgan
2026-09-20 10:10 ` Lorenzo Stoakes (ARM) [this message]
2026-09-20 11:55 ` [PATCH] " Bradley Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aq-w4L8KNnLNFYNZ@gremlin \
--to=ljs@kernel.org \
--cc=benquike@gmail.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®