mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Malathi A <malathi.a2000@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] serial: 8250_uniphier: Use dev_err_probe() in probe error paths
Date: Fri, 18 Sep 2026 12:41:39 +0300	[thread overview]
Message-ID: <aq0HU0ydof9GLp4_@ashevche-desk.local> (raw)
In-Reply-To: <20260918074546.245342-1-malathi.a2000@gmail.com>

On Fri, Sep 18, 2026 at 07:45:46AM +0000, Malathi A wrote:
> devm_clk_get_enabled() returns -EPROBE_DEFER while the clock provider is
> not registered yet, and uniphier_uart_probe() reports that with
> dev_err(). Every retry of an intermittently deferred probe therefore
> prints "failed to get and enable clock" at error level, which is only
> dmesg noise.
> 
> Use dev_err_probe() instead: it demotes -EPROBE_DEFER to dev_dbg() and
> records the reason for /sys/kernel/debug/devices_deferred. Convert the
> other two error messages in probe as well, so the whole function follows
> the "return dev_err_probe()" pattern already used by other 8250 drivers
> such as 8250_em.c. Those two codes are never -EPROBE_DEFER, so there the
> conversion is a readability change only.
> 
> Errors other than a deferral are still logged at error level, now with
> the error code added by the helper. No functional change otherwise.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2026-09-18  9:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18  7:45 Malathi A
2026-09-18  9:41 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aq0HU0ydof9GLp4_@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hayashi.kunihiko@socionext.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=malathi.a2000@gmail.com \
    --cc=mhiramat@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®