From: Christoph Hellwig <hch@infradead.org>
To: Carlos Maiolino <cem@kernel.org>
Cc: Lalit Shankar Chowdhury <lalitshankarch@gmail.com>,
"open list:XFS FILESYSTEM" <linux-xfs@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xfs: replace kvmalloc_array with kvzalloc_objs
Date: Fri, 18 Sep 2026 04:16:46 -0700 [thread overview]
Message-ID: <aq0dnoWhkq9JZkiu@infradead.org> (raw)
In-Reply-To: <aqzHPqgh-rKqHRo-@nidhogg.toxiclabs.cc>
On Fri, Sep 18, 2026 at 07:16:32AM +0200, Carlos Maiolino wrote:
> On Thu, Sep 17, 2026 at 08:08:35PM +0000, Lalit Shankar Chowdhury wrote:
> > Replace kvmalloc_array() with the more concise kvzalloc_objs()
> > implementation.
> >
> > Signed-off-by: Lalit Shankar Chowdhury <lalitshankarch@gmail.com>
>
> NAK...
>
> This is used to allocate composite objects managed through a
> slab cache. This is not for fundamental basic data types....
I don't think so. While the naming of the helper is a bit
unfortunate, it is intended for allocating arrays.
But this function really should not exist, instead bitmap_alloc/free
should be switched to th kvmalloc family so that it will just work
for large allocations and we can kill the wrappers in XFS.
next prev parent reply other threads:[~2026-09-18 11:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 20:08 Lalit Shankar Chowdhury
2026-09-18 5:16 ` Carlos Maiolino
2026-09-18 11:16 ` Christoph Hellwig [this message]
2026-09-18 11:32 ` Carlos Maiolino
2026-09-18 11:44 ` Carlos Maiolino
2026-09-18 13:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aq0dnoWhkq9JZkiu@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=lalitshankarch@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®