From: Frederic Weisbecker <frederic@kernel.org>
To: Wang Shuaiwei <wangshuaiwei1@xiaomi.com>
Cc: Thomas Gleixner <tglx@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
wanghui33@xiaomi.com, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH] tick/block: Add BLOCK_SOFTIRQ to the hotplug safe mask
Date: Fri, 18 Sep 2026 14:42:27 +0200 [thread overview]
Message-ID: <aq0xs91Vs4NWBqa3@localhost.localdomain> (raw)
In-Reply-To: <20260904064506.671203-1-wangshuaiwei1@xiaomi.com>
Le Fri, Sep 04, 2026 at 02:45:06PM +0800, Wang Shuaiwei a écrit :
> During CPU-hotplug stress testing combined with an I/O
> workload, the following message is observed:
>
> "NOHZ tick-stop error: local softirq work is pending, handler #10!!!"
>
> On CPU offline, ksoftirqd is parked at CPUHP_AP_SMPBOOT_THREADS while
> the CPU still takes interrupts. A block completion raised after that
> point stays pending, and if the dying CPU goes idle before teardown,
> report_idle_softirq() sees it, keeps the tick alive and prints the
> error above.
>
> Such pending block completions on the outgoing CPU are drained later by
> blk_softirq_cpu_dead() (CPUHP_BLOCK_SOFTIRQ_DEAD), so a pending
> BLOCK_SOFTIRQ is harmless here. Add it to SOFTIRQ_HOTPLUG_SAFE_MASK
> like the other teardown-covered vectors.
>
> Signed-off-by: Wang Shuaiwei <wangshuaiwei1@xiaomi.com>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
--
Frederic Weisbecker
SUSE Labs
next prev parent reply other threads:[~2026-09-18 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 6:45 Wang Shuaiwei
2026-09-17 9:30 ` Wang Shuaiwei
2026-09-17 9:51 ` Sebastian Andrzej Siewior
2026-09-18 10:39 ` Wang Shuaiwei
2026-09-18 12:42 ` Frederic Weisbecker [this message]
2026-09-19 21:05 ` [tip: timers/nohz] tick/nohz: " tip-bot2 for Wang Shuaiwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aq0xs91Vs4NWBqa3@localhost.localdomain \
--to=frederic@kernel.org \
--cc=axboe@kernel.dk \
--cc=bigeasy@linutronix.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@kernel.org \
--cc=wanghui33@xiaomi.com \
--cc=wangshuaiwei1@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®