From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: broonie@kernel.org, krzk@kernel.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
patches@opensource.cirrus.com, perex@perex.cz,
s.nawrocki@samsung.com, tiwai@suse.com, stable@vger.kernel.org
Subject: Re: [PATCH] ASoC: codecs: wm8994: Fix runtime PM leak in wm8994_mic_detect()
Date: Fri, 18 Sep 2026 15:57:10 +0100 [thread overview]
Message-ID: <aq1RRlQQB2BTikJF@opensource.cirrus.com> (raw)
In-Reply-To: <20260917165130.2163278-1-vulab@iscas.ac.cn>
On Thu, Sep 17, 2026 at 04:51:30PM +0000, Wentao Liang wrote:
> wm8994_mic_detect() resumes the component before configuring the MICBIAS
> pins, but the default case of the micbias switch returns -EINVAL right
> after taking that reference, skipping the pm_runtime_put() on the
> success path. This leaks a runtime PM reference on every call with an
> invalid micbias.
>
> Release the reference before returning -EINVAL.
>
> Fixes: f5a2cda4f1db ("ASoC: wm8994: Ensure the device is resumed in wm89xx_mic_detect functions")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2026-09-18 14:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 16:51 Wentao Liang
2026-09-18 14:57 ` Charles Keepax [this message]
2026-09-18 17:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aq1RRlQQB2BTikJF@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=s.nawrocki@samsung.com \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®