From: Karl Mehltretter <kmehltretter@gmail.com>
To: Alexander Potapenko <glider@google.com>
Cc: Andrey Konovalov <andreyknvl@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
Marco Elver <elver@google.com>,
Bradley Morgan <include@grrlz.net>,
kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] kcov: report the first spurious PC in the interrupt selftest
Date: Sat, 19 Sep 2026 10:00:54 +0200 [thread overview]
Message-ID: <aq44VWaVBpRvWtmF@gmail.com> (raw)
In-Reply-To: <CAG_fn=VTpkAUHUqWgcqigQ8UaLDtikZJmOE-VozemA+RbyJVnw@mail.gmail.com>
On Mon, Sep 14, 2026 at 12:21:38PM +0100, Alexander Potapenko wrote:
> What do you think of increasing the buffer size to, say, 16 elements?
> This way we'll be able to detect more than one spurious coverage event
> without needing to rebuild the kernel.
Good idea. v3 uses 16 elements, the count plus up to 15 PCs, and no
longer stops at the first PC: KCOV stays enabled for the full 300 ms,
then is disabled. If any PCs were recorded, it prints them all and
panics.
> > + if (selftest_area[0]) {
> > + ip = decanonicalize_ip(selftest_area[1]);
> > + pr_err("spurious coverage detected during interrupt selftest: %pS\n",
>
> Nit: should this be %pB?
Agreed. KCOV records return addresses, so %pB handles function-boundary
cases. I'll also change the trailer to the new Assisted-by: LLM.
Thanks for the review!
Karl
prev parent reply other threads:[~2026-09-19 8:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 19:21 Karl Mehltretter
2026-07-24 19:27 ` Bradley Morgan
2026-09-12 9:28 ` Karl Mehltretter
2026-09-14 10:21 ` Alexander Potapenko
2026-09-19 8:00 ` Karl Mehltretter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aq44VWaVBpRvWtmF@gmail.com \
--to=kmehltretter@gmail.com \
--cc=andreyknvl@gmail.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=include@grrlz.net \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®