From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E2D03EEAE7 for ; Sat, 19 Sep 2026 09:07:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789808875; cv=none; b=eFw7cduz7tvwY3QRd1lY1DIFmdV3SPDTrTKflOKVFBEFUmiZSWG09kx/x9Ub3DIbqNsgVXuridJhwJWs3Zntmli23BcIp1g2KxNzxKVLjfubtusYOXlhphbvQbZAGBMN0LWKMDVdWKyK8gdLdfuOibju0qa+2Zfbdjk3loOyIXE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789808875; c=relaxed/simple; bh=EWOHrvtfAdH8SUMdIJx2yEBFvBc3QNtqqxzu2fF0hD0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KVhAVd3MPy/mOc4+qN5nGiDJgazTjY+zd5J8KY+eUnTTaPYzHWaCF0YscueXe0R6xH5ErqLJrIn6NabG/zFn3FelQ7+83q25xuVzHcnvGbe0B05l9GpORPki+prhHHBUdfcCmRk/REHJYY6Sqz47mn3Akk2zrnRqLcqYXXv+mjM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fprrbYwr; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fprrbYwr" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49e69b9e16aso15849725e9.1 for ; Sat, 19 Sep 2026 02:07:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789808872; x=1790413672; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=NbapgDXr+FyoTKQ50JUeVgfa7Tqe0pMogS4ct7fFvKE=; b=fprrbYwrbQZylNVye0yOD5gMuMSrQVHMsLOgDD+V00Xhz/3FDJdu58hyzbT/seM/Iq phj/3vAj/rkJwSnUzCqrs0jCi0eN272M4vvV3DsknxFbv9GPr3KvkGPWTmWAnvonbFaJ NZi+vdGeukRjh3iwAdq7UHJ8pELZqY2ta0HAybuUROz0NlMAYfE5sxhW+L7C5uWiNR0K 39McqlE0dqc+mYYMnYvp1AQcLkjtbFqzp6HPEzIDjY4BiH7/7QP2Slq2GC0pQL3oMAqB nXw7FDMMLFMi9wHJFUkhDLHusVYNEdC6kTBGSjC+50hS0LbAFUXKPa7zbyHa8AFFvPOs 0Jew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789808872; x=1790413672; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=NbapgDXr+FyoTKQ50JUeVgfa7Tqe0pMogS4ct7fFvKE=; b=ox/a3cFtH6ySoxAEOavYTtoPTWOI2ENusvdFxgmdFnp04ESmsDiCIqnWoQpJmKcZPg jDKQ1b7WI/kM50XUkP+Q/mCYOwyZ5KW/tnn/lkDwLEszTUzwensjZ6xzW80cY7hf3kV+ tH5gcGVy5sKosY4IcFqQMdsc+5O05a1rNaBncUouO50UFAaD2hwnYiIKp42YCvpNrzKL 9H/BixdEOa3jgBmQROAQPYZQ1gjA05Q51Krnuwfw3swyLD2Gsv+/zATU/iOP/j8rjmAK 4dRyGqpBzNG8WHdXUqvTn+rmkAI43iOZmbwoEePz4Lj0xVH7raNDlCfTjDN2zXR++Y2r GUSQ== X-Forwarded-Encrypted: i=1; AKwUvBzo8SIvUIKbcxVoHDEg+MDAC6Zb1FTKcDs//vZUVAEg98xMbUJFm+N00toD9LpfFLbJez8wmrYF4xv5ENg=@vger.kernel.org X-Gm-Message-State: AFuF++mOeyC37Dd08wpzw1oncYoKDzOt6rINTskiZJpGEh6hdV6mzxIo bR3jB0o41CLRyUmZHLt092pIMD0FicD5Ac98hiEsJEexOVXdHSPg3UaX X-Gm-Gg: AYBFou2DcK4kSRalsCZ488DSER8Mh3jnnuBd78PKPGFgQyHqchtaWNKVngx3huBucb9 VSCncuH/KOA/16h2wkvNORM2MIpyGmVAxpDz5RPFJwZNajA818CpSUEPpwefMj50gVSQl0wfJZ5 YHtMJEOGqAgoHZlOLNSOHFolvphAA8yxRvc7dv536qje0POj4pUI1V83tH2HLTsBd4vwpwnWNl+ MRfkMzoSaepqs3jFGtfNmDYl9dX0hz1euU/vmefzbh6udqT2DiBJ74v/bA1cRdovx8uQpjkW7FT BwScSUMFosLJF6SVttR/yU0++/Ex3I+uv2LhCT5XT0u7LcB9s5pzGT/DF4f0GSb6lsySy2oWkja CzKD6p29xPpOpu4+h8bvLfNG0/KUPReDCZuAcCQKFSWENBC6i+xGI1caCveH0ttLRpfZ35ha3SG 9DBUGa0pcpmPW7QHx3YzC2m5UW+cX9nbREgwHZdQ3DS8aRalg63qXlLsML245HWXQfN9sT4Us2Y EPwecF4zPYAVx13ugWd/DRmsdIhPTMsXgkm8SaH43sS4TmNEqxgp5v/nuauWtxDkkQv2AqzL0va sD3eXzqgd/VvB67Kw/3U+/VAVoISPWR0Hdpov8OmSQxA9q3rgNcx6V70ZL2tLzZBH6u42ny6uBi 9yKc= X-Received: by 2002:a05:600c:a085:b0:49d:25b0:cc60 with SMTP id 5b1f17b1804b1-49fc5747f7bmr70121265e9.29.1789808871519; Sat, 19 Sep 2026 02:07:51 -0700 (PDT) Received: from unknown748F3CBA5068 (dynamic-2a02-3100-a017-2b01-05fe-203b-7cd2-a640.310.pool.telefonica.de. [2a02:3100:a017:2b01:5fe:203b:7cd2:a640]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fc7cba562sm86917495e9.2.2026.09.19.02.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Sep 2026 02:07:50 -0700 (PDT) Date: Sat, 19 Sep 2026 11:07:48 +0200 From: Karl Mehltretter To: Harry Yoo Cc: Vlastimil Babka , Andrew Morton , Rasmus Villemoes , Hao Li , Christoph Lameter , David Rientjes , Roman Gushchin , Catalin Marinas , Kees Cook , "Gustavo A . R . Silva" , Arnd Bergmann , Greg Kroah-Hartman , Shuah Khan , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-hardening@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v3 0/5] slab: ZERO_SIZE_PTR alignment and ERR_PTR hardening Message-ID: References: <20260903203720.63689-1-kmehltretter@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Sep 04, 2026 at 12:25:59PM +0100, Harry Yoo wrote: > I don't understand why v3 of this patchset suddenly implements > hardening for kfree() and usercopy to handle ERR_PTR(). > > The address range for 'zero or NULL PTR' range and ERR_PTR() do not > overlap. The bugfixes and hardening patches are irrelevant. > It should be a separate series? > > Also usercopy.c changes go through the hardening tree, slub.c and > slub_kunit.c changes go through the slab tree, and LKDTM has its own > tree. Patch 3 and 5 touch files across multiple trees, which can be > avoided. > I added the ERR_PTR changes after Kees raised handling that range in the v2 review [1]. The two topics also came up together in the 2014 [2] and 2019 [3] discussions; in the latter, Jann suggested a separate warning-and-return check [4]. I wanted to broaden the discussion and see whether considering both together might suggest a better approach. I agree that the resulting implementations are independent. I'll send v4 with the ZERO_SIZE_PTR alignment, exact-match and zero-size KUnit patches only, and pursue the ERR_PTR work separately. I'll split that work along the SLUB, usercopy and LKDTM boundaries you pointed out. [1] https://lore.kernel.org/r/202608111716.0FA9DB17@keescook/ [2] https://lore.kernel.org/r/87oaumdz1f.fsf@rasmusvillemoes.dk/ [3] https://lore.kernel.org/r/20191010103151.7708-1-mayhs11saini@gmail.com/ [4] https://lore.kernel.org/r/CAG48ez05QVn6_gQ2TBrRa1a_DWQoaSSYubUsu5YMWxx-gqMijQ@mail.gmail.com/ Thanks, Karl