mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shawn Guo <shengchao.guo@oss.qualcomm.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Dhruvin Rajpura <dhruvin.rajpura@oss.qualcomm.com>,
	Anandu Krishnan E <anandu.e@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v2 1/6] arm64: dts: qcom: nord: Add support for ADSP and CDSPs
Date: Sun, 20 Sep 2026 12:50:51 +0800	[thread overview]
Message-ID: <aq9mK6VpRB75x5FW@QCOM-aGQu4IUr3Y> (raw)
In-Reply-To: <20260904081619.593602-2-shengchao.guo@oss.qualcomm.com>

On Fri, Sep 04, 2026 at 04:16:14PM +0800, Shawn Guo wrote:
> Add device tree nodes to support ADSP (HPASS DSP) and CDSPs remoteproc
> on Nord SoC.
> 
> This includes:
> - SMEM memory reservation used by the inter-processor communication
>   infrastructure
> - IPCC mailbox controller for inter-processor signalling
> - AOSS QMP node for load state power management
> - SMP2P nodes providing stop control and fault/crash interrupt signals
> - Remoteproc nodes with a GLINK edge and FastRPC compute contexts for
>   userspace offload
> 
> The embedded variant specific power domains, XO clock, and interconnect
> paths are filled in nord-embedded.dtsi.
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/nord-embedded.dtsi |  63 ++
>  arch/arm64/boot/dts/qcom/nord-ipcc.h        | 144 ++++
>  arch/arm64/boot/dts/qcom/nord.dtsi          | 884 ++++++++++++++++++++
>  3 files changed, 1091 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/nord-ipcc.h

[...]

> @@ -1518,6 +1639,103 @@ tcsr: syscon@1f60000 {
>  			reg = <0x0 0x01f60000 0x0 0xa0000>;
>  		};
>  
> +		remoteproc_adsp: remoteproc@4c00000 {
> +			compatible = "qcom,nord-adsp-pas";
> +			reg = <0x0 0x04c00000 0x0 0x10000>;
> +
> +			interrupts-extended = <&intc GIC_SPI 159 IRQ_TYPE_EDGE_RISING>,
> +					      <&smp2p_adsp_in 0 IRQ_TYPE_EDGE_RISING>,
> +					      <&smp2p_adsp_in 1 IRQ_TYPE_EDGE_RISING>,
> +					      <&smp2p_adsp_in 2 IRQ_TYPE_EDGE_RISING>,
> +					      <&smp2p_adsp_in 3 IRQ_TYPE_EDGE_RISING>,
> +					      <&smp2p_adsp_in 7 IRQ_TYPE_EDGE_RISING>;
> +			interrupt-names = "wdog",
> +					  "fatal",
> +					  "ready",
> +					  "handover",
> +					  "stop-ack",
> +					  "shutdown-ack";
> +
> +			memory-region = <&hpass_dsp0_mem>,
> +					<&hpass_dsp0_dtb_mem>;
> +
> +			qcom,qmp = <&aoss_qmp>;
> +
> +			qcom,smem-states = <&smp2p_adsp_out 0>;
> +			qcom,smem-state-names = "stop";
> +
> +			status = "disabled";
> +
> +			glink-edge {
> +				interrupts-extended = <&ipcc0 IPCC_MPROC_ADSP0
> +							      IPCC_MPROC_SIGNAL_GLINK_QMP
> +							      IRQ_TYPE_EDGE_RISING>;
> +				mboxes = <&ipcc0 IPCC_MPROC_ADSP0
> +						 IPCC_MPROC_SIGNAL_GLINK_QMP>;
> +				qcom,remote-pid = <2>;
> +				label = "adsp";
> +
> +				fastrpc {
> +					compatible = "qcom,nord-fastrpc",
> +						     "qcom,kaanapali-fastrpc";
> +					qcom,glink-channels = "fastrpcglink-apps-dsp";
> +					label = "adsp";

With commit 9981fbe599e8 ("misc: fastrpc: Allocate entire reserved memory
for Audio PD in probe") landed in linux-next, we are getting repeated
error messages.

  qcom,fastrpc-cb 4c00000.remoteproc:glink-edge:fastrpc:compute-cb@6: remote heap memory region is not added

Adding memory-region fixes the problem.

  memory-region = <&hpass_rpc_remote_heap_mem>;

Will send v3 for that.

Shawn

> +					#address-cells = <1>;
> +					#size-cells = <0>;
> +
> +					compute-cb@3 {
> +						compatible = "qcom,fastrpc-compute-cb";
> +						reg = <3>;
> +						iommus = <&apps_smmu_0 0x09e3 0x0000>,
> +							 <&apps_smmu_0 0x0a43 0x0020>,
> +							 <&apps_smmu_0 0x0a63 0x0020>,
> +							 <&apps_smmu_0 0x0a83 0x0000>;
> +						dma-coherent;
> +					};
> +
> +					compute-cb@4 {
> +						compatible = "qcom,fastrpc-compute-cb";
> +						reg = <4>;
> +						iommus = <&apps_smmu_0 0x09e4 0x0000>,
> +							 <&apps_smmu_0 0x0a44 0x0020>,
> +							 <&apps_smmu_0 0x0a64 0x0020>,
> +							 <&apps_smmu_0 0x0a84 0x0000>;
> +						dma-coherent;
> +					};
> +
> +					compute-cb@5 {
> +						compatible = "qcom,fastrpc-compute-cb";
> +						reg = <5>;
> +						iommus = <&apps_smmu_0 0x09e5 0x0000>,
> +							 <&apps_smmu_0 0x0a45 0x0020>,
> +							 <&apps_smmu_0 0x0a65 0x0020>,
> +							 <&apps_smmu_0 0x0a85 0x0000>;
> +						dma-coherent;
> +					};
> +
> +					compute-cb@6 {
> +						compatible = "qcom,fastrpc-compute-cb";
> +						reg = <6>;
> +						iommus = <&apps_smmu_0 0x09e6 0x0000>,
> +							 <&apps_smmu_0 0x0a46 0x0020>,
> +							 <&apps_smmu_0 0x0a66 0x0020>,
> +							 <&apps_smmu_0 0x0a86 0x0000>;
> +						dma-coherent;
> +					};
> +				};
> +			};
> +		};

  reply	other threads:[~2026-09-20  4:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04  8:16 [PATCH v2 0/6] arm64: dts: qcom: nord: Add remoteproc and PMIC support Shawn Guo
2026-09-04  8:16 ` [PATCH v2 1/6] arm64: dts: qcom: nord: Add support for ADSP and CDSPs Shawn Guo
2026-09-20  4:50   ` Shawn Guo [this message]
2026-09-04  8:16 ` [PATCH v2 2/6] arm64: dts: qcom: nord-rrd: Enable " Shawn Guo
2026-09-04  9:58   ` Konrad Dybcio
2026-09-04  8:16 ` [PATCH v2 3/6] arm64: dts: qcom: nord: Add the SPMI PMIC arbiter Shawn Guo
2026-09-04  8:16 ` [PATCH v2 4/6] arm64: dts: qcom: nord: Add PMAU0102 and PMM8650AU PMIC support Shawn Guo
2026-09-09 12:23   ` Konrad Dybcio
2026-09-04  8:16 ` [PATCH v2 5/6] dt-bindings: arm: qcom: Document Nord Ride Embedded board Shawn Guo
2026-09-07 11:33   ` Shawn Guo
2026-09-04  8:16 ` [PATCH v2 6/6] arm64: dts: qcom: Add initial support for " Shawn Guo
2026-09-09 12:17   ` Konrad Dybcio
2026-09-04 10:00 ` [PATCH v2 0/6] arm64: dts: qcom: nord: Add remoteproc and PMIC support Konrad Dybcio
2026-09-07 12:06   ` Shawn Guo
2026-09-09 12:13     ` Konrad Dybcio
2026-09-09 13:16       ` Shawn Guo
2026-09-09 13:50         ` Konrad Dybcio
2026-09-11 20:33           ` Kamal Wadhwa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aq9mK6VpRB75x5FW@QCOM-aGQu4IUr3Y \
    --to=shengchao.guo@oss.qualcomm.com \
    --cc=anandu.e@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dhruvin.rajpura@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®