From: Kiryl Shutsemau <kirill@shutemov.name>
To: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>,
Gladyshev Ilya <ilya.gladyshev@linux.dev>
Cc: akpm@linux-foundation.org, david@kernel.org, ziy@nvidia.com,
hannes@cmpxchg.org, usama.arif@linux.dev, lance.yang@linux.dev,
baolin.wang@linux.alibaba.com, liam@infradead.org,
nico.pache@linux.dev, ryan.roberts@arm.com, dev.jain@arm.com,
baohua@kernel.org, kasong@tencent.com, hughd@google.com,
balbirs@nvidia.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH] mm/huge_memory: add folio_reset_partially_mapped()
Date: Tue, 8 Sep 2026 14:09:04 +0100 [thread overview]
Message-ID: <aqAIFV4nOGPbWiDS@thinkstation> (raw)
In-Reply-To: <ap_Tjt5vxal-B8DP@gremlin>
On Tue, Sep 08, 2026 at 10:25:07AM +0100, Lorenzo Stoakes (ARM) wrote:
> On Mon, Sep 07, 2026 at 07:33:40PM +0100, Kiryl Shutsemau wrote:
> > Suggested-by: David Hildenbrand (Arm) <david@kernel.org>
> > Assisted-by: Claude-Code:claude-fable-5-1
>
> Note that policy has changed on Assisted-by tags so this should be:
>
> Assisted-by: LLM
I was not aware. Thanks.
Will fix in v2.
> > +static void folio_reset_partially_mapped(struct folio *folio)
> > +{
> > + VM_WARN_ON_FOLIO(folio_ref_count(folio), folio);
>
> NIT: I wonder if we could have a folio_is_frozen() that'd make this
> self-documenting? As trivial as it'd be :)
>
> If not, then a comment like:
>
> /* Folio must be frozen. */
>
> Would be helpful.
There is a series that changes how frozen is encoded and would be the
natural home for such a helper:
https://lore.kernel.org/all/bb1cb750157733f897df2e261cad3d5c42acc172@linux.dev/
The patchset seems to be stuck. Not sure what the plan there. Ilya?
I will go with the comment for v2.
--
Kiryl Shutsemau / Kirill A. Shutemov
next prev parent reply other threads:[~2026-09-08 13:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 18:33 Kiryl Shutsemau
2026-09-07 19:46 ` Zi Yan
2026-09-07 19:57 ` David Hildenbrand (Arm)
2026-09-08 6:06 ` Baolin Wang
2026-09-08 9:25 ` Lorenzo Stoakes (ARM)
2026-09-08 13:09 ` Kiryl Shutsemau [this message]
2026-09-08 13:33 ` Ilya Gladyshev
2026-09-08 11:12 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqAIFV4nOGPbWiDS@thinkstation \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=balbirs@nvidia.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=ilya.gladyshev@linux.dev \
--cc=kasong@tencent.com \
--cc=kernel-team@meta.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=nico.pache@linux.dev \
--cc=ryan.roberts@arm.com \
--cc=usama.arif@linux.dev \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®