mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cristian Marussi <cristian.marussi@arm.com>
To: rolanddreier@rivian.com
Cc: Sudeep Holla <sudeep.holla@kernel.org>,
	Cristian Marussi <cristian.marussi@arm.com>,
	arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Couple of SCMI race fixes
Date: Tue, 8 Sep 2026 16:39:51 +0100	[thread overview]
Message-ID: <aqAsR4tQrtsUZe66@pluto> (raw)
In-Reply-To: <20260814-scmi-async-done-race-v1-0-335b163d77ee@rivian.com>

On Fri, Aug 14, 2026 at 08:15:32PM +0000, Roland Dreier via B4 Relay wrote:
> Noticed a couple of races in SCMI code around delayed responses that
> time out. These are probably nearly impossible to hit in practice but
> the fixes are pretty straightforward and it seems worth having the
> code be sound.

Hi, 

apologies for the delay in this reviews...

Nice hardening work, Sashiko complains about a few unrelated things (of
course :P), there is only probably a good point around the update of
DEBUG_COUNTERS that you added


https://sashiko.dev/#/patchset/20260814-scmi-async-done-race-v1-0-335b163d77ee%40rivian.com

"Will this new counter actually increment for timed-out responses, or will it 
be blocked by earlier validation logic?"

I mean please consider if you can improve the patch only regarding the
DEBUG_COUNTER update (probably moving the update where async_done is now
set to NULL is enough...)

Beside this, look good to me and in my testing everything was fine.

Thanks
Cristian

      parent reply	other threads:[~2026-09-08 15:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14 20:15 Roland Dreier via B4 Relay
2026-08-14 20:15 ` [PATCH 1/2] firmware: arm_scmi: Protect xfer->async_done with xfer->lock Roland Dreier via B4 Relay
2026-08-14 20:15 ` [PATCH 2/2] firmware: arm_scmi: Don't reuse raw xfers with async_done still armed Roland Dreier via B4 Relay
2026-09-08 15:46   ` Cristian Marussi
2026-08-29 17:53 ` [PATCH 0/2] Couple of SCMI race fixes Roland Dreier
2026-09-08 15:39 ` Cristian Marussi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqAsR4tQrtsUZe66@pluto \
    --to=cristian.marussi@arm.com \
    --cc=arm-scmi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rolanddreier@rivian.com \
    --cc=sudeep.holla@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®