On Tue, Sep 08, 2026 at 03:38:00PM -0600, James Hilliard wrote: > On Tue, Sep 8, 2026 at 12:05 PM Conor Dooley wrote: > > > > On Mon, Sep 07, 2026 at 03:03:14PM -0600, James Hilliard wrote: > > > The AC200 is an I2C-controlled mixed-signal companion IC containing > > > audio, video, RTC and Fast Ethernet PHY functions. > > > > > > Describe the shared input clock, audio DAI, TV encoder display graph and > > > optional bandgap calibration in one parent node. The codec and TV encoder > > > do not need separate firmware nodes. > > > > > > AC_LDOIN and TV_VCC are distinct 3.3 V supply inputs. Describe them > > > separately without requiring different external regulators. Require the > > > audio supply when the DAI is described and the video supply when the > > > display graph is present, while allowing PHY-only configurations. > > > > > > Describe the optional shared INTB connection without an internal > > > interrupt domain. Cable detection status remains readable over I2C when > > > INTB is not connected. Include wired and unwired examples. > > > > > > The Ethernet PHY is represented by a PHY package on its MDIO bus, with a > > > phandle back to this device for access to the package control registers. > > > It therefore does not require an MFD child node. The input clock must run > > > at 24 or 27 MHz when the Ethernet PHY is used, matching the rates encoded > > > by its documented clock selector. > > > > > > Signed-off-by: Jernej Skrabec > > > Signed-off-by: James Hilliard > > > > btw, this is kinda odd. Jernej has a signoff, but no other attribution. > > Are they a coauthor missing a Co-developed-by > > I had just retained the existing Signed-off-by from some of his patches > that got incorporated into this one, is using Co-developed-by better > practice for attribution? Should I use both a Co-developed-by and > the Signed-off-by for this sort of thing? Yes, both. Co-developed-by is how you signify that Jernej wrote some of this. Right now, the code is attributed solely to you as the one in the author field of the patch.