From: Peter Rosin <peda@lysator.liu.se>
To: Conor Dooley <conor@kernel.org>
Cc: Shiv Prakash Gupta <shivprakash.gupta@nxp.com>,
andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
vikash.bansal@nxp.com, priyanka.jain@nxp.com
Subject: Re: [PATCH 1/2] dt-bindings: i2c: Add NXP PCA9641 I2C bus master arbiter
Date: Wed, 9 Sep 2026 07:25:38 +0200 [thread overview]
Message-ID: <aqDt0uC7FNRmsv9S@gryt> (raw)
In-Reply-To: <20260908-skirt-makeshift-2050f3bcbb22@spud>
Den Tue, Sep 08, 2026 at 06:47:01PM +0100, skrev Conor Dooley:
> On Tue, Sep 08, 2026 at 06:01:45PM +0530, Shiv Prakash Gupta wrote:
> > Add device tree binding schema for the NXP PCA9641 2-to-1 I2C bus
> > master arbiter.
> >
> > The PCA9641 arbitrates between two upstream I2C masters competing for a
> > single downstream slave bus using a lock/grant ownership model. The
> > binding supports an optional 'interrupts' property for interrupt-assisted
> > arbitration.
> >
> > Signed-off-by: Shiv Prakash Gupta <shivprakash.gupta@nxp.com>
> > ---
...
> > + i2c-arb:
> > + type: object
> > + $ref: /schemas/i2c/i2c-controller.yaml
> > + unevaluatedProperties: false
> > + description:
> > + I2C bus node representing the downstream slave bus controlled by the
> > + PCA9641. Downstream slave devices are declared as child nodes here.
>
> Why does this node need to exist? Can't the i2c-arbiter node itself
> contain the child devices?
For symmetry with the pre-existing I2C arbs, which all have the extra
node for historical implementation reasons? I don't know if that's
considered a valid reason? I prefer to have all arbs follow the same
structure...
The "documentation" describing common I2C arbitration details went missing
here:
https://lore.kernel.org/all/20230731163833.319258-1-krzysztof.kozlowski@linaro.org/
Cheers,
Peter
next prev parent reply other threads:[~2026-09-09 5:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 12:31 [PATCH 0/2] i2c: mux: " Shiv Prakash Gupta
2026-09-08 12:31 ` [PATCH 1/2] dt-bindings: i2c: " Shiv Prakash Gupta
2026-09-08 17:47 ` Conor Dooley
2026-09-09 5:25 ` Peter Rosin [this message]
2026-09-09 10:00 ` Conor Dooley
2026-09-08 12:31 ` [PATCH 2/2] i2c: mux: Add NXP PCA9641 I2C bus master arbiter driver Shiv Prakash Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqDt0uC7FNRmsv9S@gryt \
--to=peda@lysator.liu.se \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=priyanka.jain@nxp.com \
--cc=robh@kernel.org \
--cc=shivprakash.gupta@nxp.com \
--cc=vikash.bansal@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®