mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xu Yilun <yilun.xu@linux.intel.com>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: Xu Yilun <yilun.xu@intel.com>, Moritz Fischer <mdf@kernel.org>,
	Tom Rix <trix@redhat.com>,
	linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] fpga: dfl: Drop #include for <linux/mod_devicetable.h>
Date: Wed, 9 Sep 2026 16:02:09 +0800	[thread overview]
Message-ID: <aqESgYZRJCbN9IV/@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <799c3ffa64d758ffb74f84da492d978a517ff1ba.1787407491.git.ukleinek@kernel.org>

On Sat, Aug 22, 2026 at 04:05:35PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> None of the c files that #include drivers/fpga/dfl.h (either directly or
> via drivers/fpga/dfl-afu.h) actually need <linux/mod_devicetable.h>.
> 
> There is drivers/fpga/dfl-pci.c using pci_device_id, which is provided
> by <linux/pci.h> and drivers/fpga/dfl.c using dfl_device_id which is
> already provided by <linux/dfl.h>. No other structs traditionally
> defined in <linux/mod_devicetable.h> are used by these drivers.
> 
> So the #include can just be dropped.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>

Reviewed-by: Xu Yilun <yilun.xu@intel.com>

Applied to for-next. Thanks.

> ---
>  drivers/fpga/dfl.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
> index 9549f63b00eb..9a65617bb870 100644
> --- a/drivers/fpga/dfl.h
> +++ b/drivers/fpga/dfl.h
> @@ -23,7 +23,6 @@
>  #include <linux/interrupt.h>
>  #include <linux/iopoll.h>
>  #include <linux/io-64-nonatomic-lo-hi.h>
> -#include <linux/mod_devicetable.h>
>  #include <linux/platform_device.h>
>  #include <linux/slab.h>
>  #include <linux/uuid.h>
> 
> base-commit: 903c1cf6dff9964e71eda98a39e2e5d442050472
> -- 
> 2.55.0.11.g153666a7d9bb
> 
> 

      reply	other threads:[~2026-09-09  8:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-22 14:05 Uwe Kleine-König (The Capable Hub)
2026-09-09  8:02 ` Xu Yilun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqESgYZRJCbN9IV/@yilunxu-OptiPlex-7050 \
    --to=yilun.xu@linux.intel.com \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=trix@redhat.com \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®