From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 788C145348D for ; Wed, 9 Sep 2026 09:37:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788946639; cv=none; b=gVMqoOJoavPjAda+zTdY+YGffsIX0ahUXYtljMU0z6aKsvetrzjVMbfFiah+hxDWX+wjY/bPQzi6ALcgMPKxV1yF+21VE2CQMVtujDtNGjApNPbcV/O9u9pDazHuR8nvuw4eMJ9FPLftPJmFuVV//e3D5LoPAW7oDxycCSRXDP4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788946639; c=relaxed/simple; bh=CoR+vQjBubRI4wv3EktisroBpu3v3oIwSCS6EuZEAYs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=bGAH5tvJFXadYS3TwNjNd9Ljp4ymBxcsmq5bDdMgme/J8xeIAwLI5326ksuryko+0GsKW/cfdTA2OQpreEUr/Guc7iBZXAu3D6qd49JWC9+Ce/QBUGmcxNl9gZpau+i4D++UY4HsbL7H/KjvRQd8eZdt1UaAW9J/tteUExN4ch8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=pFt4uUWD; arc=none smtp.client-ip=209.85.128.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="pFt4uUWD" Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-49cdc4080ddso32691175e9.1 for ; Wed, 09 Sep 2026 02:37:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1788946633; x=1789551433; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CoR+vQjBubRI4wv3EktisroBpu3v3oIwSCS6EuZEAYs=; b=pFt4uUWD/uFr9iWectDGs9IfshhdzMdo5NtOOMGPKE1aaWS26gjmqizlUGu9XVo38q eKm5rMzihT59HVAb+7G175cc074xPO6kLP5rzL+A8rTpcx6JO2V6XbZ1AjRSSf5vxEhg iEFdRx+KQ8y9SdyqO5HES+XF6wpBFkU4+CDSuLVtdH0UmilvfQFO+IL/xXhIbCcsBwNX /uafc41c+b+Y60bmNsYAJBnFOiRVff7ibK79ZKWF/Q1DzMPYf66z5TroIvwuYjye43A9 nqiEU1UlM86+9KLZSqcLXnrFUJZFRQ8mk810mIyubG9e2cTEIapi+WFkWRiEUtWOejIc OWZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788946633; x=1789551433; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CoR+vQjBubRI4wv3EktisroBpu3v3oIwSCS6EuZEAYs=; b=aPHg5p+FhDSIeOtP/S6AJV4epaQ31R7W0xB5VZv9NdX86xTlu0gi2eJQS6js7kBuxd NeLCs1Q10nGnwGuQ2Ey1zKKJIxTFlyDv865X1Z4x0sZFFMaMNTIiQ8WaFKsDU9pwWFjh 0XkS3/bhrOrwepvVCXuKaFCsLBzUP2P+UIVtTwTeLONPE2OqWdr8kHjBB7Gh3AhkvttK EDXjJmWoVeWd7QCa2tpkJiV0+/HmYx4m9txF0ZoulV6bPXa6x/+YD7Qpvei+M5TYxCGQ NUp72H/RfpLSRSsHfdRdDnIDU/wqYT/uuyYISiad8a+Vyq+GCxmzcvAi7SiemgSHILEk lhHQ== X-Forwarded-Encrypted: i=1; AKwUvBxOs8YaRyWZUAvYOqKvX8FPGJTend7aPuyVyZmAxisocskcI847rE/awEV3p9yiOliX9gaRNxb3s/BU+tE=@vger.kernel.org X-Gm-Message-State: AFuF++lguf6wLhLExtedC1irsSyzbp/S3ahszEq6RR/bbkO7OKt64Xxf af+WhaH1SHxxiorGqp0HACUtyKJ8RGvNCRhBsp9UoaX7zGGTzy8bkIaUIabM2mw39ueFPKE0Ifm IMHUrScJ2BL+tFg1u1w== X-Received: from wmnu16.prod.google.com ([2002:a05:600c:4410:b0:49c:f5c2:d311]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:1c21:b0:49d:1e79:35d6 with SMTP id 5b1f17b1804b1-49d1e79368dmr64831015e9.14.1788946632676; Wed, 09 Sep 2026 02:37:12 -0700 (PDT) Date: Wed, 9 Sep 2026 09:37:11 +0000 In-Reply-To: <20260826131213.1820408-2-beata.michalska@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260826131213.1820408-1-beata.michalska@arm.com> <20260826131213.1820408-2-beata.michalska@arm.com> Message-ID: Subject: Re: [PATCH v3 1/3] rust: add runtime PM support From: Alice Ryhl To: Beata Michalska Cc: ojeda@kernel.org, dakr@kernel.org, gregkh@linuxfoundation.org, rafael@kernel.org, boqun@kernel.org, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, tmgross@umich.edu, daniel.almeida@collabora.com, boris.brezillon@collabora.com, work@onurozkan.dev, samitolvanen@google.com, acourbot@nvidia.com, rust-for-linux@vger.kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Wed, Aug 26, 2026 at 03:10:55PM +0200, Beata Michalska wrote: > +/// Result type returned by runtime PM callbacks. > +pub type PMCallbackResult = Result, (Option, Error)>; So I think my number one feedback is that it would be really nice to get rid of this Option. > +/// Runtime PM data stored within the `struct device_private' during Should be ` ... ` rather than ' to render correctly in html docs. Alice