From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1526146EF94; Thu, 10 Sep 2026 11:03:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789038221; cv=none; b=MnclnnM/HIr4rMtNZAq7uFbohX/e/PBa80bKSd+VokbjsozLl6zqP+Y1RhGhhXAsT1ZylJojY7ZkELjsRgImE9ZbIo2lxvAD3i51umI37OI9hpeNdWEx28EEJD02kCwrtEE8GOdexBe9ZVXnXYQBZPb3m3UcfbnldfsVLdMKD1g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789038221; c=relaxed/simple; bh=zkF+okllJHqKXvQdM/EqvzsMOtDxyc5TsolTsb/xGl8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SoMb6Y2JMk0VlvExEyH/+KhFf4RDVlYp8m0nYHMLrUvE53+MqUF8nTsSaXzjVW6F3Fjk8F5TeBPCMPeL1sdXcxHcS8ZwoUBl3OrsgNSYqgZo89lUfILL8Wad+8Ijc/1n90BvTk+p0wDtIWmn94sxUSex+6GmsIQZ6C/OGgH44q0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cuxcQ5jw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cuxcQ5jw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72CBB1F000FF; Thu, 10 Sep 2026 11:03:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789038220; bh=zkF+okllJHqKXvQdM/EqvzsMOtDxyc5TsolTsb/xGl8=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=cuxcQ5jw3m5rzCB46cgEUCPdWQH2FZQJvP80czAO5zYsV5hzlkMBwq353jvE2+SlC EsOH7NRCi1jSQHG6KMUX9oKr38OlGyWcmfsrMYJdAMof2w+IP2n77ZzKB/cQdOS0KB DS551N6VCg1Gix5tUP72Eds63nkBcKhfHqCXzqGsy0xp2QnF9vMCnGWQWtmO6qy+hf /lJ2rvjRJpWW4OJ9D/XkL/CSnsj/ERj2S/Dv6ruCjs73ckc+cRSd9WPcpsHnocp49K z1e05dQ+uMCNuRgf8Y0N2ZWNxMdpYiM1JsjE8gxntujzUZ+EHS1CIM+MFUPb0K9szo rJGQeSQbm3XLQ== Date: Thu, 10 Sep 2026 12:03:25 +0100 From: "Lorenzo Stoakes (ARM)" To: Nathan Chancellor Cc: Linus Torvalds , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , Masahiro Yamada , Alexey Gladkov , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Arnd Bergmann , Catalin Marinas , Will Deacon , Mark Rutland , Ard Biesheuvel , Ilias Apalodimas , Josh Poimboeuf , Peter Zijlstra , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?B?QmrDtnJu?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , Onur =?utf-8?B?w5Z6a2Fu?= , Jonathan Corbet , Randy Dunlap , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-doc@vger.kernel.org, Jens Axboe Subject: Re: [PATCH 01/23] scripts/mksysmap: drop the MODULE_INFO() symbols from kallsyms Message-ID: References: <20260908-build-speedup-v1-0-5dc1ac01672d@kernel.org> <20260908-build-speedup-v1-1-5dc1ac01672d@kernel.org> <178901395288.3971858.7586978173036863863.b4-review@b4> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <178901395288.3971858.7586978173036863863.b4-review@b4> On Wed, Sep 09, 2026 at 09:19:12PM -0700, Nathan Chancellor wrote: > > Commit 3e86e4d74c04 ("kbuild: keep .modinfo section in vmlinux.unstripped") > > keeps .modinfo symbols out of System.map and kallsyms, which assumes unique > > IDs have a format like '__UNIQUE_ID_modinfo123'. > > > > However, commit afb026b6d35c ("compiler: Tweak __UNIQUE_ID() naming"), sent > > in the same cycle, changes this to '__UNIQUE_ID_modinfo_123'. > > > > As a result this regexp has never matched and every kernel since v6.18 has > > carried one kallsyms entries for every MODULE_INFO() declaration in the > > kernel whether the modules are compiled or not. > > > > That's 5,810 entries for an x86 defconfig build and 15,200 for arm64. > > > > On x86 defconfig that is 113 KiB of kallsyms tables and 32 KiB of bzImage, > > and every lookup walks past them. > > Bummer :/ Yeah super easy to miss though I think! > > > Fix the pattern. > > > > Fixes: 3e86e4d74c04 ("kbuild: keep .modinfo section in vmlinux.unstripped") > > > > No measurable change in build time, the smaller tables are not on any path > > the build waits for. > > I don't think this needs to be in the commit message, it could be below > the fold, since it appears to be a valid fix on its own. Agree with > Nicolas on adjusting the Fixes tag. Ack yeah I screwed this bit up sorry! > > Is this worth Cc'ing stable for? Yeah I wasn't sure, it's not like it breaks anything but you see stuff in kallsyms that you shouldn't. So I'd say probably on balance yes we should actually? > > > Assisted-by: LLM > > Signed-off-by: Lorenzo Stoakes (ARM) > > Reviewed-by: Nathan Chancellor Thanks! > > -- > Cheers, > Nathan > -- Cheers, Lorenzo