From: "Uwe Kleine-König" <ukleinek@kernel.org>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>
Cc: Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-pwm@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pwm: tegra: fail probe on reset deassert errors
Date: Thu, 10 Sep 2026 16:34:14 +0200 [thread overview]
Message-ID: <aqK_pBOW9xkY6iz4@monoceros> (raw)
In-Reply-To: <20260830125843.99132-1-pengpeng@iscas.ac.cn>
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
Hello,
On Sun, Aug 30, 2026 at 08:58:43PM +0800, Pengpeng Hou wrote:
> diff --git a/drivers/pwm/pwm-tegra.c b/drivers/pwm/pwm-tegra.c
> index 5cdbe120ba2d8..d9fa16a7b31f4 100644
> --- a/drivers/pwm/pwm-tegra.c
> +++ b/drivers/pwm/pwm-tegra.c
> @@ -379,7 +379,9 @@ static int tegra_pwm_probe(struct platform_device *pdev)
> goto put_pm;
> }
>
> - reset_control_deassert(pc->rst);
> + ret = reset_control_deassert(pc->rst);
> + if (ret)
> + goto put_pm;
Alternatively use devm_reset_control_get_exclusive_deasserted() instead
of devm_reset_control_get_exclusive().
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-09-10 14:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-30 12:58 Pengpeng Hou
2026-09-10 14:34 ` Uwe Kleine-König [this message]
2026-09-11 10:43 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqK_pBOW9xkY6iz4@monoceros \
--to=ukleinek@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pengpeng@iscas.ac.cn \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®