From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E60C7466B57; Thu, 10 Sep 2026 15:55:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789055709; cv=none; b=si8VwDzDYUwNxDTJlJAz/1Ov57rtwcloA4cDa9cSj6uuCUFGU7YQCYqqddkGVseCC3pKcoB8O/DFzB2Tecarcgr7teL1rZXygew8umQ84ps6K/HLsoop1X5guJYq0LFFhWSg5bxkEkP8w+OqP426WxXbYQ9kXaVTjHxgpbkZ2iU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789055709; c=relaxed/simple; bh=sp8imCTOBcsTqjv3qIhVBVtjF2bZuc5nSVHShV7Cfxo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sXr9SFrM+eGQegJfpdDKJzjZk7gC27VDaOdSbqn7FJ+Sq1viI1C78E/BbDRLkPUvjs7USvTWOnrZ94ZBa4iVxjeNxL52zgzrQFK7cig9CqdTL86LnJeoZ+Lmm7SA6x6Pb3WUTwqL1Riqx7EfUrmQft49eZ+krPvzzokJYFSSwjg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PVMAbNdo; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PVMAbNdo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 558CA1F000FF; Thu, 10 Sep 2026 15:55:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789055707; bh=cCQuPsQnnzWEfQqM8qoVptc5zhfCzwmt8mzzfIKqMeM=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=PVMAbNdo6ndFhaKlzN77NDHXZPrv+vd6y4nx1+MGaOXxACAoPKUHPnKPwSXQoiqx0 DjDEtoTeXwD25745NTh8ThVCvdtTTWKe59/wWEbjV65Gnq2Yw/gXqDMzSV1IMHthOW zes7KPkTEznMFZ0ws0G9RfdbSz8jQvgbmajCj7a+fyrf+iRqZtdm6unx+Sk4DwA8fw 6o5K9XRghRJN2yTWFCXZoD9ULIbIPFqUVPI5Go0yrYwXVpIIkBqM5WIcWrLRaBMeMA yklWF0PiNyvBqyrCBOw78AXla6+tpTENhVJP6K2cg7Ft9ShY9PIVKzvT451D6wfsqN NwY0Am3M80uDg== Date: Thu, 10 Sep 2026 16:55:01 +0100 From: "Lorenzo Stoakes (ARM)" To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, liam@infradead.org, vbabka@kernel.org, david@redhat.com, willy@infradead.org, jannh@google.com, paulmck@kernel.org, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 2/5] proc/task_mmu: remove unnecessary inlines in function definitions Message-ID: References: <20260907063918.3432401-1-surenb@google.com> <20260907063918.3432401-3-surenb@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260907063918.3432401-3-surenb@google.com> On Sun, Sep 06, 2026 at 11:39:15PM -0700, Suren Baghdasaryan wrote: > It was pointed out in the previous reviews of this code that many > functions are specified as inline, which is unnecessary as the compile > can make that decision by itself. Cleanup these definitions. > > No functional change intended. > > Signed-off-by: Suren Baghdasaryan Yes :) Nice, thanks! Reviewed-by: Lorenzo Stoakes (ARM) > --- > fs/proc/task_mmu.c | 32 ++++++++++++++++---------------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 2f500d639db5..9908ba32f180 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -130,7 +130,7 @@ static void release_task_mempolicy(struct proc_maps_private *priv) > } > #endif > > -static inline int lock_ctx_mm(struct proc_maps_locking_ctx *lock_ctx) > +static int lock_ctx_mm(struct proc_maps_locking_ctx *lock_ctx) > { > int ret = mmap_read_lock_killable(lock_ctx->mm); > > @@ -140,7 +140,7 @@ static inline int lock_ctx_mm(struct proc_maps_locking_ctx *lock_ctx) > return ret; > } > > -static inline void unlock_ctx_mm(struct proc_maps_locking_ctx *lock_ctx) > +static void unlock_ctx_mm(struct proc_maps_locking_ctx *lock_ctx) > { > mmap_read_unlock(lock_ctx->mm); > lock_ctx->mmap_locked = false; > @@ -177,7 +177,7 @@ static struct vm_area_struct *get_next_vma(struct proc_maps_private *priv, > return vma; > } > > -static inline bool fallback_to_mmap_lock(struct proc_maps_private *priv, > +static bool fallback_to_mmap_lock(struct proc_maps_private *priv, > loff_t pos) > { > struct proc_maps_locking_ctx *lock_ctx = &priv->lock_ctx; > @@ -194,7 +194,7 @@ static inline bool fallback_to_mmap_lock(struct proc_maps_private *priv, > return true; > } > > -static inline void drop_rcu(struct proc_maps_private *priv) > +static void drop_rcu(struct proc_maps_private *priv) > { > if (priv->lock_ctx.mmap_locked) > return; > @@ -202,7 +202,7 @@ static inline void drop_rcu(struct proc_maps_private *priv) > rcu_read_unlock(); > } > > -static inline void reacquire_rcu(struct proc_maps_private *priv) > +static void reacquire_rcu(struct proc_maps_private *priv) > { > if (priv->lock_ctx.mmap_locked) > return; > @@ -1230,7 +1230,7 @@ static const struct mm_walk_ops smaps_shmem_walk_vma_lock_ops = { > .walk_lock = PGWALK_VMA_RDLOCK_VERIFY, > }; > > -static inline const struct mm_walk_ops * > +static const struct mm_walk_ops * > get_smaps_walk_ops(struct proc_maps_private *priv) > { > if (priv->lock_ctx.mmap_locked) > @@ -1238,7 +1238,7 @@ get_smaps_walk_ops(struct proc_maps_private *priv) > return &smaps_walk_vma_lock_ops; > } > > -static inline const struct mm_walk_ops * > +static const struct mm_walk_ops * > get_smaps_shmem_walk_ops(struct proc_maps_private *priv) > { > if (priv->lock_ctx.mmap_locked) > @@ -1572,7 +1572,7 @@ struct clear_refs_private { > enum clear_refs_types type; > }; > > -static inline bool pte_is_pinned(struct vm_area_struct *vma, unsigned long addr, pte_t pte) > +static bool pte_is_pinned(struct vm_area_struct *vma, unsigned long addr, pte_t pte) > { > struct folio *folio; > > @@ -1588,8 +1588,8 @@ static inline bool pte_is_pinned(struct vm_area_struct *vma, unsigned long addr, > return folio_maybe_dma_pinned(folio); > } > > -static inline void clear_soft_dirty(struct vm_area_struct *vma, > - unsigned long addr, pte_t *pte) > +static void clear_soft_dirty(struct vm_area_struct *vma, unsigned long addr, > + pte_t *pte) > { > if (!pgtable_supports_soft_dirty()) > return; > @@ -1620,8 +1620,8 @@ static inline void clear_soft_dirty(struct vm_area_struct *vma, > } > > #if defined(CONFIG_TRANSPARENT_HUGEPAGE) > -static inline void clear_soft_dirty_pmd(struct vm_area_struct *vma, > - unsigned long addr, pmd_t *pmdp) > +static void clear_soft_dirty_pmd(struct vm_area_struct *vma, > + unsigned long addr, pmd_t *pmdp) > { > pmd_t old, pmd = *pmdp; > > @@ -1646,8 +1646,8 @@ static inline void clear_soft_dirty_pmd(struct vm_area_struct *vma, > } > } > #else > -static inline void clear_soft_dirty_pmd(struct vm_area_struct *vma, > - unsigned long addr, pmd_t *pmdp) > +static void clear_soft_dirty_pmd(struct vm_area_struct *vma, > + unsigned long addr, pmd_t *pmdp) > { > } > #endif > @@ -1846,7 +1846,7 @@ struct pagemapread { > > #define PM_END_OF_BUFFER 1 > > -static inline pagemap_entry_t make_pme(u64 frame, u64 flags) > +static pagemap_entry_t make_pme(u64 frame, u64 flags) > { > return (pagemap_entry_t) { .pme = (frame & PM_PFRAME_MASK) | flags }; > } > @@ -3388,7 +3388,7 @@ static const struct mm_walk_ops show_numa_vma_lock_ops = { > .walk_lock = PGWALK_VMA_RDLOCK_VERIFY, > }; > > -static inline const struct mm_walk_ops * > +static const struct mm_walk_ops * > get_show_numa_ops(struct proc_maps_private *priv) > { > if (priv->lock_ctx.mmap_locked) > -- > 2.55.0.979.g7e5102b832-goog > -- Cheers, Lorenzo