mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Frank Li <Frank.Li@nxp.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	Emanuele Ghidoli <emanuele.ghidoli@toradex.com>,
	Ernest Van Hoecke <ernest.vanhoecke@toradex.com>,
	Franz Schnyder <franz.schnyder@toradex.com>
Subject: Re: [PATCH v1 3/7] arm64: dts: freescale: Add Lino iMX93
Date: Thu, 10 Sep 2026 11:04:26 -0500	[thread overview]
Message-ID: <aqLVCq9NMk67fqPY@SMW015318> (raw)
In-Reply-To: <20260910101616.139270-4-francesco@dolcini.it>

On Thu, Sep 10, 2026 at 12:16:09PM +0200, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
>
> Add support for the Lino iMX93 SoM, its Verdin adapter and development
> carrier board.
>
> The SoM is available in two variants, with i.MX91 or i.MX93 SoC, using
> the same PCB (the two chips are pin to pin compatible), to avoid
> duplication create a common dtsi to share commonalities.
>
...
> +};
> +
> +&gpio1 {
> +	gpio-line-names =
> +		"LINO_P18",
> +		"LINO_P16",
> +		"PMIC_I2C_SCL",
> +		"PMIC_I2C_SDA",
> +		"",
> +		"",
> +		"",
> +		"",
> +		"",
> +		"",
> +		"LINO_P65", /* 10 */
> +		"LINO_S18",
> +		"LINO_S24",
> +		"LINO_S20",
> +		"LINO_S22",
> +		"";

Can you wrap, 4 pin pre one line to reduce LOC.

> +};
> +
...
> +
> +/* Lino I2C_1 */
> +&lpi2c1 {
> +	pinctrl-names = "default", "gpio";
> +	pinctrl-0 = <&pinctrl_i2c1>;
> +	pinctrl-1 = <&pinctrl_i2c1_gpio>;
> +	#address-cells = <1>;
> +	#size-cells = <0>;

common dtsi should already set #address-cells and #size-cells, can be
removed, please check others.

Frank

  reply	other threads:[~2026-09-10 16:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10 10:16 [PATCH v1 0/7] arm64: dts: freescale: Add Toradex Lino and OSM iMX91/iMX93 Francesco Dolcini
2026-09-10 10:16 ` [PATCH v1 1/7] dt-bindings: arm: fsl: Add Lino iMX91/iMX93 Francesco Dolcini
2026-09-11  8:47   ` Krzysztof Kozlowski
2026-09-10 10:16 ` [PATCH v1 2/7] dt-bindings: arm: fsl: Add Toradex OSM iMX91/iMX93 Francesco Dolcini
2026-09-11  8:47   ` Krzysztof Kozlowski
2026-09-10 10:16 ` [PATCH v1 3/7] arm64: dts: freescale: Add Lino iMX93 Francesco Dolcini
2026-09-10 16:04   ` Frank Li [this message]
2026-09-10 16:10     ` Francesco Dolcini
2026-09-10 10:16 ` [PATCH v1 4/7] arm64: dts: freescale: imx93-lino: Add dahlia Francesco Dolcini
2026-09-10 10:16 ` [PATCH v1 5/7] arm64: dts: freescale: Add Lino iMX91 Francesco Dolcini
2026-09-10 10:16 ` [PATCH v1 6/7] arm64: dts: freescale: Add Toradex OSM iMX93 Francesco Dolcini
2026-09-10 10:16 ` [PATCH v1 7/7] arm64: dts: freescale: Add Toradex OSM iMX91 Francesco Dolcini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqLVCq9NMk67fqPY@SMW015318 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=emanuele.ghidoli@toradex.com \
    --cc=ernest.vanhoecke@toradex.com \
    --cc=festevam@gmail.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=francesco@dolcini.it \
    --cc=franz.schnyder@toradex.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®