mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: Ernest Van Hoecke <ernestvanhoecke@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Frank Li <Frank.Li@nxp.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
Subject: Re: [PATCH 4/6] arm64: dts: freescale: imx8m{m,p}-verdin: Add camera connector nexus
Date: Thu, 10 Sep 2026 11:31:54 -0500	[thread overview]
Message-ID: <aqLbeo5L83QH9OQK@SMW015318> (raw)
In-Reply-To: <20260910-verdin-imx8mp-hmp-camera-ready-v1-4-3c9349ecdb9f@toradex.com>

On Thu, Sep 10, 2026 at 05:38:00PM +0200, Ernest Van Hoecke wrote:
> From: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
>
> The Verdin Development Board, Dahlia and Mallow expose the same 24-pin CSI
> camera connector, while Verdin iMX8M Mini and Verdin iMX8M Plus route its
> sideband signals and media pipeline through different SoC resources.
>
> Add a GPIO nexus to each carrier description and stable Verdin-level labels
> for each module's CSI_1 I2C bus, receiver and capture engine. Keeping the
> nexus in the carrier files avoids describing the physical connector on
> carriers which do not provide it.
>
> This gives accessory overlays a stable connector and media interface
> without embedding either module's wiring in the accessory description.
>
> Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
> ---

Nice, thank for your efforts.

Frank

>  arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi | 17 +++++++++++++++++
>  arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi    | 17 +++++++++++++++++
>  arch/arm64/boot/dts/freescale/imx8mm-verdin-mallow.dtsi | 17 +++++++++++++++++
>  arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi        |  8 +++++++-
>  arch/arm64/boot/dts/freescale/imx8mp-verdin-dahlia.dtsi | 17 +++++++++++++++++
>  arch/arm64/boot/dts/freescale/imx8mp-verdin-dev.dtsi    | 17 +++++++++++++++++
>  arch/arm64/boot/dts/freescale/imx8mp-verdin-mallow.dtsi | 17 +++++++++++++++++
>  arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi        |  7 ++++++-
>  8 files changed, 115 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi
> index 3d0b14968131..4cf77559e69b 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi
> @@ -4,6 +4,23 @@
>   */
>
>  / {
> +	verdin_camera_connector: camera-connector-0 {
> +		compatible = "toradex,camera-connector";
> +		#gpio-cells = <2>;
> +		/*
> +		 * CAM_1_CON_RST       (pin 11) - Verdin GPIO_5 (SODIMM 216)
> +		 * CAM_1_CON_PWRDWN    (pin 22) - Verdin GPIO_6 (SODIMM 218)
> +		 * CAM_1_CON_IC_DETECT (pin 23) - Verdin GPIO_7 (SODIMM 220)
> +		 * CAM_1_CON_PWRCTRL   (pin 24) - Verdin GPIO_8 (SODIMM 222)
> +		 */
> +		gpio-map = <0 0 &gpio1 0 GPIO_ACTIVE_HIGH>,
> +			   <1 0 &gpio1 11 GPIO_ACTIVE_HIGH>,
> +			   <2 0 &gpio1 8 GPIO_ACTIVE_HIGH>,
> +			   <3 0 &gpio1 9 GPIO_ACTIVE_HIGH>;
> +		gpio-map-mask = <0xffffffff 0x0>;
> +		gpio-map-pass-thru = <0x0 0xffffffff>;
> +	};
> +
>  	sound_card: sound-card {
>  		compatible = "simple-audio-card";
>  		simple-audio-card,bitclock-master = <&dailink_master>;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi
> index 1d8d146d9eeb..51a836324c16 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi
> @@ -4,6 +4,23 @@
>   */
>
>  / {
> +	verdin_camera_connector: camera-connector-0 {
> +		compatible = "toradex,camera-connector";
> +		#gpio-cells = <2>;
> +		/*
> +		 * CAM_1_CON_RST       (pin 11) - Verdin GPIO_5 (SODIMM 216)
> +		 * CAM_1_CON_PWRDWN    (pin 22) - Verdin GPIO_6 (SODIMM 218)
> +		 * CAM_1_CON_IC_DETECT (pin 23) - Verdin GPIO_7 (SODIMM 220)
> +		 * CAM_1_CON_PWRCTRL   (pin 24) - Verdin GPIO_8 (SODIMM 222)
> +		 */
> +		gpio-map = <0 0 &gpio1 0 GPIO_ACTIVE_HIGH>,
> +			   <1 0 &gpio1 11 GPIO_ACTIVE_HIGH>,
> +			   <2 0 &gpio1 8 GPIO_ACTIVE_HIGH>,
> +			   <3 0 &gpio1 9 GPIO_ACTIVE_HIGH>;
> +		gpio-map-mask = <0xffffffff 0x0>;
> +		gpio-map-pass-thru = <0x0 0xffffffff>;
> +	};
> +
>  	sound_card: sound-card {
>  		compatible = "simple-audio-card";
>  		simple-audio-card,bitclock-master = <&dailink_master>;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin-mallow.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin-mallow.dtsi
> index 4a0799d63446..5951cd19a84c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin-mallow.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin-mallow.dtsi
> @@ -11,6 +11,23 @@
>  #include <dt-bindings/leds/common.h>
>
>  / {
> +	verdin_camera_connector: camera-connector-0 {
> +		compatible = "toradex,camera-connector";
> +		#gpio-cells = <2>;
> +		/*
> +		 * CAM_1_CON_RST       (pin 11) - Verdin GPIO_5 (SODIMM 216)
> +		 * CAM_1_CON_PWRDWN    (pin 22) - Verdin GPIO_6 (SODIMM 218)
> +		 * CAM_1_CON_IC_DETECT (pin 23) - Verdin GPIO_7 (SODIMM 220)
> +		 * CAM_1_CON_PWRCTRL   (pin 24) - Verdin GPIO_8 (SODIMM 222)
> +		 */
> +		gpio-map = <0 0 &gpio1 0 GPIO_ACTIVE_HIGH>,
> +			   <1 0 &gpio1 11 GPIO_ACTIVE_HIGH>,
> +			   <2 0 &gpio1 8 GPIO_ACTIVE_HIGH>,
> +			   <3 0 &gpio1 9 GPIO_ACTIVE_HIGH>;
> +		gpio-map-mask = <0xffffffff 0x0>;
> +		gpio-map-pass-thru = <0x0 0xffffffff>;
> +	};
> +
>  	leds {
>  		compatible = "gpio-leds";
>  		pinctrl-names = "default";
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> index ac450fc6cbfb..5c72b279d506 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> @@ -224,6 +224,9 @@ &cpu_crit0 {
>  	temperature = <105000>;
>  };
>
> +/* Verdin CSI_1 */
> +verdin_csi_capture: &csi {};
> +
>  &ddrc {
>  	operating-points-v2 = <&ddrc_opp_table>;
>
> @@ -596,7 +599,7 @@ &i2c2 {
>  /* Verdin I2C_3_HDMI N/A */
>
>  /* Verdin I2C_4_CSI */
> -&i2c3 {
> +verdin_csi_i2c: &i2c3 {
>  	clock-frequency = <400000>;
>  	pinctrl-names = "default", "gpio";
>  	pinctrl-0 = <&pinctrl_i2c3>;
> @@ -695,6 +698,9 @@ eeprom_carrier_board: eeprom@57 {
>  	};
>  };
>
> +/* Verdin CSI_1 */
> +verdin_csi_rx: &mipi_csi {};
> +
>  /* Verdin PCIE_1 */
>  &pcie0 {
>  	assigned-clocks = <&clk IMX8MM_CLK_PCIE1_AUX>,
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin-dahlia.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin-dahlia.dtsi
> index 0e218e6b8e29..164031d5dd86 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin-dahlia.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin-dahlia.dtsi
> @@ -4,6 +4,23 @@
>   */
>
>  / {
> +	verdin_camera_connector: camera-connector-0 {
> +		compatible = "toradex,camera-connector";
> +		#gpio-cells = <2>;
> +		/*
> +		 * CAM_1_CON_RST       (pin 11) - Verdin GPIO_5 (SODIMM 216)
> +		 * CAM_1_CON_PWRDWN    (pin 22) - Verdin GPIO_6 (SODIMM 218)
> +		 * CAM_1_CON_IC_DETECT (pin 23) - Verdin GPIO_7 (SODIMM 220)
> +		 * CAM_1_CON_PWRCTRL   (pin 24) - Verdin GPIO_8 (SODIMM 222)
> +		 */
> +		gpio-map = <0 0 &gpio1 7 GPIO_ACTIVE_HIGH>,
> +			   <1 0 &gpio1 8 GPIO_ACTIVE_HIGH>,
> +			   <2 0 &gpio4 3 GPIO_ACTIVE_HIGH>,
> +			   <3 0 &gpio4 1 GPIO_ACTIVE_HIGH>;
> +		gpio-map-mask = <0xffffffff 0x0>;
> +		gpio-map-pass-thru = <0x0 0xffffffff>;
> +	};
> +
>  	native-hdmi-connector {
>  		compatible = "hdmi-connector";
>  		label = "X21";
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin-dev.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin-dev.dtsi
> index 72a4f846d694..c52e46738110 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin-dev.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin-dev.dtsi
> @@ -4,6 +4,23 @@
>   */
>
>  / {
> +	verdin_camera_connector: camera-connector-0 {
> +		compatible = "toradex,camera-connector";
> +		#gpio-cells = <2>;
> +		/*
> +		 * CAM_1_CON_RST       (pin 11) - Verdin GPIO_5 (SODIMM 216)
> +		 * CAM_1_CON_PWRDWN    (pin 22) - Verdin GPIO_6 (SODIMM 218)
> +		 * CAM_1_CON_IC_DETECT (pin 23) - Verdin GPIO_7 (SODIMM 220)
> +		 * CAM_1_CON_PWRCTRL   (pin 24) - Verdin GPIO_8 (SODIMM 222)
> +		 */
> +		gpio-map = <0 0 &gpio1 7 GPIO_ACTIVE_HIGH>,
> +			   <1 0 &gpio1 8 GPIO_ACTIVE_HIGH>,
> +			   <2 0 &gpio4 3 GPIO_ACTIVE_HIGH>,
> +			   <3 0 &gpio4 1 GPIO_ACTIVE_HIGH>;
> +		gpio-map-mask = <0xffffffff 0x0>;
> +		gpio-map-pass-thru = <0x0 0xffffffff>;
> +	};
> +
>  	native-hdmi-connector {
>  		compatible = "hdmi-connector";
>  		label = "X37";
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin-mallow.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin-mallow.dtsi
> index 846b36706821..b915fbbd04b6 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin-mallow.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin-mallow.dtsi
> @@ -11,6 +11,23 @@
>  #include <dt-bindings/leds/common.h>
>
>  / {
> +	verdin_camera_connector: camera-connector-0 {
> +		compatible = "toradex,camera-connector";
> +		#gpio-cells = <2>;
> +		/*
> +		 * CAM_1_CON_RST       (pin 11) - Verdin GPIO_5 (SODIMM 216)
> +		 * CAM_1_CON_PWRDWN    (pin 22) - Verdin GPIO_6 (SODIMM 218)
> +		 * CAM_1_CON_IC_DETECT (pin 23) - Verdin GPIO_7 (SODIMM 220)
> +		 * CAM_1_CON_PWRCTRL   (pin 24) - Verdin GPIO_8 (SODIMM 222)
> +		 */
> +		gpio-map = <0 0 &gpio1 7 GPIO_ACTIVE_HIGH>,
> +			   <1 0 &gpio1 8 GPIO_ACTIVE_HIGH>,
> +			   <2 0 &gpio4 3 GPIO_ACTIVE_HIGH>,
> +			   <3 0 &gpio4 1 GPIO_ACTIVE_HIGH>;
> +		gpio-map-mask = <0xffffffff 0x0>;
> +		gpio-map-pass-thru = <0x0 0xffffffff>;
> +	};
> +
>  	native-hdmi-connector {
>  		compatible = "hdmi-connector";
>  		label = "X14";
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> index 45a4713c260f..53499289cf61 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> @@ -719,7 +719,7 @@ atmel_mxt_ts_mezzanine: touch-mezzanine@4a {
>  };
>
>  /* Verdin I2C_4_CSI */
> -&i2c3 {
> +verdin_csi_i2c: &i2c3 {
>  	clock-frequency = <400000>;
>  	pinctrl-names = "default", "gpio";
>  	pinctrl-0 = <&pinctrl_i2c3>;
> @@ -829,6 +829,11 @@ &i2c5 {
>  	single-master;
>  };
>
> +/* Verdin CSI_1 */
> +verdin_csi_capture: &isi_0 {};
> +
> +verdin_csi_rx: &mipi_csi_0 {};
> +
>  /* Verdin PCIE_1 */
>  &pcie {
>  	pinctrl-names = "default";
>
> --
> 2.43.0
>
>

  reply	other threads:[~2026-09-10 16:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10 15:37 [PATCH 0/6] arm64: dts: freescale: Add Verdin iMX8M OV5640 and Verdin iMX8MP M7 support Ernest Van Hoecke
2026-09-10 15:37 ` [PATCH 1/6] arm64: dts: freescale: imx8mp-verdin: Add Cortex-M7 remoteproc Ernest Van Hoecke
2026-09-10 15:37 ` [PATCH 2/6] arm64: dts: freescale: imx8mp-verdin: Add Cortex-M7 UART_4 overlay Ernest Van Hoecke
2026-09-10 15:37 ` [PATCH 3/6] dt-bindings: connector: Add Toradex camera connector Ernest Van Hoecke
2026-09-10 16:26   ` Frank Li
2026-09-10 16:39     ` Ernest Van Hoecke
2026-09-10 17:01       ` Frank Li
2026-09-10 17:12         ` Francesco Dolcini
2026-09-10 18:38           ` Frank Li
2026-09-10 15:38 ` [PATCH 4/6] arm64: dts: freescale: imx8m{m,p}-verdin: Add camera connector nexus Ernest Van Hoecke
2026-09-10 16:31   ` Frank Li [this message]
2026-09-10 15:38 ` [PATCH 5/6] arm64: dts: freescale: imx8m{m,p}-verdin: Add shared OV5640 overlays Ernest Van Hoecke
2026-09-10 15:38 ` [PATCH 6/6] arm64: dts: freescale: imx8mp-verdin: Add mezzanine " Ernest Van Hoecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqLbeo5L83QH9OQK@SMW015318 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ernest.vanhoecke@toradex.com \
    --cc=ernestvanhoecke@gmail.com \
    --cc=festevam@gmail.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®