From: Michael Zavertkin <misha.zavertkin@mail.ru>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sander Vanheule <sander@svanheule.net>,
Bert Vermeulen <bert@biot.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] gpio: realtek-otto: add pinctrl support
Date: Fri, 11 Sep 2026 04:29:33 +0700 [thread overview]
Message-ID: <aqMhPQpDPJ_J7n1V@gamepc> (raw)
In-Reply-To: <CAMRc=MfTTZKBRPGWi3Bu8n3V0y6TN6TR0izdxZ=Zt0mM2eN+_g@mail.gmail.com>
On Thu, Sep 10, 2026 at 02:11:51AM -0700, Bartosz Golaszewski wrote:
> On Wed, 2 Sep 2026 15:02:01 +0200, Michael Zavertkin
> <misha.zavertkin@mail.ru> said:
> > On Wed, Sep 02, 2026 at 11:27:50AM +0200, Bartosz Golaszewski wrote:
> >> On Thu, Aug 27, 2026 at 4:29 PM Michael Zavertkin
> >> <misha.zavertkin@mail.ru> wrote:
> >> >
> >> > RTL9607C relies on pinctrl to mux SoC pins. Use pinctrl to request pins
> >> > for GPIO.
> >> > pinctrl driver for other SoCs might be implemented later.
> >> >
> >>
> >> So for now shouldn't you make it conditional on the compatible for
> >> this one model?
> >>
> >> Bart
> >
> > It might, but enabling it for all will spare time if/when pin
> > controllers for other SoCs will be implemented. And it doesn't change
> > anything if pinctrl not enabled/provided for them.
> >
> >
>
> Sashiko claims otherwise[1] so I had a look and it seems to me that it's
> correct saying we'll defer indefinitely for GPIO chips not backed by a pin
> controller.
>
> Bart
>
> [1] https://sashiko.dev/#/patchset/cover.1787830440.git.misha.zavertkin%40mail.ru
Already addressed: https://patch.msgid.link/20260820-fix-gpio-mmio-pinctrl-v1-1-62c2d7dd4903@kernel.org
Tried it myself, without that patch infinite defers happens if no
pinctrl provided. After patch applied probe loop doesn't happen.
next prev parent reply other threads:[~2026-09-10 21:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 14:29 [PATCH v4 0/2] " Michael Zavertkin
2026-08-27 14:29 ` [PATCH v4 1/2] dt-bindings: gpio: otto-gpio: Add gpio-ranges Michael Zavertkin
2026-09-01 7:50 ` Krzysztof Kozlowski
2026-09-14 9:16 ` Linus Walleij
2026-08-27 14:29 ` [PATCH v4 2/2] gpio: realtek-otto: add pinctrl support Michael Zavertkin
2026-09-02 9:27 ` Bartosz Golaszewski
2026-09-02 13:02 ` Michael Zavertkin
2026-09-10 9:11 ` Bartosz Golaszewski
2026-09-10 21:29 ` Michael Zavertkin [this message]
2026-09-14 8:38 ` [PATCH v4 0/2] " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqMhPQpDPJ_J7n1V@gamepc \
--to=misha.zavertkin@mail.ru \
--cc=bert@biot.com \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sander@svanheule.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®