Re: [PATCH] mmc: vub300: fix sleeping function call from invalid context in vub300_inactivity_timer_expired

[Johan Hovold <johan@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]

On Wed, Sep 09, 2026 at 07:24:46PM +0200, Wolfram Sang wrote:
> 
> > > > Sure, but should you be scheduling rescan work before all resources have
> > > > been set up and the host has been registered?
> > > 
> > > I would like to defer that question to the TMIO experts.
> 
> From a high level view, independently of TMIO/SDHI...
> 
> > Are they on CC?
> > 
> > Ulf, perhaps you can take a look at this? It seems wrong to enable
> > interrupts and trigger rescans before the host controller has been set
> > up and registered.
> 
> ... it is always a good practice to enable irqs only when the device is
> fully set up. From a glimpse, this seems to be the case here as well.
> 
> It needs serious testing, though. SDHI is a complex, organically grown
> mass of code. There might be subtle side effects. It should still be
> worth it IMO. I can put it on my todo list, but no promises...

Thanks for taking a look. I guess we should fix this inconsistency in
MMC core eventually, but that the vub300 needs to be reworked to handle
this quirk in the mean time.

If only to stop the flood of LLM generated fixes to the syzbot report...

Johan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 265 bytes --]