From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: "David Lechner (TI)" <dlechner@baylibre.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>, "Chris Hall" <c-hall@ti.com>,
"Patrick Edwards" <pedwards@ti.com>,
"Kurt Borja" <kuurtb@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 06/10] iio: adc: ti-ads112c14: support external clock
Date: Fri, 11 Sep 2026 12:16:28 +0300 [thread overview]
Message-ID: <aqPG7GvpCFhmC7Un@ashevche-desk.local> (raw)
In-Reply-To: <20260911103827.00003bde@gmail.com>
On Fri, Sep 11, 2026 at 10:38:27AM +0200, Joshua Crofts wrote:
> On Thu, 10 Sep 2026 16:13:05 -0500
> "David Lechner (TI)" <dlechner@baylibre.com> wrote:
...
> > +#define ADS112C14_INTERNAL_CLK_Hz 4096000
>
> 4096 * KILO?
>
> Otherwise LGTM.
>
> Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
HZ_PER_KHZ rather than KILO.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-09-11 9:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 21:12 [PATCH v3 00/10] iio: adc: ti-ads112c14: add filter support David Lechner (TI)
2026-09-10 21:13 ` [PATCH v3 01/10] iio: adc: ti-ads112c14: add DRDY interrupt support David Lechner (TI)
2026-09-10 21:13 ` [PATCH v3 02/10] iio: adc: ti-ads112c14: create data read helper functions David Lechner (TI)
2026-09-10 21:13 ` [PATCH v3 03/10] iio: adc: ti-ads112c14: add continuous mode support David Lechner (TI)
2026-09-10 21:13 ` [PATCH v3 04/10] iio: adc: ti-ads112c14: add burnout current support David Lechner (TI)
2026-09-10 21:13 ` [PATCH v3 05/10] iio: ABI: add sysfs attribute for _burnoutraw David Lechner (TI)
2026-09-10 21:13 ` [PATCH v3 06/10] iio: adc: ti-ads112c14: support external clock David Lechner (TI)
2026-09-11 8:38 ` Joshua Crofts
2026-09-11 9:16 ` Andy Shevchenko [this message]
2026-09-10 21:13 ` [PATCH v3 07/10] iio: adc: ti-ads112c14: add filter support David Lechner (TI)
2026-09-10 21:13 ` [PATCH v3 08/10] iio: ABI: add sinc4+sinc1+pf1 filter_type David Lechner (TI)
2026-09-10 21:13 ` [PATCH v3 09/10] iio: adc: ti-ads112c14: add settlingtime attribute David Lechner (TI)
2026-09-13 20:11 ` Jonathan Cameron
2026-09-10 21:13 ` [PATCH v3 10/10] iio: ABI: add settlingtime attributes David Lechner (TI)
2026-09-13 20:17 ` [PATCH v3 00/10] iio: adc: ti-ads112c14: add filter support Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqPG7GvpCFhmC7Un@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=c-hall@ti.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=kuurtb@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=pedwards@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®