From: Frank Li <Frank.li@oss.nxp.com>
To: Rosen Penev <rosenp@gmail.com>
Cc: dmaengine@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
Frank Li <Frank.Li@kernel.org>, Yuri Tikhonov <yur@emcraft.com>,
Dan Williams <djbw@kernel.org>,
Anatolij Gustschin <agust@denx.de>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: ppc4xx: use assigned variable for dma_free_coherent()
Date: Fri, 11 Sep 2026 10:04:51 -0500 [thread overview]
Message-ID: <aqQYk44DLfkT8w4l@SMW015318> (raw)
In-Reply-To: <20260911035941.200551-1-rosenp@gmail.com>
On Thu, Sep 10, 2026 at 08:59:41PM -0700, Rosen Penev wrote:
> In some goto paths, adev->dev is unassigned. Use &ofdev->dev to cover
> those cases.
>
> Fixes: 12458ea06efd7b44281e68fe59c950ec7d59c649 ("ppc440spe-adma: adds updated ppc440spe adma driver")
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
Please use dmam_alloc_coherent() to fix this problem.
Frank
> drivers/dma/ppc4xx/adma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ppc4xx/adma.c b/drivers/dma/ppc4xx/adma.c
> index 279a431ccae3..d0863394c723 100644
> --- a/drivers/dma/ppc4xx/adma.c
> +++ b/drivers/dma/ppc4xx/adma.c
> @@ -4212,7 +4212,7 @@ static int ppc440spe_adma_probe(struct platform_device *ofdev)
> else
> iounmap(adev->dma_reg);
> err_regs_alloc:
> - dma_free_coherent(adev->dev, adev->pool_size,
> + dma_free_coherent(&ofdev->dev, adev->pool_size,
> adev->dma_desc_pool_virt,
> adev->dma_desc_pool);
> err_dma_alloc:
> --
> 2.55.0
>
next prev parent reply other threads:[~2026-09-11 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 3:59 Rosen Penev
2026-09-11 15:04 ` Frank Li [this message]
2026-09-11 18:08 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqQYk44DLfkT8w4l@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@kernel.org \
--cc=agust@denx.de \
--cc=djbw@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rosenp@gmail.com \
--cc=vkoul@kernel.org \
--cc=yur@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®