From: "Michal Koutný" <mkoutny@suse.com>
To: Noah Feldt <noah@feldt.systems>
Cc: Tejun Heo <tj@kernel.org>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
N.Feldt@mittwald.de, carnil@debian.org, dschatzberg@meta.com,
hannes@cmpxchg.org, peterz@infradead.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] cgroup: Avoid iteration of dying tasks with zero refcount
Date: Fri, 11 Sep 2026 18:11:42 +0200 [thread overview]
Message-ID: <aqQlowpkYrTaVmid@localhost.localdomain> (raw)
In-Reply-To: <aqAtv3WVn51LN3E8@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 608 bytes --]
On Tue, Sep 08, 2026 at 05:55:45PM +0200, Michal Koutný <mkoutny@suse.com> wrote:
> Though, the fix loses a bit of elegance. Hm, thinking...
So, it occurs to me that the ->live based predicate from v2 might break
CSS_TASK_ITER_WITH_DEAD callers (zombies they asked for would be
skipped).
We need to distinguish between (both on dying_tasks list):
- regular zombies waiting to be reaped and
- RCU remnant tasks that are going to be free'd.
IIUC these two are split on the ->usage count. (Correct me if I'm
wrong.)
I'm starting to like the tryget_task_struct() approach from v1 again.
Michal
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 265 bytes --]
next prev parent reply other threads:[~2026-09-11 16:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 19:27 Noah Feldt
2026-09-08 15:55 ` Michal Koutný
2026-09-11 16:11 ` Michal Koutný [this message]
2026-09-11 16:57 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2026-09-07 17:03 Michal Koutný
2026-09-07 17:07 ` Michal Koutný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqQlowpkYrTaVmid@localhost.localdomain \
--to=mkoutny@suse.com \
--cc=N.Feldt@mittwald.de \
--cc=carnil@debian.org \
--cc=cgroups@vger.kernel.org \
--cc=dschatzberg@meta.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noah@feldt.systems \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®