From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCAA949362E for ; Fri, 11 Sep 2026 16:08:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.135.77 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789142910; cv=fail; b=ivR9IsCc6RNQIajh3pLmwkhKfBZbrAj2WQE/9+K26KpBqSfuF0tHSKA0aWkwaU7Fs+IAvNVHDcfUFjS+9i3NmvRqzDS4UBEvdHOaf9xSuHO54c6xXiZeCHANxNMxrIpx7MO9gCXHN8q+W0VT1FupgsvqOrGjuFAbCaHo/iu64SI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789142910; c=relaxed/simple; bh=RVyPPBY9lNgYQH6g+HHqnk8eI2hXoGBRBYaOH6u/kLY=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=SkNlzdyYXO2cbsS4z5r+nQub3w6vuv+P2jLU02Vx7/zN2qXZnUfoYsw71eqaMRkBVlSdgu3fIEgW6kXWCXBFzVdIZjvFvlda2VZbCp8dGkeF6+mrTsEG5xNRS8OQ15jpxcARSzZVUH9hHPapOzsHIEy8e4DeGF4LO74LZV6HT9Q= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=mvPuD0Qh; arc=fail smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="mvPuD0Qh" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68BEj9rC2838484; Fri, 11 Sep 2026 12:08:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=x1zyd N8rr3Hagige9GKJKwgbeHd/BTkWJHP5weQvo2Q=; b=mvPuD0QhG5MyitCdxMskv VceHpjBjaz5mGfrze5Zo42a7yf3L+HIrZyvm8n7zoKglJesAt4chb8o3GLGDor/p dICWOCMJbrSj02H9FJ3aPz7CCAvJXrFUBPmO5nXsueEg9yj9FVLUhtVu3L7Uf3kK D60GmHPx5ghcY00s5AUX7xdmo8Og4NxrM+B4Lpp0LAt0/fwmtI1ETkphvznjtTnG KFjmJN5RD7iYQu020iIr/x2YRDuX8S9ilskNHjCgIDVhxMqNqeM4IFVwuqHwXygH eC7vEa9X6ZUO9TFyDKtgWaLW3+vmT54c+E3VE4o5pqLGTIbtyP+MszIUDPdc5agv w== Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11012062.outbound.protection.outlook.com [52.101.43.62]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4gkcxd1ws0-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 11 Sep 2026 12:08:13 -0400 (EDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wGD4bgvWLmV77pdaOf4RmK9CTWfjOXRfw+KHP3K8XP6++K/BRsuoZRK5cRLPwJ/zSfC3ICsB1mtCdrSNCIn5wYvJnWOh4LhSMJtCKmmJEv9VN4Vhs4VUS5X3Hg2DflHMC3PI70mgSFgmRHZfb5eUfrgdkeU/1+6LaSLV0nzoj8+MWRcTsu2aXp8xJh/teuHYemJdYugPkebWC7dD8B62Xeb2/Cne++uzlyZwq3lYoDQR62OudKchYn8nSujgLwe59bdYOJcIOmMs4c59hydrzQFsjYRnA9k9MvZuV3J/RGkwJLnwZtla0cHMIUqCs2VNESj1K/qDHGrIsmgd1NZimQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x1zydN8rr3Hagige9GKJKwgbeHd/BTkWJHP5weQvo2Q=; b=rHO2xXwcBiVpcsMpYUqyQ4KGiQ6V+3BWQx3AfO/urG8rjyZPaKotz1/IkizOP9GDYXKbVaWMxubgcxeV/QH+bubNNYQUh/vltl/y/NRBr04svu3/rhniJ8qc7nal1kpu4mqLEI5u2BgVS5QoLKdqrvUkR1w+8sSKwZPvE9THGSU+S31V0GHdzhsVy+veFJFvWeEtVHgcscJRzEZ6WU00lgXxaGMmN6YTUplGweyRQvXkbNgKaDAubA3WRRFdQ8dzx9e2e+4hamliDhvkNK6gTTUf6foMGK2fcI3i5GjZiMkZ+5qBFcf4jHCsuyBfsz9NCVFaKx6uxuIsUuWk8tSFNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=analog.com; dmarc=pass action=none header.from=analog.com; dkim=pass header.d=analog.com; arc=none Received: from SJ0PR03MB5469.namprd03.prod.outlook.com (2603:10b6:a03:28a::17) by PH0PR03MB6352.namprd03.prod.outlook.com (2603:10b6:510:a9::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Fri, 11 Sep 2026 16:08:09 +0000 Received: from SJ0PR03MB5469.namprd03.prod.outlook.com ([fe80::2a19:76b2:e731:8c5a]) by SJ0PR03MB5469.namprd03.prod.outlook.com ([fe80::2a19:76b2:e731:8c5a%6]) with mapi id 15.21.0406.007; Fri, 11 Sep 2026 16:08:09 +0000 Date: Fri, 11 Sep 2026 17:09:24 +0100 From: Nuno =?utf-8?B?U8Oh?= To: sashiko-reviews@lists.linux.dev Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Miquel Raynal , Pratyush Yadav , Michael Walle , Vignesh Raghavendra , Takahiro Kuwano , Richard Weinberger Subject: Re: [PATCH 2/2] mtd: spi-nor: issi: Add support for is25wx01g Message-ID: References: <20260911-mtd-spi-nor-new-issi-chip-v1-0-c54615f8c30f@analog.com> <20260911-mtd-spi-nor-new-issi-chip-v1-2-c54615f8c30f@analog.com> <20260911154412.B53B01F00893@smtp.kernel.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260911154412.B53B01F00893@smtp.kernel.org> X-ClientProxiedBy: MA3P292CA0035.ESPP292.PROD.OUTLOOK.COM (2603:10a6:250:46::14) To SJ0PR03MB5469.namprd03.prod.outlook.com (2603:10b6:a03:28a::17) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB5469:EE_|PH0PR03MB6352:EE_ X-MS-Office365-Filtering-Correlation-Id: e74f71d5-13c5-4749-34fe-08df101edf04 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|376014|366016|4143699003|11063799006|56012099006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: niuTUYL1Mg8hqOLaSJiWaQxcNjiHA8fvN1GZ+m/kKczeit0NV1Jax9eTubrSi+UHW2zMt4L5SgTls/F/y1CvbK/AqtjV9AblUkIKKjIezGi72bx7q8MJUutoneE9M9wu/Uj7v5FuxIEYCeN3etRy6pM2pbeCUwt1wK2OFcY86gGPB/dPXQK0U7RLFBYTKlkMp1EcfD+MxP2aL4y+yBdumpIkSxH5/gct69Gtjtcwz92sbmJDb8Q7BKP/2Xu/+djgkyHvgFXLPdwIXodsgPtwPWQbJymSQTGlKFpz1Lwk76bzlU2tyWMiJSEEns+GW1vD56s7a4I8PPnQnBAB/5j1MH6l5xcCEWJjZLcCFUgA8kiR5rWO5Ztl22L2RLAAsQobTJBg8Q/bcBMguZCYEpNYySUU65X/jDbDVHIWFCzCEOdtnnUzAYx1QD6ynzQgOJ+zBGjpzr3ydIIHEtz5K6/fedXVt0R19fEmrQWaqCtr+fexUqp/IQ36QrBUwHSaLeUycXdGcs+RtyaRWwrvZL8dJ8ue9DLlFmjJOj399GBFJ3eb6FL0gIG7DE2MM5ELu2mKePg2nOXdOHMVAFUo/9+6QExD3clSx3BXKstPluo4c/Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5469.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(376014)(366016)(4143699003)(11063799006)(56012099006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVJWZjVVd0xyMUxJNU9qcXFjTmFDNGZTclFnaEhIL3haUzFWbVI5bmN2Y0VN?= =?utf-8?B?dHBMRTVHV2VPSEJNZGxJalFGRGc3SUtyUHhpYzJYS1hCSFBrUFo0M2dwMi9W?= =?utf-8?B?eTZDbEp4QW52KzYzM0F3VEdEbGNDWGU3YlFOOCtJVDQ2WEpIL0wvSUtNVkhm?= =?utf-8?B?VUJ5S21meWRBbmM5K2RGTUoydjUzVFNTQ3FmWVdiUFAwcFZSeG1keUtFcEMw?= =?utf-8?B?WXNQYldiaFppa3k0K1Z0Z0NaNTNGSUd4SnQvS1JtNU5oNzFQZnU3VEhYaVhO?= =?utf-8?B?TDV4cGt0TFdLVFAyWk5rRXBHbTJmTWZvSjdvb2thcjdqckt0azlPZ0RCK1U5?= =?utf-8?B?MVQwcm9FS0ExYTlyck5JT28rdmZuUE9oaUlUWkl2bW1NbU41RnltL3lYZWEy?= =?utf-8?B?R0MxSEN4OTVHN2VjenlLcHJncnBsem1uUHh2eTlyQ0JlbUhrcDk1cEVsdzBk?= =?utf-8?B?YnpuRTZDL3lqM2VrTmREOWM4VkEvZVMxdnJWMzUvcDJnMGxHK0V1dHY4TUYr?= =?utf-8?B?YTFJRE5mTHhhWWRoc2dZVUF6UG5ZOGNTVmRUeDRGWVNja2wxaU00SXBIQkp6?= =?utf-8?B?bnJYbFY0dmxRb3dCOXFxK0Z2S08yUWt4OWpMOElETzJrcVlqUXdPelM1akhW?= =?utf-8?B?NU9JVUxkdkhhbm41ZWxxM0dTR2JhQ001UG5BMHNCTUFTRmRGWDh2MzdpSjY5?= =?utf-8?B?SFE1aXQ3c1h6THZmZ05HRll5bjlTUVI3aUtIVHJhQ2NOODhWR2tUdmlmV2Vq?= =?utf-8?B?UWZNZlFNSjBsYU5KZGlYMHQzZHdPVUpWS1YxY0xuRzNJL0t3V0dCQVkzUVlC?= =?utf-8?B?Q2E1alNWcXVRTG1hWUhVdXQ1VFlnSGFET3hyYWU1d2tyTWwvMDM3bDVtNHpJ?= =?utf-8?B?MnlOTDlVdlZib3ZLemp2UGpBZzF1L21CUldkSkJBWjF6Mm14aWtHSjJWRWpn?= =?utf-8?B?ei9icy9kTjBTZE1xTmE2dG9qNmZPL0pUYzNYcDVQeGNIZEpFNTMvYXNYMC9O?= =?utf-8?B?QW45eW5PUVBZMFppZGFPcW5aS2xQTFk1czRza2ZHSFdxY1JBa2JIcWVBd2tq?= =?utf-8?B?d0UzNnhxUG9wVFM5NTZCVzFNcnRJVFJFQ2xQK0dMVmNlSWpBUmJTZ0VYbjBD?= =?utf-8?B?cnVyWjJ0T2wvZnhxUXp3SXRxNzFaeXpBWXdtRHl4TWhCN3RITE5FSVhkQm5I?= =?utf-8?B?TzMyK2FTbTVZZW5QOXdGemNxU0lIRmpTYUdhNldpLzJQSncvUnNjbk5pZkVU?= =?utf-8?B?Uzc0ZHlRMW8vY3BWdGdXVnZoeGVoL1YvSzlDYk1leHFOUktaaWlFVVIyZzhW?= =?utf-8?B?UElGWDlhMWsrekd0TGp0SEtDdEg3QjRNMEdmRjNvNy9xRW01VVA5Zy9FWlAx?= =?utf-8?B?K21XaUIzYzVYVXUxSDJLNDN6cXQzQ3B1VnJ3WE80b3ZtanBqaTRYM2RFMGFP?= =?utf-8?B?OHpYTXNGbHl1WHN6MlB5bjgzTlNNK3RpS3V5L0pydms4eS9CdnlJeWwwQ0ZH?= =?utf-8?B?ZDI1eFB3WmNsajZORndHQi83T1kwTDA4RnJwUkt0RTNxdXYrRktGL2hXNTJx?= =?utf-8?B?dXRqN0s2bFBvVjhnRVdmSjJIc3RLbVpFWVdOMWFOckNyazNvSVl3d2U2Mk5V?= =?utf-8?B?SGxHRVZmSWovOGlhbGxUWm52RWpXZ3czUkhPcnoxZ2V5djlqaG55L2t0ckxl?= =?utf-8?B?Vk5qMFg1aldVVU9PVWhlWUp4dUxLelNSR05qMHEwZzZTOXdRN3lHUlMraVdn?= =?utf-8?B?ZE1Ra3ZmSmFRdXJTMlBBZXNpeDBXamwyZmZPVjFCMEFRQlBFbS8yYjYvVjd4?= =?utf-8?B?c3ZxUGtjQkFtUmRrTXhTdzdSS1VjUmRnSloxNmUvd09TVzJaK1EzV0tIVWVh?= =?utf-8?B?Qys3dXc0bTloL1ZKZEhqb1JVcGNLNVBvNEh2b3d0bDJwVWpLOFp3MXJ4aUg5?= =?utf-8?B?OHc3c3dSa0RQOGFMeFljTnFIL3dXL2tZWG9YTHk0V3ovUmJoT3FIblB2aXFN?= =?utf-8?B?eEZjZ0NGbUFISm1WZWxZUWgxQndEeDRjRklXSE1uZ0tBNkFRYmpUWjZvSExB?= =?utf-8?B?cnVyZmhxVFlmOTRUeUtyOEU3UlRDOWhmellNZUFHVGFhMTYyOUsxWU5BMU43?= =?utf-8?B?T3hlOUp0UTZmRWp0cDJMTmRLUEowbHNub1JJQkJrMlFjRzMrZjVTM0RIRmhi?= =?utf-8?B?bE1DTjFVWFhVdllaZW02cDNTbFd1UEh0TEZ6RVdVZnFNakdjV0hleHlEa2p1?= =?utf-8?B?Qy9OeEtueGphOVpjUXBTaVVQejZHeTVFTlZPMndxMTlBVUdqQ1FPMktnNzZP?= =?utf-8?B?OGNUVWlaTkkwdjJkNUtaQW9jVHhHai8zRzRFS3pBc1dtd0puQ3FaUT09?= X-Exchange-RoutingPolicyChecked: HRp0m2Qso1udmdIb46CbC2K2t/DpPXrfs41UtUPSVzzmMRP34DeFp14Lbp2vNEhvV91GpWOQceaDgJMdGTr+uVfq0/GMbIITQIvrQIHB/GR2dbjC07NWuoeZqCTa5wU5Sha1ypQVCaMbA8IrzkqzDx3KnUs4uk/wCE3SDzy+OeqQHTVlLe4t0zEyHDNULkU+E99+FzjmOHtuXbkijjGQjDMzeaCoQ3cq+p6DftPC8aZOXCfkxroB+03b4PAJ+pcv+tmJDs8vmgpQfITFSiVmdZb0ZiIJbspatUvaa5fEYBZotp+LJ/PIY80vZYF/qSAFvVzrZXNrH+bwOtDcjlrdPQ== X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-Network-Message-Id: e74f71d5-13c5-4749-34fe-08df101edf04 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5469.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2026 16:08:09.1393 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T9QD46yQaWxH/gPlESkN3oJJQD34W5MeZ7tRwcR7mAu3PYXXlaT2/l8Gi8wQ8qFPa9W714bEasuMKFiKRm25PQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6352 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTExMDIyNCBTYWx0ZWRfX2D5DH7zb0ffN xY3GBBQEoyGkH9n0tJHs/zu4a5ZB8QRY/68FDwfjMtzbIbn8HsRuWzTASq53mIt46IiTMqDivEv djxdH+5SF2hqC9O1XQ5NcpnlHQk3I1lQ+IBPHOZhVUTOTlbdsx4bjyud4vbEiEKUAOvTFXoFUQS oSDC1XX2UQ5Ce5viFNPMwNfY0kowxgEzkXjF0IPE3dbZCw229bGbfQqcCD9/HDlWgvYatXlTUAs iJCgkEnvWwym57RPF7E9HDNrG3AQSETRKafqfFlpxYl/w5lWcQYKnwlw1nw4e13emcQiaN7vydS vkp9fu0cR2fftEZNLrah75sviINTFUGkUDu8+34uRXh/o4q656hMbTN3a0QtITMl5DAHE70cyI1 Dee5koESzfbJ1OSYW5I+ou8JCDgKcBMcPWvaEODuD7UDioxYBWN1qLY8hSPBJNQdw/Yvw6IWe5w zDmwFc4Vf6LQnY6Sa6g== X-Authority-Analysis: v=2.4 cv=GoTXaU1C c=1 sm=1 tr=0 ts=6aa4276d cx=c_pps a=qMfGPIaByV4ZnHoTJsbowg==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=M51BFTxLslgA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=OmVn7CZJonkx5R5zMQLL:22 a=c92rfblmAAAA:8 a=gAnH3GRIAAAA:8 a=VwQbUJbxAAAA:8 a=i62mXw7PhaByAR17FdMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvGzcOZaWPEFPQC_NcjD:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTExMDIyNCBTYWx0ZWRfX7LHSplDU1VRj NQDJjRcndA7evubqdkbnUk7dz5sVS9FyNaYw2dxeTVQIXmTXp9akKEEQVuFXmblOIOOHC+LjvfX oVU0loB2EogvEN0XQWoul/QQiPJ0bgdOCh01jcYlypfabw24Sdmz X-Proofpoint-GUID: GvcHbyxTxeKOafppkaEh1hd3X-WKGc50 X-Proofpoint-ORIG-GUID: GvcHbyxTxeKOafppkaEh1hd3X-WKGc50 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-11_05,2026-09-11_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 priorityscore=1501 spamscore=0 clxscore=1015 impostorscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609110224 On Fri, Sep 11, 2026 at 03:44:12PM +0000, sashiko-bot@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Low] The patch introduces multiple build failures due to an incomplete forward-port from an older kernel version. It references non-existent struct fields, uses an undeclared flag, and attempts an outdated method to disable 16-bit status register writes. > -- > > commit 2a2f93cf391e237e4b5b711cef68cc225e2bc2fe > Author: Nuno Sá > > mtd: spi-nor: issi: Add support for is25wx01g > > This patch adds support for the ISSI IS25WX01G 1 Gbit octal NOR flash. It > relies on SFDP and provides BFPT fixups to handle the lack of a 35h command > and to disable the quad enable method. > > > diff --git a/drivers/mtd/spi-nor/issi.c b/drivers/mtd/spi-nor/issi.c > > index 2f057d731df2a..aac9d19b90fcf 100644 > > --- a/drivers/mtd/spi-nor/issi.c > > +++ b/drivers/mtd/spi-nor/issi.c > > @@ -29,6 +29,29 @@ static const struct spi_nor_fixups is25lp256_fixups = { > > .post_bfpt = is25lp256_post_bfpt_fixups, > > }; > > > > +static int is25wx01g_post_bfpt_fixups(struct spi_nor *nor, > > + const struct sfdp_parameter_header *bfpt_header, > > + const struct sfdp_bfpt *bfpt) > > +{ > > + /* > > + * There is no Status Register 2 and no 35h command. And WRITE STATUS > > + * REGISTER takes a single data byte. > > + */ > > + nor->flags &= ~SNOR_F_HAS_16BIT_SR; > > [Severity: Low] > Does this code compile on the target tree? struct spi_nor does not appear > to have a flags member in the current API, and SNOR_F_HAS_16BIT_SR seems > to be undeclared. Ok! It seems I was over confident and it seems things changes in spi-nor/next! Will fix it and resend!! - Nuno Sá > > > + > > + /* > > + * The BFPT Quad Enable Requirement field is set to a reserved value, so > > + * spi_nor_parse_bfpt() leaves the quad enable method at its default. > > + * Make sure we disable it as there is no quad mode anyway. > > + */ > > + nor->params->quad_enable = NULL; > > + return 0; > > +} > > + > > +static const struct spi_nor_fixups is25wx01g_fixups = { > > + .post_bfpt = is25wx01g_post_bfpt_fixups, > > +}; > > + > > [ ... ] > > > @@ -120,6 +143,10 @@ static const struct flash_info issi_nor_parts[] = { > > .id = SNOR_ID(0x9d, 0x70, 0x19), > > .name = "is25wp256", > > .flags = SPI_NOR_QUAD_PP, > > + }, { > > + .id = SNOR_ID(0x9d, 0x5b, 0x1b), > > + .name = "is25wx01g", > > + .fixups = &is25wx01g_fixups, > > [Severity: Low] > Does struct flash_info have a fixups member in the current framework? > It looks like fixups might need to be registered via struct > spi_nor_manufacturer and its fixups array instead. > > > } > > }; > > -- > Sashiko AI review · https://sashiko.dev/#/patchset/20260911-mtd-spi-nor-new-issi-chip-v1-0-c54615f8c30f@analog.com?part=2