From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 798444A5C3C for ; Fri, 11 Sep 2026 16:37:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789144631; cv=none; b=sYdxTUArF9g0aEfuD4A1a2cdnZ9UrfNFhY1TPCQ+mrez1qKEsh1WxTJTkX2M+7C43/R4quvrk8gD3IpUq0uu6ixvYF71ngZh9wfhls2Bp5Z0+t8H0dBIpo5cjlPpqeslxHok8zZqgdaIMOjxqy8aeKiIHIkli9z2MbU7mHM6MiQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789144631; c=relaxed/simple; bh=4mfLk97WGWUYO0LzVc/bd26XHKUDdtW1nlfPHmu3EKI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=op0qQKxeIAK9rrZ0/L9BCeFm0ocwgnjAB2DE2M89VjsMp0VUL1RVB9g4VTfUNh37yGPNivanZaB+uFUnoNFcjqpBgDQK5gal6lFB+0dbXUgjRG/t282NCL0G7wU9mWqYcy5mWZMhHXv5aJYiB+YrFEObvrD3L3pUPSCGSCTKNSM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FsnlUFUB; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FsnlUFUB" Received: by mail-pj2-f13.google.com with SMTP id d9443c01a7336-2d747ee1f9bso307835ad.3 for ; Fri, 11 Sep 2026 09:37:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789144624; x=1789749424; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=5Z3nbbb1FAl9xLQpw8Rh7y5TS4mkzVFghEZ+69cMYSA=; b=FsnlUFUBuMlYjlrSnyqWYviUKVY0u+jcU6HD9lAFaKkbJzEKgC4qAYpwnNvjh8dMFY N5Kj8C0GVXBjmtYp02jgc/t96ZZGErkMGI6C5quG9FMp16gGBTOThaT9UspyR17AWjR/ 0ibAkMgRrsHv4FxrDIIdIV6yhA7Xs8MDtNqvpNTL9ZywG/4E5HLhXg8t0EkTalmLXGBU SwvZuu49OoqWlievrMOFp7rqkYSxDanTgep0AUEV+0XIHXTqg7cePeksolbY6JH6rFJp Zg9b/Z32yt5Wzq69gNgV6PsldK3PMIsQFDBCQFLHqoqBouqkE/y7NKQrf8XAzQYtBKzD v1tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789144624; x=1789749424; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5Z3nbbb1FAl9xLQpw8Rh7y5TS4mkzVFghEZ+69cMYSA=; b=SC6A07H04b1+mxLgEYPnqqpfZwh4/+FfS684Hqst1bplE9iPHdjzzRkpKPl4yZHVd+ x6Ad6jGszpVPpSjK2rSgx+qjkQTpl32n/MDrfV8WRYBtfLa9Jb5Dk5cbNIoMIX39nbAy wFdUlbAjmxUblHks53nx4RwbIK4ueJUO9Fc6wjF/Z+O5wyOy9qX9cJrxfao3OxkDSW2s MjAAzvaPsKS+pKRqZ4MrxPmSzj72YEtvBaFszgt8HYqau2jmwHR3RjdyT9BxkY3iyJlS fuSPx9y6JJxm+6yPuojGX/sXikOQjwtLpBVR5trugbXHhMHHmCLenMl3UhTIHELwGrzx /TSA== X-Forwarded-Encrypted: i=1; AKwUvBwcReDX2ipcp6l/4qjdWqXWD0EoX7l7qiUiK4rzc6EthxUP63ekuUWrK1+mBOQZ42bGOHUphiFQZOrj7zU=@vger.kernel.org X-Gm-Message-State: AFuF++kQb4I1xrMluuUc+ik6cVNifDpRLzlhGNmoF/M+sRSV8r8slxRE Acm4ac4mv5vvrCdQeI8f4OWcEwKavOeXVSczz6L+2CdTcTH/9yH21lGWM6xR7A== X-Gm-Gg: AYBFou0y71SNvDXQ7chvb+LzkBXItReAcmi14idhtWpX4tRrlt2u++8rT49Mc5Rl3kq yk6uhUedRyRQcM8Npv5Z+siuBKlq2WlG6M73+tivaXliIsLMwnry2eaVOFqAY0L3mjAuacydVHZ iy809DJIP6aIu07O+nGf1U4IlK47jYIdLBfxJz5eBMSbsytQqdW35Z9pFI5hwzLA2LVlF5GgAK3 Po6BZu6V8+fxxUIQ8Ibd/JMODfX6J6PtKsGx0fCSV4AmNjOfZ3SOSB6jDjDhg/Qn6f3C02fz+4Z N240QUh96d8pkgV9JpdqEekZFOUVPcDNSIBYsH76VWuMxVresB/iLDWUw5P9QK7w1LdofTd9qXq SHmgPJNM8COfBgPFzTrjMGtahDp7KLoAPGLbyZxTcdoPsZeVm2/P7cVTIkn3XJT0gq9tX8mCCOZ tryY7DXd2oGgV5DZ8rRTPmFTXsTAa50LGR2R+ayc8adzvAkB9UpJ/LyyzAcLJU4fX2KUvV+NTdL HfhWne66FhysdtG7niPQW6aTwz+xjRsxU4oG7wY X-Received: by 2002:a17:903:1ac5:b0:2db:539c:b7c7 with SMTP id d9443c01a7336-2dd2a46d478mr99060775ad.20.1789144623880; Fri, 11 Sep 2026 09:37:03 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:7e36:d696:74c7:8be3]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33ba4f55735sm8349902eec.24.2026.09.11.09.37.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 09:37:02 -0700 (PDT) Date: Fri, 11 Sep 2026 09:36:59 -0700 From: Dmitry Torokhov To: Jiri Kosina Cc: Jonathan Jansen , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, bentiss@kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH v2] HID: input: map System Microphone Mute LED Message-ID: References: <20260904022903.607880-1-ait@ait.place> <20260904044705.1060507-1-jonathanjansen@ait.place> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Sep 11, 2026 at 05:58:24PM +0200, Jiri Kosina wrote: > On Fri, 4 Sep 2026, Jonathan Jansen wrote: > > > HUTRR110 defines LED page usage 0x57 as System Microphone Mute. > > > > The usage is currently ignored, so the indicator stays dark and > > userspace falls back to per-vendor code in hid-lenovo, > > hid-playstation, hid-plantronics. > > > > Map it to a new LED_MICMUTE. It appears as > > /sys/class/leds/inputN::micmute and uses the "audio-micmute" > > trigger from snd-ctl-led, so the LED follows the system-wide > > mic mute state the same way LED_MUTE (page 0x09) already does > > for speaker mute. > > > > LED_MICMUTE takes the next free code (0x0b). > > > > Link: https://www.usb.org/sites/default/files/hutrr110-systemmicrophonemute.pdf > > > > Signed-off-by: Jonathan Jansen > > --- > > > > Notes: > > Changes since v1: rewrote the commit message; no functional changes. > > > > drivers/hid/hid-debug.c | 2 +- > > drivers/hid/hid-input.c | 1 + > > Acked-by: Jiri Kosina > > for the drivers/hid changes. > > Dmitry, will you take this through your tree, please? Hi Jiri, Jonathan, Sorry but we should not add any new LED definitions to input since we have proper LED subsystem now. The existing LED definitions are strictly legacy now and input core has a bridge to LEDs (in input-leds.c). I see we had similar submissions in '23 and '24 at the very least. I should add a comment to that effect to input-event-codes.h. Thanks. -- Dmitry